From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 10/15] ata: pata_pxa: remove the dmaengine compat need
Date: Sat, 21 Apr 2018 21:32:11 +0200 [thread overview]
Message-ID: <87sh7oxsn8.fsf@belgarion.home> (raw)
In-Reply-To: <20180402142656.26815-11-robert.jarzmik@free.fr> (Robert Jarzmik's message of "Mon, 2 Apr 2018 16:26:51 +0200")
Robert Jarzmik <robert.jarzmik@free.fr> writes:
> As the pxa architecture switched towards the dmaengine slave map, the
> old compatibility mechanism to acquire the dma requestor line number and
> priority are not needed anymore.
>
> This patch simplifies the dma resource acquisition, using the more
> generic function dma_request_slave_channel().
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Bartlomiej, could I have your ack please ?
Cheers.
--
Robert
PS: The submitted patch
> ---
> drivers/ata/pata_pxa.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c
> index f6c46e9a4dc0..e8b6a2e464c9 100644
> --- a/drivers/ata/pata_pxa.c
> +++ b/drivers/ata/pata_pxa.c
> @@ -25,7 +25,6 @@
> #include <linux/libata.h>
> #include <linux/platform_device.h>
> #include <linux/dmaengine.h>
> -#include <linux/dma/pxa-dma.h>
> #include <linux/gpio.h>
> #include <linux/slab.h>
> #include <linux/completion.h>
> @@ -180,8 +179,6 @@ static int pxa_ata_probe(struct platform_device *pdev)
> struct resource *irq_res;
> struct pata_pxa_pdata *pdata = dev_get_platdata(&pdev->dev);
> struct dma_slave_config config;
> - dma_cap_mask_t mask;
> - struct pxad_param param;
> int ret = 0;
>
> /*
> @@ -278,10 +275,6 @@ static int pxa_ata_probe(struct platform_device *pdev)
>
> ap->private_data = data;
>
> - dma_cap_zero(mask);
> - dma_cap_set(DMA_SLAVE, mask);
> - param.prio = PXAD_PRIO_LOWEST;
> - param.drcmr = pdata->dma_dreq;
> memset(&config, 0, sizeof(config));
> config.src_addr_width = DMA_SLAVE_BUSWIDTH_2_BYTES;
> config.dst_addr_width = DMA_SLAVE_BUSWIDTH_2_BYTES;
> @@ -294,8 +287,7 @@ static int pxa_ata_probe(struct platform_device *pdev)
> * Request the DMA channel
> */
> data->dma_chan =
> - dma_request_slave_channel_compat(mask, pxad_filter_fn,
> - ¶m, &pdev->dev, "data");
> + dma_request_slave_channel(&pdev->dev, "data");
> if (!data->dma_chan)
> return -EBUSY;
> ret = dmaengine_slave_config(data->dma_chan, &config);
next prev parent reply other threads:[~2018-04-21 19:32 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 14:26 [PATCH 00/15] ARM: pxa: switch to DMA slave maps Robert Jarzmik
2018-04-02 14:26 ` [PATCH 01/15] dmaengine: pxa: use a dma slave map Robert Jarzmik
[not found] ` <87604kz7mu.fsf@belgarion.home>
2018-04-22 6:13 ` Vinod Koul
2018-04-02 14:26 ` [PATCH 02/15] ARM: pxa: add " Robert Jarzmik
2018-04-03 6:51 ` Arnd Bergmann
2018-04-03 15:18 ` Robert Jarzmik
2018-04-03 15:39 ` Arnd Bergmann
2018-04-03 20:19 ` Robert Jarzmik
2018-04-04 10:18 ` Arnd Bergmann
2018-04-04 19:21 ` Robert Jarzmik
2018-04-02 14:26 ` [PATCH 03/15] mmc: pxamci: remove the dmaengine compat need Robert Jarzmik
2018-04-02 14:26 ` [PATCH 04/15] media: pxa_camera: " Robert Jarzmik
2018-04-21 19:27 ` Robert Jarzmik
2018-04-22 11:06 ` Hans Verkuil
2018-04-22 11:06 ` Hans Verkuil
2018-05-04 19:29 ` Mauro Carvalho Chehab
2018-04-02 14:26 ` [PATCH 05/15] mtd: nand: pxa3xx: " Robert Jarzmik
2018-05-18 21:31 ` Daniel Mack
2018-05-23 21:54 ` Daniel Mack
2018-04-02 14:26 ` [PATCH 06/15] net: smc911x: " Robert Jarzmik
2018-04-02 14:26 ` [PATCH 07/15] net: smc91x: " Robert Jarzmik
2018-04-02 14:26 ` [PATCH 08/15] ASoC: pxa: " Robert Jarzmik
2018-04-12 15:26 ` Mark Brown
2018-04-12 16:55 ` Robert Jarzmik
2018-04-02 14:26 ` [PATCH 09/15] net: irda: pxaficp_ir: " Robert Jarzmik
2018-04-21 19:30 ` Robert Jarzmik
2018-04-23 8:37 ` Greg Kroah-Hartman
2018-04-02 14:26 ` [PATCH 10/15] ata: pata_pxa: " Robert Jarzmik
2018-04-21 19:32 ` Robert Jarzmik [this message]
2018-04-24 11:04 ` Bartlomiej Zolnierkiewicz
2018-04-02 14:26 ` [PATCH 11/15] dmaengine: pxa: document pxad_param Robert Jarzmik
2018-04-02 14:26 ` [PATCH 12/15] dmaengine: pxa: make the filter function internal Robert Jarzmik
2018-04-02 16:25 ` kbuild test robot
2018-04-02 16:35 ` kbuild test robot
2018-04-03 7:13 ` Arnd Bergmann
2018-04-02 14:26 ` [PATCH 13/15] ARM: pxa: remove the DMA IO resources Robert Jarzmik
2018-04-02 14:26 ` [PATCH 14/15] ARM: pxa: change SSP devices allocation Robert Jarzmik
2018-04-03 7:06 ` Arnd Bergmann
2018-04-03 15:32 ` Robert Jarzmik
2018-04-03 15:53 ` Arnd Bergmann
2018-04-05 6:51 ` Robert Jarzmik
2018-04-05 7:29 ` Arnd Bergmann
2018-04-08 12:16 ` Robert Jarzmik
2018-04-02 14:26 ` [PATCH 15/15] ARM: pxa: change SSP DMA channels allocation Robert Jarzmik
2018-04-02 18:46 ` kbuild test robot
2018-04-03 7:15 ` [PATCH 00/15] ARM: pxa: switch to DMA slave maps Arnd Bergmann
2018-04-03 15:08 ` Ulf Hansson
2018-04-04 19:49 ` Robert Jarzmik
2018-04-04 19:56 ` Boris Brezillon
2018-04-05 6:29 ` Ulf Hansson
2018-04-05 6:50 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh7oxsn8.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).