From: Arnd Bergmann <arnd@arndb.de>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
IDE-ML <linux-ide@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
linux-mtd <linux-mtd@lists.infradead.org>,
devel@driverdev.osuosl.org,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Vinod Koul <vinod.koul@intel.com>,
Richard Weinberger <richard@nod.at>,
Takashi Iwai <tiwai@suse.com>,
Russell King <linux@armlinux.org.uk>,
Marek Vasut <marek.vasut@gmail.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Samuel Ortiz <samuel@sortiz.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
dmaengine@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Nicolas Pitre <nico@fluxnic.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
Tejun Heo <tj@kernel.org>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Daniel Mack <daniel@zonque.org>
Subject: Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation
Date: Tue, 3 Apr 2018 09:06:46 +0200 [thread overview]
Message-ID: <CAK8P3a2hYWO2eweg3zpR7iJoqtH4uxJLAxJAno7L96G7nA2HxQ@mail.gmail.com> (raw)
In-Reply-To: <20180402142656.26815-15-robert.jarzmik@free.fr>
On Mon, Apr 2, 2018 at 4:26 PM, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
>
> +static struct pxa_ssp_info pxa_ssp_infos[] = {
> + { .dma_chan_rx_name = "ssp1_rx", .dma_chan_tx_name = "ssp1_tx", },
> + { .dma_chan_rx_name = "ssp1_rx", .dma_chan_tx_name = "ssp1_tx", },
> + { .dma_chan_rx_name = "ssp2_rx", .dma_chan_tx_name = "ssp2_tx", },
> + { .dma_chan_rx_name = "ssp2_rx", .dma_chan_tx_name = "ssp2_tx", },
> + { .dma_chan_rx_name = "ssp3_rx", .dma_chan_tx_name = "ssp3_tx", },
> + { .dma_chan_rx_name = "ssp3_rx", .dma_chan_tx_name = "ssp3_tx", },
> + { .dma_chan_rx_name = "ssp4_rx", .dma_chan_tx_name = "ssp4_tx", },
> + { .dma_chan_rx_name = "ssp4_rx", .dma_chan_tx_name = "ssp4_tx", },
> +};
This part looks odd to me, you're adding an extra level of indirection to
do two stages of lookups in some form of platform data.
Why can't you just always use "rx" and "tx" as the names here?
(also, I don't see why each line is duplicated, but I'm sure there's
an easy answer for that).
Arnd
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-04-03 7:06 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 14:26 [PATCH 00/15] ARM: pxa: switch to DMA slave maps Robert Jarzmik
2018-04-02 14:26 ` [PATCH 01/15] dmaengine: pxa: use a dma slave map Robert Jarzmik
[not found] ` <87604kz7mu.fsf@belgarion.home>
2018-04-22 6:13 ` Vinod Koul
2018-04-02 14:26 ` [PATCH 02/15] ARM: pxa: add " Robert Jarzmik
2018-04-03 6:51 ` Arnd Bergmann
2018-04-03 15:18 ` Robert Jarzmik
2018-04-03 15:39 ` Arnd Bergmann
2018-04-03 20:19 ` Robert Jarzmik
2018-04-04 10:18 ` Arnd Bergmann
2018-04-04 19:21 ` Robert Jarzmik
2018-04-02 14:26 ` [PATCH 03/15] mmc: pxamci: remove the dmaengine compat need Robert Jarzmik
2018-04-02 14:26 ` [PATCH 04/15] media: pxa_camera: " Robert Jarzmik
2018-04-21 19:27 ` Robert Jarzmik
2018-04-22 11:06 ` Hans Verkuil
2018-04-22 11:06 ` Hans Verkuil
2018-05-04 19:29 ` Mauro Carvalho Chehab
2018-04-02 14:26 ` [PATCH 05/15] mtd: nand: pxa3xx: " Robert Jarzmik
2018-05-18 21:31 ` Daniel Mack
2018-05-23 21:54 ` Daniel Mack
2018-04-02 14:26 ` [PATCH 06/15] net: smc911x: " Robert Jarzmik
2018-04-02 14:26 ` [PATCH 07/15] net: smc91x: " Robert Jarzmik
2018-04-02 14:26 ` [PATCH 08/15] ASoC: pxa: " Robert Jarzmik
2018-04-12 15:26 ` Mark Brown
2018-04-12 16:55 ` Robert Jarzmik
2018-04-02 14:26 ` [PATCH 09/15] net: irda: pxaficp_ir: " Robert Jarzmik
2018-04-21 19:30 ` Robert Jarzmik
2018-04-23 8:37 ` Greg Kroah-Hartman
2018-04-02 14:26 ` [PATCH 10/15] ata: pata_pxa: " Robert Jarzmik
2018-04-21 19:32 ` Robert Jarzmik
2018-04-24 11:04 ` Bartlomiej Zolnierkiewicz
2018-04-02 14:26 ` [PATCH 11/15] dmaengine: pxa: document pxad_param Robert Jarzmik
2018-04-02 14:26 ` [PATCH 12/15] dmaengine: pxa: make the filter function internal Robert Jarzmik
2018-04-02 16:25 ` kbuild test robot
2018-04-02 16:35 ` kbuild test robot
2018-04-03 7:13 ` Arnd Bergmann
2018-04-02 14:26 ` [PATCH 13/15] ARM: pxa: remove the DMA IO resources Robert Jarzmik
2018-04-02 14:26 ` [PATCH 14/15] ARM: pxa: change SSP devices allocation Robert Jarzmik
2018-04-03 7:06 ` Arnd Bergmann [this message]
2018-04-03 15:32 ` Robert Jarzmik
2018-04-03 15:53 ` Arnd Bergmann
2018-04-05 6:51 ` Robert Jarzmik
2018-04-05 7:29 ` Arnd Bergmann
2018-04-08 12:16 ` Robert Jarzmik
2018-04-02 14:26 ` [PATCH 15/15] ARM: pxa: change SSP DMA channels allocation Robert Jarzmik
2018-04-02 18:46 ` kbuild test robot
2018-04-03 7:15 ` [PATCH 00/15] ARM: pxa: switch to DMA slave maps Arnd Bergmann
2018-04-03 15:08 ` Ulf Hansson
2018-04-04 19:49 ` Robert Jarzmik
2018-04-04 19:56 ` Boris Brezillon
2018-04-05 6:29 ` Ulf Hansson
2018-04-05 6:50 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a2hYWO2eweg3zpR7iJoqtH4uxJLAxJAno7L96G7nA2HxQ@mail.gmail.com \
--to=arnd@arndb.de \
--cc=alsa-devel@alsa-project.org \
--cc=b.zolnierkie@samsung.com \
--cc=boris.brezillon@free-electrons.com \
--cc=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=daniel@zonque.org \
--cc=devel@driverdev.osuosl.org \
--cc=dmaengine@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@gmail.com \
--cc=kstewart@linuxfoundation.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=marek.vasut@gmail.com \
--cc=mchehab@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=perex@perex.cz \
--cc=pombredanne@nexb.com \
--cc=richard@nod.at \
--cc=robert.jarzmik@free.fr \
--cc=samuel@sortiz.org \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=tj@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).