linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] usb: remove redundant dependency on USB_SUPPORT
@ 2016-07-22  8:23 Masahiro Yamada
  2016-08-16  7:29 ` Felipe Balbi
  0 siblings, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2016-07-22  8:23 UTC (permalink / raw)
  To: linux-usb
  Cc: Masahiro Yamada, Arnd Bergmann, Felipe Balbi, linux-kernel,
	Greg Kroah-Hartman, Peter Chen

The whole Kconfig entries of the USB subsystem are surrounded with
"if USB_SUPPORT" ... "endif", so CONFIG_USB_SUPPORT=y is surely met
when these two Kconfig options are visible.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/usb/core/Kconfig | 1 -
 drivers/usb/dwc3/Kconfig | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
index dd28010..253aac7 100644
--- a/drivers/usb/core/Kconfig
+++ b/drivers/usb/core/Kconfig
@@ -85,7 +85,6 @@ config USB_OTG_FSM
 
 config USB_ULPI_BUS
 	tristate "USB ULPI PHY interface support"
-	depends on USB_SUPPORT
 	help
 	  UTMI+ Low Pin Interface (ULPI) is specification for a commonly used
 	  USB 2.0 PHY interface. The ULPI specification defines a standard set
diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
index 11864e4..3c6213c 100644
--- a/drivers/usb/dwc3/Kconfig
+++ b/drivers/usb/dwc3/Kconfig
@@ -1,7 +1,7 @@
 config USB_DWC3
 	tristate "DesignWare USB3 DRD Core Support"
 	depends on (USB || USB_GADGET) && HAS_DMA
-	select USB_XHCI_PLATFORM if USB_SUPPORT && USB_XHCI_HCD
+	select USB_XHCI_PLATFORM if USB_XHCI_HCD
 	help
 	  Say Y or M here if your system has a Dual Role SuperSpeed
 	  USB controller based on the DesignWare USB3 IP Core.
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] usb: remove redundant dependency on USB_SUPPORT
  2016-07-22  8:23 [PATCH] usb: remove redundant dependency on USB_SUPPORT Masahiro Yamada
@ 2016-08-16  7:29 ` Felipe Balbi
  2016-08-16  9:25   ` Masahiro Yamada
  0 siblings, 1 reply; 4+ messages in thread
From: Felipe Balbi @ 2016-08-16  7:29 UTC (permalink / raw)
  To: Masahiro Yamada, linux-usb
  Cc: Masahiro Yamada, Arnd Bergmann, linux-kernel, Greg Kroah-Hartman,
	Peter Chen

[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]


Hi,

Masahiro Yamada <yamada.masahiro@socionext.com> writes:
> The whole Kconfig entries of the USB subsystem are surrounded with
> "if USB_SUPPORT" ... "endif", so CONFIG_USB_SUPPORT=y is surely met
> when these two Kconfig options are visible.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  drivers/usb/core/Kconfig | 1 -
>  drivers/usb/dwc3/Kconfig | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
> index dd28010..253aac7 100644
> --- a/drivers/usb/core/Kconfig
> +++ b/drivers/usb/core/Kconfig
> @@ -85,7 +85,6 @@ config USB_OTG_FSM
>  
>  config USB_ULPI_BUS
>  	tristate "USB ULPI PHY interface support"
> -	depends on USB_SUPPORT
>  	help
>  	  UTMI+ Low Pin Interface (ULPI) is specification for a commonly used
>  	  USB 2.0 PHY interface. The ULPI specification defines a standard set
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index 11864e4..3c6213c 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -1,7 +1,7 @@
>  config USB_DWC3
>  	tristate "DesignWare USB3 DRD Core Support"
>  	depends on (USB || USB_GADGET) && HAS_DMA
> -	select USB_XHCI_PLATFORM if USB_SUPPORT && USB_XHCI_HCD
> +	select USB_XHCI_PLATFORM if USB_XHCI_HCD
>  	help
>  	  Say Y or M here if your system has a Dual Role SuperSpeed
>  	  USB controller based on the DesignWare USB3 IP Core.

let's split this patch in two so different maintainers can pick the
relevant pieces. Thanks

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] usb: remove redundant dependency on USB_SUPPORT
  2016-08-16  7:29 ` Felipe Balbi
@ 2016-08-16  9:25   ` Masahiro Yamada
  2016-08-18  7:02     ` Felipe Balbi
  0 siblings, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2016-08-16  9:25 UTC (permalink / raw)
  To: Felipe Balbi
  Cc: linux-usb, Arnd Bergmann, Linux Kernel Mailing List,
	Greg Kroah-Hartman, Peter Chen

2016-08-16 16:29 GMT+09:00 Felipe Balbi <balbi@kernel.org>:
>
> Hi,
>
> Masahiro Yamada <yamada.masahiro@socionext.com> writes:
>> The whole Kconfig entries of the USB subsystem are surrounded with
>> "if USB_SUPPORT" ... "endif", so CONFIG_USB_SUPPORT=y is surely met
>> when these two Kconfig options are visible.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>>  drivers/usb/core/Kconfig | 1 -
>>  drivers/usb/dwc3/Kconfig | 2 +-
>>  2 files changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
>> index dd28010..253aac7 100644
>> --- a/drivers/usb/core/Kconfig
>> +++ b/drivers/usb/core/Kconfig
>> @@ -85,7 +85,6 @@ config USB_OTG_FSM
>>
>>  config USB_ULPI_BUS
>>       tristate "USB ULPI PHY interface support"
>> -     depends on USB_SUPPORT
>>       help
>>         UTMI+ Low Pin Interface (ULPI) is specification for a commonly used
>>         USB 2.0 PHY interface. The ULPI specification defines a standard set
>> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
>> index 11864e4..3c6213c 100644
>> --- a/drivers/usb/dwc3/Kconfig
>> +++ b/drivers/usb/dwc3/Kconfig
>> @@ -1,7 +1,7 @@
>>  config USB_DWC3
>>       tristate "DesignWare USB3 DRD Core Support"
>>       depends on (USB || USB_GADGET) && HAS_DMA
>> -     select USB_XHCI_PLATFORM if USB_SUPPORT && USB_XHCI_HCD
>> +     select USB_XHCI_PLATFORM if USB_XHCI_HCD
>>       help
>>         Say Y or M here if your system has a Dual Role SuperSpeed
>>         USB controller based on the DesignWare USB3 IP Core.
>
> let's split this patch in two so different maintainers can pick the
> relevant pieces. Thanks


Greg picked up this patch already.

I see it in linux-next now.





-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] usb: remove redundant dependency on USB_SUPPORT
  2016-08-16  9:25   ` Masahiro Yamada
@ 2016-08-18  7:02     ` Felipe Balbi
  0 siblings, 0 replies; 4+ messages in thread
From: Felipe Balbi @ 2016-08-18  7:02 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: linux-usb, Arnd Bergmann, Linux Kernel Mailing List,
	Greg Kroah-Hartman, Peter Chen

[-- Attachment #1: Type: text/plain, Size: 1956 bytes --]


Hi,

Masahiro Yamada <yamada.masahiro@socionext.com> writes:
> 2016-08-16 16:29 GMT+09:00 Felipe Balbi <balbi@kernel.org>:
>>
>> Hi,
>>
>> Masahiro Yamada <yamada.masahiro@socionext.com> writes:
>>> The whole Kconfig entries of the USB subsystem are surrounded with
>>> "if USB_SUPPORT" ... "endif", so CONFIG_USB_SUPPORT=y is surely met
>>> when these two Kconfig options are visible.
>>>
>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>> ---
>>>
>>>  drivers/usb/core/Kconfig | 1 -
>>>  drivers/usb/dwc3/Kconfig | 2 +-
>>>  2 files changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
>>> index dd28010..253aac7 100644
>>> --- a/drivers/usb/core/Kconfig
>>> +++ b/drivers/usb/core/Kconfig
>>> @@ -85,7 +85,6 @@ config USB_OTG_FSM
>>>
>>>  config USB_ULPI_BUS
>>>       tristate "USB ULPI PHY interface support"
>>> -     depends on USB_SUPPORT
>>>       help
>>>         UTMI+ Low Pin Interface (ULPI) is specification for a commonly used
>>>         USB 2.0 PHY interface. The ULPI specification defines a standard set
>>> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
>>> index 11864e4..3c6213c 100644
>>> --- a/drivers/usb/dwc3/Kconfig
>>> +++ b/drivers/usb/dwc3/Kconfig
>>> @@ -1,7 +1,7 @@
>>>  config USB_DWC3
>>>       tristate "DesignWare USB3 DRD Core Support"
>>>       depends on (USB || USB_GADGET) && HAS_DMA
>>> -     select USB_XHCI_PLATFORM if USB_SUPPORT && USB_XHCI_HCD
>>> +     select USB_XHCI_PLATFORM if USB_XHCI_HCD
>>>       help
>>>         Say Y or M here if your system has a Dual Role SuperSpeed
>>>         USB controller based on the DesignWare USB3 IP Core.
>>
>> let's split this patch in two so different maintainers can pick the
>> relevant pieces. Thanks
>
>
> Greg picked up this patch already.
>
> I see it in linux-next now.

oh, okay. No problem

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-08-18  7:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-22  8:23 [PATCH] usb: remove redundant dependency on USB_SUPPORT Masahiro Yamada
2016-08-16  7:29 ` Felipe Balbi
2016-08-16  9:25   ` Masahiro Yamada
2016-08-18  7:02     ` Felipe Balbi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).