From: Valentin Schneider <valentin.schneider@arm.com>
To: Peter Zijlstra <peterz@infradead.org>,
Tim Chen <tim.c.chen@linux.intel.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
Barry Song <21cnbao@gmail.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Aubrey Li <aubrey.li@linux.intel.com>,
Borislav Petkov <bp@alien8.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Ben Segall <bsegall@google.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guodong Xu <guodong.xu@linaro.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Juri Lelli <juri.lelli@redhat.com>,
"Cc\: Len Brown" <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
LAK <linux-arm-kernel@lists.infradead.org>,
Linuxarm <linuxarm@huawei.com>,
Mark Rutland <mark.rutland@arm.com>, Mel Gorman <mgorman@suse.de>,
msys.mizuma@gmail.com, "Zengtao \(B\)" <prime.zeng@hisilicon.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Steven Rostedt <rostedt@goodmis.org>,
Barry Song <song.bao.hua@hisilicon.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Will Deacon <will@kernel.org>, x86 <x86@kernel.org>,
yangyicong <yangyicong@huawei.com>
Subject: Re: [PATCH RESEND 0/3] Represent cluster topology and enable load balance between clusters
Date: Tue, 05 Oct 2021 14:42:17 +0100 [thread overview]
Message-ID: <87tuhvlhae.mognet@arm.com> (raw)
In-Reply-To: <20211005075001.GJ4323@worktop.programming.kicks-ass.net>
On 05/10/21 09:50, Peter Zijlstra wrote:
> On Fri, Oct 01, 2021 at 04:22:46PM -0700, Tim Chen wrote:
>> On Fri, 2021-10-01 at 16:57 +0200, Peter Zijlstra wrote:
>
>> > The one questino I have is, do we want default y?
>>
>> I also agree that default y is preferable.
>
> I'll change at least the x86 one to:
>
> default y
> depends on SMP
>
Huh, so the arm64 SCHED_{SMT,MC} configs are defaultless (I added SCHED_SMT
to arm64's defconfig not so long ago), but x86 has them default y, which
I'm thinking is a tad better, and would be nice to harmonize. Unfortunately
different architectures have their own dependency requirements - arm has
ARM_CPU_TOPOLOGY, parisc has PARISC_CPU_TOPOLOGY...
Would you hate making SCHED_* a "generic" config, with a common default and
help text, and punt the arch specific stuff to an ARCH_SUPPORTS_* knob?
Something like:
arch/arm/Kconfig:
select ARCH_SUPPORTS_SCHED_MC if ARM_CPU_TOPOLOGY
init/Kconfig:
config SCHED_MC
def_bool y
depends on ARCH_SUPPORTS_SCHED_MC && SMP
next prev parent reply other threads:[~2021-10-05 13:42 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 8:51 [PATCH RESEND 0/3] Represent cluster topology and enable load balance between clusters Barry Song
2021-09-24 8:51 ` [PATCH RESEND 1/3] topology: Represent clusters of CPUs within a die Barry Song
2021-10-05 16:33 ` Valentin Schneider
2021-10-05 20:43 ` Barry Song
2021-10-06 10:50 ` Barry Song
2021-10-06 12:18 ` Peter Zijlstra
2021-10-06 12:50 ` Barry Song
2021-10-06 13:55 ` Peter Zijlstra
2021-10-07 10:30 ` Barry Song
2021-10-07 10:35 ` Peter Zijlstra
2021-10-06 13:49 ` Valentin Schneider
2021-10-15 9:44 ` [tip: sched/core] " tip-bot2 for Jonathan Cameron
2021-09-24 8:51 ` [PATCH RESEND 2/3] scheduler: Add cluster scheduler level in core and related Kconfig for ARM64 Barry Song
2021-10-05 7:35 ` Peter Zijlstra
2021-10-05 9:01 ` Barry Song
2021-10-05 10:40 ` Peter Zijlstra
2021-09-24 8:51 ` [PATCH RESEND 3/3] scheduler: Add cluster scheduler level for x86 Barry Song
2021-10-15 9:44 ` [tip: sched/core] sched: " tip-bot2 for Tim Chen
2021-10-20 13:12 ` Tom Lendacky
2021-10-20 19:51 ` Peter Zijlstra
2021-10-20 20:08 ` Tom Lendacky
2021-10-20 20:25 ` Peter Zijlstra
2021-10-20 20:36 ` Peter Zijlstra
2021-10-20 20:40 ` Tom Lendacky
2021-10-20 20:40 ` Peter Zijlstra
2021-10-20 20:51 ` Tom Lendacky
2021-10-21 10:32 ` Barry Song
2021-10-21 10:54 ` Barry Song
2021-10-21 13:22 ` Peter Zijlstra
2021-10-21 22:23 ` Song Bao Hua (Barry Song)
2021-10-22 13:31 ` Tom Lendacky
2021-10-22 13:36 ` Peter Zijlstra
2021-10-01 10:32 ` [PATCH RESEND 0/3] Represent cluster topology and enable load balance between clusters Barry Song
2021-10-01 10:39 ` Vincent Guittot
2021-10-01 14:57 ` Peter Zijlstra
2021-10-01 23:22 ` Tim Chen
2021-10-02 7:09 ` Barry Song
2021-10-04 22:54 ` Tim Chen
2021-10-05 7:54 ` Peter Zijlstra
2021-10-05 8:04 ` Peter Zijlstra
2021-10-05 9:06 ` Barry Song
2021-10-05 7:50 ` Peter Zijlstra
2021-10-05 9:15 ` Barry Song
2021-10-05 10:58 ` Peter Zijlstra
2021-10-05 13:42 ` Valentin Schneider [this message]
2021-10-05 13:50 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuhvlhae.mognet@arm.com \
--to=valentin.schneider@arm.com \
--cc=21cnbao@gmail.com \
--cc=aubrey.li@linux.intel.com \
--cc=bp@alien8.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=catalin.marinas@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=guodong.xu@linaro.org \
--cc=hpa@zytor.com \
--cc=jonathan.cameron@huawei.com \
--cc=juri.lelli@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=msys.mizuma@gmail.com \
--cc=peterz@infradead.org \
--cc=prime.zeng@hisilicon.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rostedt@goodmis.org \
--cc=song.bao.hua@hisilicon.com \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=vincent.guittot@linaro.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).