linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] powerpc/vdso32: Add support for CLOCK_{REALTIME/MONOTONIC}_COARSE
       [not found] <1eb059dcb634c48980e5e43f465aabd3d35ba7f7.1565960416.git.christophe.leroy@c-s.fr>
@ 2019-08-16 16:44 ` Segher Boessenkool
  2019-08-19 16:37 ` Nathan Lynch
  1 sibling, 0 replies; 4+ messages in thread
From: Segher Boessenkool @ 2019-08-16 16:44 UTC (permalink / raw)
  To: Christophe Leroy
  Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
	Naveen N. Rao, Santosh Sivaraj, linuxppc-dev, linux-kernel

On Fri, Aug 16, 2019 at 01:01:50PM +0000, Christophe Leroy wrote:
> -	add	r3,r3,r5
> +78:	add	r3,r3,r5

You can use actual names for the labels as well...  .Lsomething if you
want it to stay a local symbol only.


Segher

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] powerpc/vdso32: Add support for CLOCK_{REALTIME/MONOTONIC}_COARSE
       [not found] <1eb059dcb634c48980e5e43f465aabd3d35ba7f7.1565960416.git.christophe.leroy@c-s.fr>
  2019-08-16 16:44 ` [PATCH] powerpc/vdso32: Add support for CLOCK_{REALTIME/MONOTONIC}_COARSE Segher Boessenkool
@ 2019-08-19 16:37 ` Nathan Lynch
  2019-08-19 20:33   ` Christophe Leroy
  1 sibling, 1 reply; 4+ messages in thread
From: Nathan Lynch @ 2019-08-19 16:37 UTC (permalink / raw)
  To: Christophe Leroy, Benjamin Herrenschmidt, Paul Mackerras,
	Michael Ellerman
  Cc: Naveen N. Rao, Santosh Sivaraj, linuxppc-dev, linux-kernel

Hi,

Christophe Leroy <christophe.leroy@c-s.fr> writes:
> Benchmark from vdsotest:

I assume you also ran the verification/correctness parts of vdsotest...? :-)



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] powerpc/vdso32: Add support for CLOCK_{REALTIME/MONOTONIC}_COARSE
  2019-08-19 16:37 ` Nathan Lynch
@ 2019-08-19 20:33   ` Christophe Leroy
  2019-08-19 22:34     ` Nathan Lynch
  0 siblings, 1 reply; 4+ messages in thread
From: Christophe Leroy @ 2019-08-19 20:33 UTC (permalink / raw)
  To: Nathan Lynch, Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman
  Cc: Naveen N. Rao, Santosh Sivaraj, linuxppc-dev, linux-kernel

Hi,

Le 19/08/2019 à 18:37, Nathan Lynch a écrit :
> Hi,
> 
> Christophe Leroy <christophe.leroy@c-s.fr> writes:
>> Benchmark from vdsotest:
> 
> I assume you also ran the verification/correctness parts of vdsotest...? :-)
> 

I did run vdsotest-all. I guess it runs the verifications too ?

Christophe

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] powerpc/vdso32: Add support for CLOCK_{REALTIME/MONOTONIC}_COARSE
  2019-08-19 20:33   ` Christophe Leroy
@ 2019-08-19 22:34     ` Nathan Lynch
  0 siblings, 0 replies; 4+ messages in thread
From: Nathan Lynch @ 2019-08-19 22:34 UTC (permalink / raw)
  To: Christophe Leroy, Benjamin Herrenschmidt, Paul Mackerras,
	Michael Ellerman
  Cc: Naveen N. Rao, linuxppc-dev, Santosh Sivaraj, linux-kernel

Christophe Leroy <christophe.leroy@c-s.fr> writes:

> Hi,
>
> Le 19/08/2019 à 18:37, Nathan Lynch a écrit :
>> Hi,
>> 
>> Christophe Leroy <christophe.leroy@c-s.fr> writes:
>>> Benchmark from vdsotest:
>> 
>> I assume you also ran the verification/correctness parts of vdsotest...? :-)
>> 
>
> I did run vdsotest-all. I guess it runs the verifications too ?

It does, but at a quick glance it runs the validation for "only" 1
second per API. It may provide more confidence to allow the validation
to run across several second (tv_sec) transitions, e.g.

vdsotest -d 30 clock-gettime-monotonic-coarse verify

Regardless, I did not see any problem with your patch.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-08-19 22:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1eb059dcb634c48980e5e43f465aabd3d35ba7f7.1565960416.git.christophe.leroy@c-s.fr>
2019-08-16 16:44 ` [PATCH] powerpc/vdso32: Add support for CLOCK_{REALTIME/MONOTONIC}_COARSE Segher Boessenkool
2019-08-19 16:37 ` Nathan Lynch
2019-08-19 20:33   ` Christophe Leroy
2019-08-19 22:34     ` Nathan Lynch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).