From: ebiederm@xmission.com (Eric W. Biederman) To: Arnd Bergmann <arnd@arndb.de> Cc: christian@brauner.io, Andy Lutomirski <luto@amacapital.net>, Andy Lutomirski <luto@kernel.org>, Florian Weimer <fweimer@redhat.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "Serge E. Hallyn" <serge@hallyn.com>, Jann Horn <jannh@google.com>, Andrew Morton <akpm@linux-foundation.org>, Oleg Nesterov <oleg@redhat.com>, cyphar@cyphar.com, Al Viro <viro@zeniv.linux.org.uk>, Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>, Linux API <linux-api@vger.kernel.org>, Daniel Colascione <dancol@google.com>, Tim Murray <timmurray@google.com>, linux-man@vger.kernel.org, Kees Cook <keescook@chromium.org> Subject: Re: [PATCH v2] signal: add procfd_signal() syscall Date: Sat, 01 Dec 2018 09:28:47 -0600 Message-ID: <87tvjxp8pc.fsf@xmission.com> (raw) In-Reply-To: <87y399s3sc.fsf@xmission.com> (Eric W. Biederman's message of "Sat, 01 Dec 2018 08:46:43 -0600") It just occurs to me that the simple way to implement procfd_sigqueueinfo info is like: int copy_siginfo_from_user_any(kernel_siginfo_t *info, siginfo_t *uinfo) { #ifdef CONFIG_COMPAT if (in_compat_syscall) return copy_siginfo_from_user32(info, uinfo); #endif return copy_siginfo_from_user(info, uinfo); } long procfd_sigqueueinfo(int fd, siginfo_t *uinfo) { kernel_siginfo info; if (copy_siginfo_from_user_any(&info, uinfo)) return -EFAULT; ...; } It looks like there is already a place in ptrace.c that already hand rolls copy_siginfo_from_user_any. So while I would love to figure out the subset of siginfo_t tha we can just pass through, as I think that would make a better more forward compatible copy_siginfo_from_user32. I think for this use case we just add the in_compat_syscall test and then we just need to ensure this new system call is placed in the proper places in the syscall table. Because we will need 3 call sights: x86_64, x32 and ia32. As the layout changes between those three subarchitecuters. Eric
next prev parent reply index Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-20 10:51 Christian Brauner 2018-11-20 10:51 ` [PATCH v2] procfd_signal.2: document procfd_signal syscall Christian Brauner 2018-11-22 8:00 ` [PATCH v2] signal: add procfd_signal() syscall Serge E. Hallyn 2018-11-22 8:23 ` Aleksa Sarai 2018-11-28 14:05 ` Arnd Bergmann 2018-11-29 12:28 ` Florian Weimer 2018-11-29 16:54 ` Andy Lutomirski 2018-11-29 19:16 ` Christian Brauner 2018-11-29 19:22 ` Andy Lutomirski 2018-11-29 19:55 ` Christian Brauner 2018-11-29 20:14 ` Andy Lutomirski 2018-11-29 21:02 ` Arnd Bergmann 2018-11-29 21:35 ` Christian Brauner 2018-11-29 21:40 ` Arnd Bergmann 2018-11-30 2:40 ` Aleksa Sarai 2018-12-01 1:25 ` Christian Brauner 2018-11-30 5:13 ` Eric W. Biederman 2018-11-30 6:56 ` Christian Brauner 2018-11-30 11:41 ` Arnd Bergmann 2018-11-30 16:35 ` Andy Lutomirski 2018-11-30 21:57 ` Christian Brauner 2018-11-30 22:09 ` Arnd Bergmann 2018-11-30 22:26 ` Christian Brauner 2018-11-30 23:05 ` Daniel Colascione 2018-11-30 23:12 ` Arnd Bergmann 2018-11-30 23:15 ` Arnd Bergmann 2018-11-30 23:37 ` Christian Brauner 2018-11-30 23:46 ` Andy Lutomirski 2018-12-01 1:20 ` Christian Brauner 2018-11-30 23:53 ` Andy Lutomirski 2018-12-01 8:51 ` Arnd Bergmann 2018-12-01 9:17 ` Christian Brauner 2018-12-01 10:27 ` Arnd Bergmann 2018-12-01 13:41 ` Eric W. Biederman 2018-12-01 14:46 ` Eric W. Biederman 2018-12-01 15:28 ` Eric W. Biederman [this message] 2018-12-01 15:52 ` Andy Lutomirski 2018-12-01 16:27 ` Christian Brauner 2018-12-02 0:06 ` Eric W. Biederman 2018-12-02 1:14 ` Andy Lutomirski 2018-12-02 8:52 ` Christian Brauner 2018-11-30 23:52 ` Christian Brauner 2018-12-02 10:03 ` Christian Brauner 2018-12-03 16:57 ` Florian Weimer 2018-12-03 18:02 ` Christian Brauner 2018-12-04 6:03 ` Aleksa Sarai 2018-12-04 12:55 ` Florian Weimer 2018-12-04 13:26 ` Christian Brauner 2018-12-06 18:54 ` Andy Lutomirski 2018-12-06 18:56 ` Florian Weimer 2018-12-06 19:03 ` Christian Brauner 2018-12-25 5:32 ` Lai Jiangshan 2018-12-25 7:11 ` Lai Jiangshan 2018-12-25 12:07 ` Aleksa Sarai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87tvjxp8pc.fsf@xmission.com \ --to=ebiederm@xmission.com \ --cc=akpm@linux-foundation.org \ --cc=arnd@arndb.de \ --cc=christian@brauner.io \ --cc=cyphar@cyphar.com \ --cc=dancol@google.com \ --cc=fweimer@redhat.com \ --cc=jannh@google.com \ --cc=keescook@chromium.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-man@vger.kernel.org \ --cc=luto@amacapital.net \ --cc=luto@kernel.org \ --cc=oleg@redhat.com \ --cc=serge@hallyn.com \ --cc=timmurray@google.com \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ linux-kernel@vger.kernel.org public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git