linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next 1/2] drm/i915: Remove duplicated include in intel_sseu.c
@ 2022-05-04 22:48 Yang Li
  2022-05-04 22:48 ` [PATCH -next 2/2] drm/i915/migrate: remove unneeded semicolon Yang Li
  2022-05-05 10:18 ` [PATCH -next 1/2] drm/i915: Remove duplicated include in intel_sseu.c Jani Nikula
  0 siblings, 2 replies; 3+ messages in thread
From: Yang Li @ 2022-05-04 22:48 UTC (permalink / raw)
  To: daniel
  Cc: airlied, tvrtko.ursulin, rodrigo.vivi, joonas.lahtinen,
	jani.nikula, intel-gfx, dri-devel, linux-kernel, Yang Li,
	Abaci Robot

Fix following includecheck warning:
./drivers/gpu/drm/i915/gt/intel_sseu.c: linux/string_helpers.h is
included more than once.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/gpu/drm/i915/gt/intel_sseu.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_sseu.c b/drivers/gpu/drm/i915/gt/intel_sseu.c
index 9881a6790574..fdd25691beda 100644
--- a/drivers/gpu/drm/i915/gt/intel_sseu.c
+++ b/drivers/gpu/drm/i915/gt/intel_sseu.c
@@ -10,8 +10,6 @@
 #include "intel_gt_regs.h"
 #include "intel_sseu.h"
 
-#include "linux/string_helpers.h"
-
 void intel_sseu_set_info(struct sseu_dev_info *sseu, u8 max_slices,
 			 u8 max_subslices, u8 max_eus_per_subslice)
 {
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH -next 2/2] drm/i915/migrate: remove unneeded semicolon
  2022-05-04 22:48 [PATCH -next 1/2] drm/i915: Remove duplicated include in intel_sseu.c Yang Li
@ 2022-05-04 22:48 ` Yang Li
  2022-05-05 10:18 ` [PATCH -next 1/2] drm/i915: Remove duplicated include in intel_sseu.c Jani Nikula
  1 sibling, 0 replies; 3+ messages in thread
From: Yang Li @ 2022-05-04 22:48 UTC (permalink / raw)
  To: daniel
  Cc: airlied, tvrtko.ursulin, rodrigo.vivi, joonas.lahtinen,
	jani.nikula, intel-gfx, dri-devel, linux-kernel, Yang Li,
	Abaci Robot

Eliminate the following coccicheck warning:
./drivers/gpu/drm/i915/gt/intel_migrate.c:643:2-3: Unneeded semicolon

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
index 9d552f30b627..31da0bfe311c 100644
--- a/drivers/gpu/drm/i915/gt/intel_migrate.c
+++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
@@ -640,7 +640,7 @@ static int scatter_list_length(struct scatterlist *sg)
 	while (sg && sg_dma_len(sg)) {
 		len += sg_dma_len(sg);
 		sg = sg_next(sg);
-	};
+	}
 
 	return len;
 }
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH -next 1/2] drm/i915: Remove duplicated include in intel_sseu.c
  2022-05-04 22:48 [PATCH -next 1/2] drm/i915: Remove duplicated include in intel_sseu.c Yang Li
  2022-05-04 22:48 ` [PATCH -next 2/2] drm/i915/migrate: remove unneeded semicolon Yang Li
@ 2022-05-05 10:18 ` Jani Nikula
  1 sibling, 0 replies; 3+ messages in thread
From: Jani Nikula @ 2022-05-05 10:18 UTC (permalink / raw)
  To: Yang Li, daniel
  Cc: airlied, tvrtko.ursulin, rodrigo.vivi, joonas.lahtinen,
	intel-gfx, dri-devel, linux-kernel, Yang Li, Abaci Robot

On Thu, 05 May 2022, Yang Li <yang.lee@linux.alibaba.com> wrote:
> Fix following includecheck warning:
> ./drivers/gpu/drm/i915/gt/intel_sseu.c: linux/string_helpers.h is
> included more than once.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Already fixed by commit 10dcf783f7e9 ("drm/i915: remove superfluous
string helper include").

BR,
Jani.

> ---
>  drivers/gpu/drm/i915/gt/intel_sseu.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_sseu.c b/drivers/gpu/drm/i915/gt/intel_sseu.c
> index 9881a6790574..fdd25691beda 100644
> --- a/drivers/gpu/drm/i915/gt/intel_sseu.c
> +++ b/drivers/gpu/drm/i915/gt/intel_sseu.c
> @@ -10,8 +10,6 @@
>  #include "intel_gt_regs.h"
>  #include "intel_sseu.h"
>  
> -#include "linux/string_helpers.h"
> -
>  void intel_sseu_set_info(struct sseu_dev_info *sseu, u8 max_slices,
>  			 u8 max_subslices, u8 max_eus_per_subslice)
>  {

-- 
Jani Nikula, Intel Open Source Graphics Center

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-05-05 10:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-04 22:48 [PATCH -next 1/2] drm/i915: Remove duplicated include in intel_sseu.c Yang Li
2022-05-04 22:48 ` [PATCH -next 2/2] drm/i915/migrate: remove unneeded semicolon Yang Li
2022-05-05 10:18 ` [PATCH -next 1/2] drm/i915: Remove duplicated include in intel_sseu.c Jani Nikula

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).