linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] docs: ftrace: fix the wrong path of tracefs
@ 2021-11-13 13:37 Zhaoyu Liu
  2021-11-13 14:11 ` Steven Rostedt
  0 siblings, 1 reply; 3+ messages in thread
From: Zhaoyu Liu @ 2021-11-13 13:37 UTC (permalink / raw)
  To: corbet, rostedt, mingo; +Cc: linux-doc, linux-kernel

Delete "tracing" due to it has been included in /proc/mounts.
Delete "echo nop > $tracefs/tracing/current_tracer", maybe
this command is redundant.

Signed-off-by: Zhaoyu Liu <zackary.liu.pro@gmail.com>
---
 Documentation/trace/ftrace.rst | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/Documentation/trace/ftrace.rst b/Documentation/trace/ftrace.rst
index 4e5b26f03d5b..b3166c4a7867 100644
--- a/Documentation/trace/ftrace.rst
+++ b/Documentation/trace/ftrace.rst
@@ -2442,11 +2442,10 @@ Or this simple script!
   #!/bin/bash
 
   tracefs=`sed -ne 's/^tracefs \(.*\) tracefs.*/\1/p' /proc/mounts`
-  echo nop > $tracefs/tracing/current_tracer
-  echo 0 > $tracefs/tracing/tracing_on
-  echo $$ > $tracefs/tracing/set_ftrace_pid
-  echo function > $tracefs/tracing/current_tracer
-  echo 1 > $tracefs/tracing/tracing_on
+  echo 0 > $tracefs/tracing_on
+  echo $$ > $tracefs/set_ftrace_pid
+  echo function > $tracefs/current_tracer
+  echo 1 > $tracefs/tracing_on
   exec "$@"
 
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs: ftrace: fix the wrong path of tracefs
  2021-11-13 13:37 [PATCH] docs: ftrace: fix the wrong path of tracefs Zhaoyu Liu
@ 2021-11-13 14:11 ` Steven Rostedt
  2021-11-15  9:51   ` Jonathan Corbet
  0 siblings, 1 reply; 3+ messages in thread
From: Steven Rostedt @ 2021-11-13 14:11 UTC (permalink / raw)
  To: Zhaoyu Liu; +Cc: corbet, mingo, linux-doc, linux-kernel

On Sat, 13 Nov 2021 21:37:34 +0800
Zhaoyu Liu <zackary.liu.pro@gmail.com> wrote:

> Delete "tracing" due to it has been included in /proc/mounts.
> Delete "echo nop > $tracefs/tracing/current_tracer", maybe
> this command is redundant.
> 
> Signed-off-by: Zhaoyu Liu <zackary.liu.pro@gmail.com>

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Jon,

Can you take this through your tree?

Thanks,

-- Steve


> ---
>  Documentation/trace/ftrace.rst | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/trace/ftrace.rst b/Documentation/trace/ftrace.rst
> index 4e5b26f03d5b..b3166c4a7867 100644
> --- a/Documentation/trace/ftrace.rst
> +++ b/Documentation/trace/ftrace.rst
> @@ -2442,11 +2442,10 @@ Or this simple script!
>    #!/bin/bash
>  
>    tracefs=`sed -ne 's/^tracefs \(.*\) tracefs.*/\1/p' /proc/mounts`
> -  echo nop > $tracefs/tracing/current_tracer
> -  echo 0 > $tracefs/tracing/tracing_on
> -  echo $$ > $tracefs/tracing/set_ftrace_pid
> -  echo function > $tracefs/tracing/current_tracer
> -  echo 1 > $tracefs/tracing/tracing_on
> +  echo 0 > $tracefs/tracing_on
> +  echo $$ > $tracefs/set_ftrace_pid
> +  echo function > $tracefs/current_tracer
> +  echo 1 > $tracefs/tracing_on
>    exec "$@"
>  
>  


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs: ftrace: fix the wrong path of tracefs
  2021-11-13 14:11 ` Steven Rostedt
@ 2021-11-15  9:51   ` Jonathan Corbet
  0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2021-11-15  9:51 UTC (permalink / raw)
  To: Steven Rostedt, Zhaoyu Liu; +Cc: mingo, linux-doc, linux-kernel

Steven Rostedt <rostedt@goodmis.org> writes:

> On Sat, 13 Nov 2021 21:37:34 +0800
> Zhaoyu Liu <zackary.liu.pro@gmail.com> wrote:
>
>> Delete "tracing" due to it has been included in /proc/mounts.
>> Delete "echo nop > $tracefs/tracing/current_tracer", maybe
>> this command is redundant.
>> 
>> Signed-off-by: Zhaoyu Liu <zackary.liu.pro@gmail.com>
>
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> Jon,
>
> Can you take this through your tree?

Applied, thanks.

jon

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-11-15  9:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-13 13:37 [PATCH] docs: ftrace: fix the wrong path of tracefs Zhaoyu Liu
2021-11-13 14:11 ` Steven Rostedt
2021-11-15  9:51   ` Jonathan Corbet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).