linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Russell King <linux+etnaviv@armlinux.org.uk>,
	Christian Gmeiner <christian.gmeiner@gmail.com>,
	etnaviv@lists.freedesktop.org
Subject: Re: [PATCH v2 4/5] drm/etnaviv: Reuse dma_fence_release.
Date: Wed, 03 May 2017 09:03:21 -0700	[thread overview]
Message-ID: <87wp9yylkm.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <1493806760.13947.32.camel@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 694 bytes --]

Lucas Stach <l.stach@pengutronix.de> writes:

> Hi Eric,
>
> Am Mittwoch, den 12.04.2017, 12:12 -0700 schrieb Eric Anholt:
>> If we follow the typical pattern of the base class being the first
>> member, we can use the default dma_fence_free function.
>
> Sorry, I don't like this change.
> While it provides a bit of code simplification, it also bakes the
> implicit assumption into the code that dma_fence is the first struct
> member without any checks to validate this assumption. I would at least
> expect a build bug assert, but then the current bit of code to keep this
> explicit and self-documenting is probably just as good.

Fine with me.  Please make sure you grab patch 2, though.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2017-05-03 16:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-12 19:11 [PATCH v2 0/5] vc4 V3D fencing and msm/etnaviv cleanups Eric Anholt
2017-04-12 19:11 ` [PATCH v2 1/5] drm/msm: Expose our reservation object when exporting a dmabuf Eric Anholt
2017-05-02 10:20   ` Rob Clark
2017-04-12 19:11 ` [PATCH v2 2/5] drm/etnaviv: " Eric Anholt
2017-04-12 19:12 ` [PATCH v2 3/5] drm/msm: Reuse dma_fence_release Eric Anholt
2017-05-02 10:20   ` Rob Clark
2017-04-12 19:12 ` [PATCH v2 4/5] drm/etnaviv: " Eric Anholt
2017-04-13  7:00   ` Daniel Vetter
2017-05-03 10:19   ` Lucas Stach
2017-05-03 16:03     ` Eric Anholt [this message]
2017-04-12 19:12 ` [PATCH v2 5/5] drm/vc4: Expose dma-buf fences for V3D rendering Eric Anholt
2017-04-13  7:13   ` Daniel Vetter
2017-04-13 17:16     ` Eric Anholt
2017-04-13 18:01     ` Eric Anholt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wp9yylkm.fsf@eliezer.anholt.net \
    --to=eric@anholt.net \
    --cc=christian.gmeiner@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=etnaviv@lists.freedesktop.org \
    --cc=l.stach@pengutronix.de \
    --cc=linux+etnaviv@armlinux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).