* spi-bcm2835 depends GPIOLIB
@ 2015-05-03 15:16 Yoshinori Sato
2015-05-04 12:00 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Yoshinori Sato @ 2015-05-03 15:16 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-spi, linux-kernel
I got following error on CONFIG_GPIOLIB=n.
drivers/spi/spi-bcm2835.c: In function 'chip_match_name':
drivers/spi/spi-bcm2835.c:356:21: error: dereferencing pointer to incomplete type 'struct gpio_chip'
return !strcmp(chip->label, data);
^
drivers/spi/spi-bcm2835.c: In function 'bcm2835_spi_setup':
drivers/spi/spi-bcm2835.c:382:9: error: implicit declaration of function 'gpiochip_find' [-Werror=implicit-function-declaration]
chip = gpiochip_find("pinctrl-bcm2835", chip_match_name);
^
drivers/spi/spi-bcm2835.c:382:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
chip = gpiochip_find("pinctrl-bcm2835", chip_match_name);
^
drivers/spi/spi-bcm2835.c: In function 'chip_match_name':
drivers/spi/spi-bcm2835.c:357:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 198f96b..d5ed2a0 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -77,6 +77,7 @@ config SPI_ATMEL
config SPI_BCM2835
tristate "BCM2835 SPI controller"
+ depends on GPIOLIB
depends on ARCH_BCM2835 || COMPILE_TEST
help
This selects a driver for the Broadcom BCM2835 SPI master.
--
Yoshinori Sato
<ysato@users.sourceforge.jp>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: spi-bcm2835 depends GPIOLIB
2015-05-03 15:16 spi-bcm2835 depends GPIOLIB Yoshinori Sato
@ 2015-05-04 12:00 ` Mark Brown
2015-05-07 4:55 ` Yoshinori Sato
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2015-05-04 12:00 UTC (permalink / raw)
To: Yoshinori Sato; +Cc: linux-spi, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 196 bytes --]
On Mon, May 04, 2015 at 12:16:36AM +0900, Yoshinori Sato wrote:
> I got following error on CONFIG_GPIOLIB=n.
Applied, thanks, but please use subject lines reflecting the style for
the subsystem.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: spi-bcm2835 depends GPIOLIB
2015-05-04 12:00 ` Mark Brown
@ 2015-05-07 4:55 ` Yoshinori Sato
0 siblings, 0 replies; 3+ messages in thread
From: Yoshinori Sato @ 2015-05-07 4:55 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-spi, linux-kernel
At Mon, 4 May 2015 13:00:46 +0100,
Mark Brown wrote:
>
> On Mon, May 04, 2015 at 12:16:36AM +0900, Yoshinori Sato wrote:
> > I got following error on CONFIG_GPIOLIB=n.
>
> Applied, thanks, but please use subject lines reflecting the style for
> the subsystem.
Oh. I'm sorry.
Thanks applied.
--
Yoshinori Sato
<ysato@users.sourceforge.jp>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-07 4:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-03 15:16 spi-bcm2835 depends GPIOLIB Yoshinori Sato
2015-05-04 12:00 ` Mark Brown
2015-05-07 4:55 ` Yoshinori Sato
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).