linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [kvalo-ath:pending 37/42] drivers/net/wireless/ath/ath11k/wow.c:467:5: error: redefinition of 'ath11k_wow_init'
@ 2022-02-23  0:52 kernel test robot
  2022-02-24 16:07 ` Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2022-02-23  0:52 UTC (permalink / raw)
  To: Carl Huang
  Cc: kbuild-all, Kalle Valo, ath10k, linux-kernel, Kalle Valo,
	Baochen Qiang, Wen Gong

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending
head:   4136ddcfda28450e2d01173e37300b95c8687d9b
commit: cae84a492cacd9b4eecaafd5dab33f5beba8806e [37/42] ath11k: Add basic WoW functionalities
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20220223/202202230812.uOGgSw5k-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?id=cae84a492cacd9b4eecaafd5dab33f5beba8806e
        git remote add kvalo-ath https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git
        git fetch --no-tags kvalo-ath pending
        git checkout cae84a492cacd9b4eecaafd5dab33f5beba8806e
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/net/wireless/ath/ath11k/wow.c:357:5: warning: no previous prototype for 'ath11k_wow_op_suspend' [-Wmissing-prototypes]
     357 | int ath11k_wow_op_suspend(struct ieee80211_hw *hw,
         |     ^~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/ath11k/wow.c:416:6: warning: no previous prototype for 'ath11k_wow_op_set_wakeup' [-Wmissing-prototypes]
     416 | void ath11k_wow_op_set_wakeup(struct ieee80211_hw *hw, bool enabled)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/ath11k/wow.c:425:5: warning: no previous prototype for 'ath11k_wow_op_resume' [-Wmissing-prototypes]
     425 | int ath11k_wow_op_resume(struct ieee80211_hw *hw)
         |     ^~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/ath/ath11k/wow.c:467:5: error: redefinition of 'ath11k_wow_init'
     467 | int ath11k_wow_init(struct ath11k *ar)
         |     ^~~~~~~~~~~~~~~
   In file included from drivers/net/wireless/ath/ath11k/core.h:26,
                    from drivers/net/wireless/ath/ath11k/wow.c:11:
   drivers/net/wireless/ath/ath11k/wow.h:40:19: note: previous definition of 'ath11k_wow_init' with type 'int(struct ath11k *)'
      40 | static inline int ath11k_wow_init(struct ath11k *ar)
         |                   ^~~~~~~~~~~~~~~
   drivers/net/wireless/ath/ath11k/wow.c: In function 'ath11k_wow_init':
>> drivers/net/wireless/ath/ath11k/wow.c:482:22: error: 'struct wiphy' has no member named 'wowlan'
     482 |         ar->hw->wiphy->wowlan = &ar->wow.wowlan_support;
         |                      ^~


vim +/ath11k_wow_init +467 drivers/net/wireless/ath/ath11k/wow.c

   466	
 > 467	int ath11k_wow_init(struct ath11k *ar)
   468	{
   469		if (WARN_ON(!test_bit(WMI_TLV_SERVICE_WOW, ar->wmi->wmi_ab->svc_map)))
   470			return -EINVAL;
   471	
   472		ar->wow.wowlan_support = ath11k_wowlan_support;
   473	
   474		if (ar->wmi->wmi_ab->wlan_resource_config.rx_decap_mode ==
   475		    ATH11K_HW_TXRX_NATIVE_WIFI) {
   476			ar->wow.wowlan_support.pattern_max_len -= WOW_MAX_REDUCE;
   477			ar->wow.wowlan_support.max_pkt_offset -= WOW_MAX_REDUCE;
   478		}
   479	
   480		ar->wow.max_num_patterns = ATH11K_WOW_PATTERNS;
   481		ar->wow.wowlan_support.n_patterns = ar->wow.max_num_patterns;
 > 482		ar->hw->wiphy->wowlan = &ar->wow.wowlan_support;

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [kvalo-ath:pending 37/42] drivers/net/wireless/ath/ath11k/wow.c:467:5: error: redefinition of 'ath11k_wow_init'
  2022-02-23  0:52 [kvalo-ath:pending 37/42] drivers/net/wireless/ath/ath11k/wow.c:467:5: error: redefinition of 'ath11k_wow_init' kernel test robot
@ 2022-02-24 16:07 ` Kalle Valo
  0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2022-02-24 16:07 UTC (permalink / raw)
  To: kernel test robot
  Cc: Carl Huang, kbuild-all, ath10k, linux-kernel, Baochen Qiang,
	Wen Gong, ath11k

+ ath11k

kernel test robot <lkp@intel.com> writes:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending
> head:   4136ddcfda28450e2d01173e37300b95c8687d9b
> commit: cae84a492cacd9b4eecaafd5dab33f5beba8806e [37/42] ath11k: Add basic WoW functionalities
> config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20220223/202202230812.uOGgSw5k-lkp@intel.com/config)
> compiler: m68k-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?id=cae84a492cacd9b4eecaafd5dab33f5beba8806e
>         git remote add kvalo-ath https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git
>         git fetch --no-tags kvalo-ath pending
>         git checkout cae84a492cacd9b4eecaafd5dab33f5beba8806e
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
>    drivers/net/wireless/ath/ath11k/wow.c:357:5: warning: no previous prototype for 'ath11k_wow_op_suspend' [-Wmissing-prototypes]
>      357 | int ath11k_wow_op_suspend(struct ieee80211_hw *hw,
>          |     ^~~~~~~~~~~~~~~~~~~~~
>    drivers/net/wireless/ath/ath11k/wow.c:416:6: warning: no previous
> prototype for 'ath11k_wow_op_set_wakeup' [-Wmissing-prototypes]
>      416 | void ath11k_wow_op_set_wakeup(struct ieee80211_hw *hw, bool enabled)
>          |      ^~~~~~~~~~~~~~~~~~~~~~~~
>    drivers/net/wireless/ath/ath11k/wow.c:425:5: warning: no previous
> prototype for 'ath11k_wow_op_resume' [-Wmissing-prototypes]
>      425 | int ath11k_wow_op_resume(struct ieee80211_hw *hw)
>          |     ^~~~~~~~~~~~~~~~~~~~
>>> drivers/net/wireless/ath/ath11k/wow.c:467:5: error: redefinition of
>>> 'ath11k_wow_init'
>      467 | int ath11k_wow_init(struct ath11k *ar)
>          |     ^~~~~~~~~~~~~~~
>    In file included from drivers/net/wireless/ath/ath11k/core.h:26,
>                     from drivers/net/wireless/ath/ath11k/wow.c:11:
>    drivers/net/wireless/ath/ath11k/wow.h:40:19: note: previous definition of 'ath11k_wow_init' with type 'int(struct ath11k *)'
>       40 | static inline int ath11k_wow_init(struct ath11k *ar)
>          |                   ^~~~~~~~~~~~~~~
>    drivers/net/wireless/ath/ath11k/wow.c: In function 'ath11k_wow_init':
>>> drivers/net/wireless/ath/ath11k/wow.c:482:22: error: 'struct wiphy'
>>> has no member named 'wowlan'
>      482 |         ar->hw->wiphy->wowlan = &ar->wow.wowlan_support;
>          |                      ^~

I was able to reproduce the errors by disabling CONFIG_PM. I fixed them
and pushed the new patch to the pending branch:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=624c999c214f02004c2f996aa6ce3a17dfbebd18

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-02-24 16:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-23  0:52 [kvalo-ath:pending 37/42] drivers/net/wireless/ath/ath11k/wow.c:467:5: error: redefinition of 'ath11k_wow_init' kernel test robot
2022-02-24 16:07 ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).