From: Baruch Siach <baruch@tkos.co.il>
To: Arnd Bergmann <arnd@arndb.de>
Cc: arm@kernel.org, Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: debug-ll: add default address for digicolor
Date: Wed, 17 Apr 2019 17:18:08 +0300 [thread overview]
Message-ID: <87zhoohg0v.fsf@tarshish> (raw)
In-Reply-To: <20190417125153.2510262-1-arnd@arndb.de>
Hi Arnd,
On Wed, Apr 17 2019, Arnd Bergmann wrote:
> The digicolor platform has three UARTs, but the Kconfig.debug
> file explicitly lists port zero as the one to be used for the
> console, while not providing any default values.
>
> This can get an automated randconfig build stuck in a loop
> waiting for the user to input the number. As we already know
> the physical address, this patch provides that number as
> default, along with a reasonable default value for the virtual
> address.
>
> Cc: Baruch Siach <baruch@tkos.co.il>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: fix physical address
>
> arch/arm/Kconfig.debug | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 6d6e0330930b..12c0d29b75e3 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -1677,6 +1677,7 @@ config DEBUG_UART_PHYS
> default 0xe6ee0000 if DEBUG_RCAR_GEN2_SCIF4
> default 0xe8008000 if DEBUG_R7S72100_SCIF2
> default 0xf0000be0 if ARCH_EBSA110
> + default 0xf0100000 if DEBUG_DIGICOLOR_UA0
Should be 0xf0000000 for the physical address.
> default 0xf1012000 if DEBUG_MVEBU_UART0_ALTERNATE
> default 0xf1012100 if DEBUG_MVEBU_UART1_ALTERNATE
> default 0xf7fc9000 if DEBUG_BERLIN_UART
> @@ -1784,6 +1785,7 @@ config DEBUG_UART_VIRT
> default 0xfd012000 if DEBUG_MVEBU_UART0_ALTERNATE && ARCH_MV78XX0
> default 0xfd883000 if DEBUG_ALPINE_UART0
> default 0xfde12000 if DEBUG_MVEBU_UART0_ALTERNATE && ARCH_DOVE
> + default 0xfe000000 if DEBUG_DIGICOLOR_UA0
Maybe you intended to change the virtual address to 0xf0100000?
> DEFAULT 0xfe012000 if DEBUG_MVEBU_UART0_ALTERNATE && ARCH_ORION5X
> default 0xfe017000 if DEBUG_MMP_UART2
> default 0xfe018000 if DEBUG_MMP_UART3
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2019-04-17 14:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 12:51 [PATCH v2] ARM: debug-ll: add default address for digicolor Arnd Bergmann
2019-04-17 14:18 ` Baruch Siach [this message]
2019-04-17 15:13 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhoohg0v.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).