linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Baruch Siach <baruch@tkos.co.il>
Cc: arm-soc <arm@kernel.org>, Russell King <linux@armlinux.org.uk>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ARM: debug-ll: add default address for digicolor
Date: Wed, 17 Apr 2019 17:13:05 +0200	[thread overview]
Message-ID: <CAK8P3a3U4vOxZCTsND3i=vSYE_kKStX5qW9bnfwZ7i09Y8nCDg@mail.gmail.com> (raw)
In-Reply-To: <87zhoohg0v.fsf@tarshish>

On Wed, Apr 17, 2019 at 4:18 PM Baruch Siach <baruch@tkos.co.il> wrote:
> On Wed, Apr 17 2019, Arnd Bergmann wrote:

> > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> > index 6d6e0330930b..12c0d29b75e3 100644
> > --- a/arch/arm/Kconfig.debug
> > +++ b/arch/arm/Kconfig.debug
> > @@ -1677,6 +1677,7 @@ config DEBUG_UART_PHYS
> >       default 0xe6ee0000 if DEBUG_RCAR_GEN2_SCIF4
> >       default 0xe8008000 if DEBUG_R7S72100_SCIF2
> >       default 0xf0000be0 if ARCH_EBSA110
> > +     default 0xf0100000 if DEBUG_DIGICOLOR_UA0
>
> Should be 0xf0000000 for the physical address.
>
> >       default 0xf1012000 if DEBUG_MVEBU_UART0_ALTERNATE
> >       default 0xf1012100 if DEBUG_MVEBU_UART1_ALTERNATE
> >       default 0xf7fc9000 if DEBUG_BERLIN_UART
> > @@ -1784,6 +1785,7 @@ config DEBUG_UART_VIRT
> >       default 0xfd012000 if DEBUG_MVEBU_UART0_ALTERNATE && ARCH_MV78XX0
> >       default 0xfd883000 if DEBUG_ALPINE_UART0
> >       default 0xfde12000 if DEBUG_MVEBU_UART0_ALTERNATE && ARCH_DOVE
> > +     default 0xfe000000 if DEBUG_DIGICOLOR_UA0
>
> Maybe you intended to change the virtual address to 0xf0100000?

Ouch, sorry for messing it up again. Sending a v3 now.

       Arnd

      reply	other threads:[~2019-04-17 15:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17 12:51 [PATCH v2] ARM: debug-ll: add default address for digicolor Arnd Bergmann
2019-04-17 14:18 ` Baruch Siach
2019-04-17 15:13   ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK8P3a3U4vOxZCTsND3i=vSYE_kKStX5qW9bnfwZ7i09Y8nCDg@mail.gmail.com' \
    --to=arnd@arndb.de \
    --cc=arm@kernel.org \
    --cc=baruch@tkos.co.il \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).