From: Vignesh Raghavendra <vigneshr@ti.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Nishanth Menon <nm@ti.com>
Cc: Apurva Nandan <a-nandan@ti.com>, Tero Kristo <kristo@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-gpio@vger.kernel.org>, Hari Nagalla <hnagalla@ti.com>
Subject: Re: [PATCH 4/4] arch: arm64: ti: Add support for J784s4 EVM board
Date: Wed, 24 Aug 2022 14:45:08 +0530 [thread overview]
Message-ID: <8871faad-5785-62c3-5afa-8c248ac79e9a@ti.com> (raw)
In-Reply-To: <81134eb9-2b7d-05bc-3035-a47f020861a8@linaro.org>
On 24/08/22 12:42, Krzysztof Kozlowski wrote:
> On 24/08/2022 08:33, Vignesh Raghavendra wrote:
>> Hi Krzysztof,
>>
>> On 24/08/22 10:36, Nishanth Menon wrote:
>>> On 13:21-20220823, Krzysztof Kozlowski wrote:
>>>>> +
>>>>> +/ {
>>>>> + compatible = "ti,j784s4-evm", "ti,j784s4";
>>>>> + model = "Texas Instruments J784S4 EVM";
>>>>> +
>>>>> + chosen {
>>>>> + stdout-path = "serial2:115200n8";
>>>>> + bootargs = "console=ttyS2,115200n8 earlycon=ns16550a,mmio32,0x2880000";
>>>>
>>>> earlycon is not a property of hardware. Console is defined in
>>
>> earlycon is helpful for debugging early crashes. How is it any different
>> from "console =" property as described in
>> Documentation/devicetree/usage-model.rst?
>
> choice of console is needed for basic operation and is chosen based on
> current hardware setup. earlycon is purely for debugging and should be
> enabled only when debugging is intended, not on mainline wide-available
> sources.
>
>>
>>>> stdout-path, so please drop entire bootargs.
>>>
>>> We will probably have to cleanup elsewhere as well - point noted.
>>>
>>
>> Whats the alternative to pass default bootargs to kernel if bootloader
>> does not pass bootargs via cmdline? I see quite a few dts file use
>> bootargs = "earlycon" at least
>
> Uboot, your own out-of-tree testing patches? What's the point to have
> earlycon available for every user which does not want to debug?
>
> Sorry, but bootargs are not accepted in DTS. We have several discussions
> around it over time...
Understood, just wanted to make sure what the latest stance is, as I see
lot of files in arm64 dts folder still use bootargs and earlycon. Thanks
for the clarification!
--
Regards
Vignesh
prev parent reply other threads:[~2022-08-24 9:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 19:00 [PATCH 0/4] Add initial support for J784s4 SoC Apurva Nandan
2022-08-19 19:00 ` [PATCH 1/4] dt-bindings: arm: ti: Add bindings " Apurva Nandan
2022-08-22 19:13 ` Rob Herring
2022-08-19 19:00 ` [PATCH 2/4] dt-bindings: pinctrl: k3: Introduce pinmux definitions for J784s4 Apurva Nandan
2022-08-22 19:13 ` Rob Herring
2022-08-26 8:29 ` Linus Walleij
2022-08-26 11:22 ` Vignesh Raghavendra
2022-08-19 19:00 ` [PATCH 3/4] arm64: dts: ti: Add initial support for J784s4 SoC Apurva Nandan
2022-08-23 10:18 ` Krzysztof Kozlowski
2022-08-24 5:02 ` Nishanth Menon
2022-08-24 12:47 ` Krzysztof Kozlowski
2022-08-19 19:00 ` [PATCH 4/4] arch: arm64: ti: Add support for J784s4 EVM board Apurva Nandan
2022-08-23 10:21 ` Krzysztof Kozlowski
2022-08-24 5:06 ` Nishanth Menon
2022-08-24 5:33 ` Vignesh Raghavendra
2022-08-24 7:12 ` Krzysztof Kozlowski
2022-08-24 9:15 ` Vignesh Raghavendra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8871faad-5785-62c3-5afa-8c248ac79e9a@ti.com \
--to=vigneshr@ti.com \
--cc=a-nandan@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hnagalla@ti.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).