From: Vignesh Raghavendra <vigneshr@ti.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Apurva Nandan <a-nandan@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-gpio@vger.kernel.org>, Hari Nagalla <hnagalla@ti.com>
Subject: Re: [PATCH 2/4] dt-bindings: pinctrl: k3: Introduce pinmux definitions for J784s4
Date: Fri, 26 Aug 2022 16:52:28 +0530 [thread overview]
Message-ID: <fd8bdb08-5ed3-8d97-c394-0cab5460df1c@ti.com> (raw)
In-Reply-To: <CACRpkdaktinAJveF_nH9NYYk7mAvnResRzoyuVDVWpwKKq6JOQ@mail.gmail.com>
On 26/08/22 13:59, Linus Walleij wrote:
> On Fri, Aug 19, 2022 at 9:01 PM Apurva Nandan <a-nandan@ti.com> wrote:
>
>> Add pinctrl macros for J784s4 SoC. These macro definitions are
>> similar to that of J721s2, but adding new definitions to avoid
>> any naming confusions in the soc dts files.
>>
>> checkpatch insists the following error exists:
>> ERROR: Macros with complex values should be enclosed in parentheses
>>
>> However, we do not need parentheses enclosing the values for this
>> macro as we do intend it to generate two separate values as has been
>> done for other similar platforms.
>>
>> Signed-off-by: Hari Nagalla <hnagalla@ti.com>
>> Signed-off-by: Apurva Nandan <a-nandan@ti.com>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> I guess you will merge these patches together?
> Tell me if you rather want that I apply this one patch to the pinctrl tree.
>
I will the patch via TI K3 SoC tree once other patches are in good shape.
Thanks for the review!
--
Regards
Vignesh
next prev parent reply other threads:[~2022-08-26 11:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 19:00 [PATCH 0/4] Add initial support for J784s4 SoC Apurva Nandan
2022-08-19 19:00 ` [PATCH 1/4] dt-bindings: arm: ti: Add bindings " Apurva Nandan
2022-08-22 19:13 ` Rob Herring
2022-08-19 19:00 ` [PATCH 2/4] dt-bindings: pinctrl: k3: Introduce pinmux definitions for J784s4 Apurva Nandan
2022-08-22 19:13 ` Rob Herring
2022-08-26 8:29 ` Linus Walleij
2022-08-26 11:22 ` Vignesh Raghavendra [this message]
2022-08-19 19:00 ` [PATCH 3/4] arm64: dts: ti: Add initial support for J784s4 SoC Apurva Nandan
2022-08-23 10:18 ` Krzysztof Kozlowski
2022-08-24 5:02 ` Nishanth Menon
2022-08-24 12:47 ` Krzysztof Kozlowski
2022-08-19 19:00 ` [PATCH 4/4] arch: arm64: ti: Add support for J784s4 EVM board Apurva Nandan
2022-08-23 10:21 ` Krzysztof Kozlowski
2022-08-24 5:06 ` Nishanth Menon
2022-08-24 5:33 ` Vignesh Raghavendra
2022-08-24 7:12 ` Krzysztof Kozlowski
2022-08-24 9:15 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd8bdb08-5ed3-8d97-c394-0cab5460df1c@ti.com \
--to=vigneshr@ti.com \
--cc=a-nandan@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hnagalla@ti.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).