* [PATCH] fix odd_ptr_err.cocci warnings
@ 2019-08-09 10:30 Julia Lawall
2019-08-09 12:31 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2019-08-09 10:30 UTC (permalink / raw)
To: Peter Ujfalusi
Cc: kbuild-all, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, alsa-devel, linux-kernel
From: kbuild test robot <lkp@intel.com>
PTR_ERR should normally access the value just tested by IS_ERR
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
Fixes: 62c9c1442c8f ("j721e new machine driver wip")
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---
tree: https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip
head: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new machine driver wip
:::::: branch date: 20 hours ago
:::::: commit date: 20 hours ago
j721e-evm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/sound/soc/ti/j721e-evm.c
+++ b/sound/soc/ti/j721e-evm.c
@@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf
parent = devm_clk_get(&pdev->dev, clk_name);
kfree(clk_name);
if (IS_ERR(parent)) {
- ret = PTR_ERR(clocks->parent);
+ ret = PTR_ERR(parent);
if (ret != -EPROBE_DEFER)
dev_err(&pdev->dev, "failed to acquire %s': %d\n",
prefix, ret);
@@ -299,7 +299,7 @@ static int j721e_get_clocks(struct platf
parent = devm_clk_get(&pdev->dev, clk_name);
kfree(clk_name);
if (IS_ERR(parent)) {
- ret = PTR_ERR(clocks->parent);
+ ret = PTR_ERR(parent);
if (ret != -EPROBE_DEFER)
dev_err(&pdev->dev, "failed to acquire %s': %d\n",
prefix, ret);
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] fix odd_ptr_err.cocci warnings
2019-08-09 10:30 [PATCH] fix odd_ptr_err.cocci warnings Julia Lawall
@ 2019-08-09 12:31 ` Mark Brown
2019-08-09 13:14 ` Peter Ujfalusi
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2019-08-09 12:31 UTC (permalink / raw)
To: Julia Lawall
Cc: Peter Ujfalusi, kbuild-all, Liam Girdwood, Jaroslav Kysela,
Takashi Iwai, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 631 bytes --]
On Fri, Aug 09, 2019 at 12:30:46PM +0200, Julia Lawall wrote:
> tree: https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip
> head: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
> commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new machine driver wip
> :::::: branch date: 20 hours ago
> :::::: commit date: 20 hours ago
>
> j721e-evm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/sound/soc/ti/j721e-evm.c
> +++ b/sound/soc/ti/j721e-evm.c
> @@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf
This file isn't upstream, it's only in the TI BSP.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fix odd_ptr_err.cocci warnings
2019-08-09 12:31 ` Mark Brown
@ 2019-08-09 13:14 ` Peter Ujfalusi
2019-08-09 13:21 ` Julia Lawall
0 siblings, 1 reply; 6+ messages in thread
From: Peter Ujfalusi @ 2019-08-09 13:14 UTC (permalink / raw)
To: Mark Brown, Julia Lawall
Cc: kbuild-all, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel
On 09/08/2019 15.31, Mark Brown wrote:
> On Fri, Aug 09, 2019 at 12:30:46PM +0200, Julia Lawall wrote:
>
>> tree: https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip
>> head: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
>> commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new machine driver wip
>> :::::: branch date: 20 hours ago
>> :::::: commit date: 20 hours ago
>>
>> j721e-evm.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> --- a/sound/soc/ti/j721e-evm.c
>> +++ b/sound/soc/ti/j721e-evm.c
>> @@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf
>
> This file isn't upstream, it's only in the TI BSP.
Yes, it is not upstream, but the fix is valid.
Julia: is it possible to direct these notifications only to me from
https://github.com/omap-audio/linux-audio.git ?
It mostly carries TI BSP stuff and my various for upstream branches nowdays.
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fix odd_ptr_err.cocci warnings
2019-08-09 13:14 ` Peter Ujfalusi
@ 2019-08-09 13:21 ` Julia Lawall
2019-08-20 8:41 ` [kbuild-all] " Rong Chen
0 siblings, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2019-08-09 13:21 UTC (permalink / raw)
To: Peter Ujfalusi
Cc: Mark Brown, Julia Lawall, kbuild-all, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel
On Fri, 9 Aug 2019, Peter Ujfalusi wrote:
>
>
> On 09/08/2019 15.31, Mark Brown wrote:
> > On Fri, Aug 09, 2019 at 12:30:46PM +0200, Julia Lawall wrote:
> >
> >> tree: https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip
> >> head: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
> >> commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new machine driver wip
> >> :::::: branch date: 20 hours ago
> >> :::::: commit date: 20 hours ago
> >>
> >> j721e-evm.c | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> --- a/sound/soc/ti/j721e-evm.c
> >> +++ b/sound/soc/ti/j721e-evm.c
> >> @@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf
> >
> > This file isn't upstream, it's only in the TI BSP.
>
> Yes, it is not upstream, but the fix is valid.
>
> Julia: is it possible to direct these notifications only to me from
> https://github.com/omap-audio/linux-audio.git ?
>
> It mostly carries TI BSP stuff and my various for upstream branches nowdays.
Please discuss it with the kbuild people. They should be able to set it
up as you want.
You can try lkp@intel.com
julia
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [kbuild-all] [PATCH] fix odd_ptr_err.cocci warnings
2019-08-09 13:21 ` Julia Lawall
@ 2019-08-20 8:41 ` Rong Chen
2019-08-20 10:54 ` Peter Ujfalusi
0 siblings, 1 reply; 6+ messages in thread
From: Rong Chen @ 2019-08-20 8:41 UTC (permalink / raw)
To: Peter Ujfalusi
Cc: Julia Lawall, alsa-devel, Liam Girdwood, linux-kernel,
Takashi Iwai, Jaroslav Kysela, Mark Brown, kbuild-all
Hi Peter,
We have updated to only send the reports to you, please see
https://github.com/intel/lkp-tests/blob/master/repo/linux/omap-audio
Best Regards,
Rong Chen
On 8/9/19 9:21 PM, Julia Lawall wrote:
>
> On Fri, 9 Aug 2019, Peter Ujfalusi wrote:
>
>>
>> On 09/08/2019 15.31, Mark Brown wrote:
>>> On Fri, Aug 09, 2019 at 12:30:46PM +0200, Julia Lawall wrote:
>>>
>>>> tree: https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip
>>>> head: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
>>>> commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new machine driver wip
>>>> :::::: branch date: 20 hours ago
>>>> :::::: commit date: 20 hours ago
>>>>
>>>> j721e-evm.c | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> --- a/sound/soc/ti/j721e-evm.c
>>>> +++ b/sound/soc/ti/j721e-evm.c
>>>> @@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf
>>> This file isn't upstream, it's only in the TI BSP.
>> Yes, it is not upstream, but the fix is valid.
>>
>> Julia: is it possible to direct these notifications only to me from
>> https://github.com/omap-audio/linux-audio.git ?
>>
>> It mostly carries TI BSP stuff and my various for upstream branches nowdays.
> Please discuss it with the kbuild people. They should be able to set it
> up as you want.
>
> You can try lkp@intel.com
>
> julia
> _______________________________________________
> kbuild-all mailing list
> kbuild-all@lists.01.org
> https://lists.01.org/mailman/listinfo/kbuild-all
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [kbuild-all] [PATCH] fix odd_ptr_err.cocci warnings
2019-08-20 8:41 ` [kbuild-all] " Rong Chen
@ 2019-08-20 10:54 ` Peter Ujfalusi
0 siblings, 0 replies; 6+ messages in thread
From: Peter Ujfalusi @ 2019-08-20 10:54 UTC (permalink / raw)
To: Rong Chen
Cc: Julia Lawall, alsa-devel, Liam Girdwood, linux-kernel,
Takashi Iwai, Jaroslav Kysela, Mark Brown, kbuild-all
Hi Chen,
On 20/08/2019 11.41, Rong Chen wrote:
> Hi Peter,
>
> We have updated to only send the reports to you, please see
> https://github.com/intel/lkp-tests/blob/master/repo/linux/omap-audio
Thank you very much!
>
> Best Regards,
> Rong Chen
>
> On 8/9/19 9:21 PM, Julia Lawall wrote:
>>
>> On Fri, 9 Aug 2019, Peter Ujfalusi wrote:
>>
>>>
>>> On 09/08/2019 15.31, Mark Brown wrote:
>>>> On Fri, Aug 09, 2019 at 12:30:46PM +0200, Julia Lawall wrote:
>>>>
>>>>> tree: https://github.com/omap-audio/linux-audio
>>>>> peter/ti-linux-4.19.y/wip
>>>>> head: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
>>>>> commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new
>>>>> machine driver wip
>>>>> :::::: branch date: 20 hours ago
>>>>> :::::: commit date: 20 hours ago
>>>>>
>>>>> j721e-evm.c | 4 ++--
>>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> --- a/sound/soc/ti/j721e-evm.c
>>>>> +++ b/sound/soc/ti/j721e-evm.c
>>>>> @@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf
>>>> This file isn't upstream, it's only in the TI BSP.
>>> Yes, it is not upstream, but the fix is valid.
>>>
>>> Julia: is it possible to direct these notifications only to me from
>>> https://github.com/omap-audio/linux-audio.git ?
>>>
>>> It mostly carries TI BSP stuff and my various for upstream branches
>>> nowdays.
>> Please discuss it with the kbuild people. They should be able to set it
>> up as you want.
>>
>> You can try lkp@intel.com
>>
>> julia
>> _______________________________________________
>> kbuild-all mailing list
>> kbuild-all@lists.01.org
>> https://lists.01.org/mailman/listinfo/kbuild-all
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-08-20 10:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-09 10:30 [PATCH] fix odd_ptr_err.cocci warnings Julia Lawall
2019-08-09 12:31 ` Mark Brown
2019-08-09 13:14 ` Peter Ujfalusi
2019-08-09 13:21 ` Julia Lawall
2019-08-20 8:41 ` [kbuild-all] " Rong Chen
2019-08-20 10:54 ` Peter Ujfalusi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).