* [PATCH] f2fs: avoid format-overflow warning
@ 2023-10-08 6:39 Su Hui
2023-10-08 6:45 ` Chao Yu
0 siblings, 1 reply; 2+ messages in thread
From: Su Hui @ 2023-10-08 6:39 UTC (permalink / raw)
To: jaegeuk, chao; +Cc: Su Hui, linux-f2fs-devel, linux-kernel, kernel-janitors
With gcc and W=1 option, there's a warning like this:
fs/f2fs/compress.c: In function ‘f2fs_init_page_array_cache’:
fs/f2fs/compress.c:1984:47: error: ‘%u’ directive writing between
1 and 7 bytes into a region of size between 5 and 8
[-Werror=format-overflow=]
1984 | sprintf(slab_name, "f2fs_page_array_entry-%u:%u", MAJOR(dev),
MINOR(dev));
| ^~
String "f2fs_page_array_entry-%u:%u" can up to 35. The first "%u" can up
to 4 and the second "%u" can up to 7, so total size is "24 + 4 + 7 = 35".
slab_name's size should be 35 rather than 32.
Signed-off-by: Su Hui <suhui@nfschina.com>
---
fs/f2fs/compress.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index d820801f473e..7514661bbfbb 100644
--- a/fs/f2fs/compress.c
+++ b/fs/f2fs/compress.c
@@ -1976,7 +1976,7 @@ void f2fs_destroy_compress_inode(struct f2fs_sb_info *sbi)
int f2fs_init_page_array_cache(struct f2fs_sb_info *sbi)
{
dev_t dev = sbi->sb->s_bdev->bd_dev;
- char slab_name[32];
+ char slab_name[35];
if (!f2fs_sb_has_compression(sbi))
return 0;
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] f2fs: avoid format-overflow warning
2023-10-08 6:39 [PATCH] f2fs: avoid format-overflow warning Su Hui
@ 2023-10-08 6:45 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2023-10-08 6:45 UTC (permalink / raw)
To: Su Hui, jaegeuk; +Cc: linux-f2fs-devel, linux-kernel, kernel-janitors
On 2023/10/8 14:39, Su Hui wrote:
> With gcc and W=1 option, there's a warning like this:
>
> fs/f2fs/compress.c: In function ‘f2fs_init_page_array_cache’:
> fs/f2fs/compress.c:1984:47: error: ‘%u’ directive writing between
> 1 and 7 bytes into a region of size between 5 and 8
> [-Werror=format-overflow=]
> 1984 | sprintf(slab_name, "f2fs_page_array_entry-%u:%u", MAJOR(dev),
> MINOR(dev));
> | ^~
>
> String "f2fs_page_array_entry-%u:%u" can up to 35. The first "%u" can up
> to 4 and the second "%u" can up to 7, so total size is "24 + 4 + 7 = 35".
> slab_name's size should be 35 rather than 32.
>
> Signed-off-by: Su Hui <suhui@nfschina.com>
Looks good to me, thanks for the patch.
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-08 6:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-08 6:39 [PATCH] f2fs: avoid format-overflow warning Su Hui
2023-10-08 6:45 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).