* linux-next: Signed-off-by missing for commit in the kvm tree
@ 2018-08-06 21:39 Stephen Rothwell
2018-08-06 21:55 ` Paolo Bonzini
2018-08-07 13:09 ` semantic conflict between tip and kvm (was Re: linux-next: Signed-off-by missing for commit in the kvm tree) Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Rothwell @ 2018-08-06 21:39 UTC (permalink / raw)
To: Paolo Bonzini, Radim Krčmář, KVM
Cc: Linux-Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 176 bytes --]
Hi all,
Commit
81781b6884bd ("KVM/x86: Use CC_SET()/CC_OUT in arch/x86/kvm/vmx.c")
is missing a Signed-off-by from its committer.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the kvm tree
2018-08-06 21:39 linux-next: Signed-off-by missing for commit in the kvm tree Stephen Rothwell
@ 2018-08-06 21:55 ` Paolo Bonzini
2018-08-07 13:09 ` semantic conflict between tip and kvm (was Re: linux-next: Signed-off-by missing for commit in the kvm tree) Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2018-08-06 21:55 UTC (permalink / raw)
To: Stephen Rothwell, Radim Krčmář, KVM
Cc: Linux-Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1.1: Type: text/plain, Size: 271 bytes --]
On 06/08/2018 23:39, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 81781b6884bd ("KVM/x86: Use CC_SET()/CC_OUT in arch/x86/kvm/vmx.c")
>
> is missing a Signed-off-by from its committer.
>
Fixed at the same time as resolving the conflicts.
Paolo
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* semantic conflict between tip and kvm (was Re: linux-next: Signed-off-by missing for commit in the kvm tree)
2018-08-06 21:39 linux-next: Signed-off-by missing for commit in the kvm tree Stephen Rothwell
2018-08-06 21:55 ` Paolo Bonzini
@ 2018-08-07 13:09 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2018-08-07 13:09 UTC (permalink / raw)
To: Stephen Rothwell, Radim Krčmář, KVM
Cc: Linux-Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1.1: Type: text/plain, Size: 755 bytes --]
On 06/08/2018 23:39, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 81781b6884bd ("KVM/x86: Use CC_SET()/CC_OUT in arch/x86/kvm/vmx.c")
>
> is missing a Signed-off-by from its committer.
>
Stephen,
there is a semantic conflict between tip and kvm:
const __initconst struct hypervisor_x86 x86_hyper_kvm = {
.name = "KVM",
.detect = kvm_detect,
.type = X86_HYPER_KVM,
.init.init_platform = kvmclock_init,
.init.guest_late_init = kvm_guest_init,
.init.x2apic_available = kvm_para_available,
.init.init_platform = kvm_init_platform,
};
Note that .init.init_platform is initialized twice.
The right fix is to keep the kvm version, and add a kvmclock_init() call
to kvm_init_platform.
Thanks,
Paolo
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-07 13:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-06 21:39 linux-next: Signed-off-by missing for commit in the kvm tree Stephen Rothwell
2018-08-06 21:55 ` Paolo Bonzini
2018-08-07 13:09 ` semantic conflict between tip and kvm (was Re: linux-next: Signed-off-by missing for commit in the kvm tree) Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).