* [PATCH][next] usbip: Fix incorrect double assignment to udc->ud.tcp_rx
@ 2021-03-11 10:44 Colin King
2021-03-11 14:16 ` Shuah Khan
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2021-03-11 10:44 UTC (permalink / raw)
To: Valentina Manea, Shuah Khan, Greg Kroah-Hartman, linux-usb
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently udc->ud.tcp_rx is being assigned twice, the second assignment
is incorrect, it should be to udc->ud.tcp_tx instead of rx. Fix this.
Addresses-Coverity: ("Unused value")
Fixes: 46613c9dfa96 ("usbip: fix vudc usbip_sockfd_store races leading to gpf")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/usb/usbip/vudc_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/usbip/vudc_sysfs.c b/drivers/usb/usbip/vudc_sysfs.c
index a3ec39fc6177..7383a543c6d1 100644
--- a/drivers/usb/usbip/vudc_sysfs.c
+++ b/drivers/usb/usbip/vudc_sysfs.c
@@ -174,7 +174,7 @@ static ssize_t usbip_sockfd_store(struct device *dev,
udc->ud.tcp_socket = socket;
udc->ud.tcp_rx = tcp_rx;
- udc->ud.tcp_rx = tcp_tx;
+ udc->ud.tcp_tx = tcp_tx;
udc->ud.status = SDEV_ST_USED;
spin_unlock_irq(&udc->ud.lock);
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] usbip: Fix incorrect double assignment to udc->ud.tcp_rx
2021-03-11 10:44 [PATCH][next] usbip: Fix incorrect double assignment to udc->ud.tcp_rx Colin King
@ 2021-03-11 14:16 ` Shuah Khan
2021-03-11 18:55 ` Shuah Khan
0 siblings, 1 reply; 3+ messages in thread
From: Shuah Khan @ 2021-03-11 14:16 UTC (permalink / raw)
To: Colin King, Valentina Manea, Shuah Khan, Greg Kroah-Hartman, linux-usb
Cc: kernel-janitors, linux-kernel, Shuah Khan
On 3/11/21 3:44 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently udc->ud.tcp_rx is being assigned twice, the second assignment
> is incorrect, it should be to udc->ud.tcp_tx instead of rx. Fix this.
>
> Addresses-Coverity: ("Unused value")
> Fixes: 46613c9dfa96 ("usbip: fix vudc usbip_sockfd_store races leading to gpf")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/usb/usbip/vudc_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/usbip/vudc_sysfs.c b/drivers/usb/usbip/vudc_sysfs.c
> index a3ec39fc6177..7383a543c6d1 100644
> --- a/drivers/usb/usbip/vudc_sysfs.c
> +++ b/drivers/usb/usbip/vudc_sysfs.c
> @@ -174,7 +174,7 @@ static ssize_t usbip_sockfd_store(struct device *dev,
>
> udc->ud.tcp_socket = socket;
> udc->ud.tcp_rx = tcp_rx;
> - udc->ud.tcp_rx = tcp_tx;
> + udc->ud.tcp_tx = tcp_tx;
> udc->ud.status = SDEV_ST_USED;
>
> spin_unlock_irq(&udc->ud.lock);
>
Thank you for finding and fixing this. This is my bad.
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] usbip: Fix incorrect double assignment to udc->ud.tcp_rx
2021-03-11 14:16 ` Shuah Khan
@ 2021-03-11 18:55 ` Shuah Khan
0 siblings, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2021-03-11 18:55 UTC (permalink / raw)
To: Colin King, Valentina Manea, Shuah Khan, Greg Kroah-Hartman,
linux-usb, Shuah Khan
Cc: kernel-janitors, linux-kernel
On 3/11/21 7:16 AM, Shuah Khan wrote:
> On 3/11/21 3:44 AM, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Currently udc->ud.tcp_rx is being assigned twice, the second assignment
>> is incorrect, it should be to udc->ud.tcp_tx instead of rx. Fix this.
>>
>> Addresses-Coverity: ("Unused value")
>> Fixes: 46613c9dfa96 ("usbip: fix vudc usbip_sockfd_store races leading
>> to gpf")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/usb/usbip/vudc_sysfs.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/usbip/vudc_sysfs.c
>> b/drivers/usb/usbip/vudc_sysfs.c
>> index a3ec39fc6177..7383a543c6d1 100644
>> --- a/drivers/usb/usbip/vudc_sysfs.c
>> +++ b/drivers/usb/usbip/vudc_sysfs.c
>> @@ -174,7 +174,7 @@ static ssize_t usbip_sockfd_store(struct device *dev,
>> udc->ud.tcp_socket = socket;
>> udc->ud.tcp_rx = tcp_rx;
>> - udc->ud.tcp_rx = tcp_tx;
>> + udc->ud.tcp_tx = tcp_tx;
>> udc->ud.status = SDEV_ST_USED;
>> spin_unlock_irq(&udc->ud.lock);
>>
>
> Thank you for finding and fixing this. This is my bad.
>
> Acked-by: Shuah Khan <skhan@linuxfoundation.org>
>
Applies to stables as well since the 46613c9dfa96 is marked for
stables.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-11 18:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-11 10:44 [PATCH][next] usbip: Fix incorrect double assignment to udc->ud.tcp_rx Colin King
2021-03-11 14:16 ` Shuah Khan
2021-03-11 18:55 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).