* [PATCH] leds: an30259a: add a check for devm_regmap_init_i2c
@ 2019-10-16 12:06 Chuhong Yuan
2019-10-16 12:29 ` Dan Murphy
0 siblings, 1 reply; 2+ messages in thread
From: Chuhong Yuan @ 2019-10-16 12:06 UTC (permalink / raw)
Cc: Jacek Anaszewski, Pavel Machek, Dan Murphy, linux-leds,
linux-kernel, Chuhong Yuan
an30259a_probe misses a check for devm_regmap_init_i2c and may cause
problems.
Add a check and print errors like other leds drivers.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/leds/leds-an30259a.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/leds/leds-an30259a.c b/drivers/leds/leds-an30259a.c
index 250dc9d6f635..03ad068f29f7 100644
--- a/drivers/leds/leds-an30259a.c
+++ b/drivers/leds/leds-an30259a.c
@@ -305,6 +305,13 @@ static int an30259a_probe(struct i2c_client *client)
chip->regmap = devm_regmap_init_i2c(client, &an30259a_regmap_config);
+ if (IS_ERR(chip->regmap)) {
+ err = PTR_ERR(chip->regmap);
+ dev_err(&client->dev, "Failed to allocate register map: %d\n",
+ err);
+ return err;
+ }
+
for (i = 0; i < chip->num_leds; i++) {
struct led_init_data init_data = {};
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] leds: an30259a: add a check for devm_regmap_init_i2c
2019-10-16 12:06 [PATCH] leds: an30259a: add a check for devm_regmap_init_i2c Chuhong Yuan
@ 2019-10-16 12:29 ` Dan Murphy
0 siblings, 0 replies; 2+ messages in thread
From: Dan Murphy @ 2019-10-16 12:29 UTC (permalink / raw)
To: Chuhong Yuan; +Cc: Jacek Anaszewski, Pavel Machek, linux-leds, linux-kernel
Chuhong
On 10/16/19 7:06 AM, Chuhong Yuan wrote:
> an30259a_probe misses a check for devm_regmap_init_i2c and may cause
> problems.
> Add a check and print errors like other leds drivers.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
> drivers/leds/leds-an30259a.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/leds/leds-an30259a.c b/drivers/leds/leds-an30259a.c
> index 250dc9d6f635..03ad068f29f7 100644
> --- a/drivers/leds/leds-an30259a.c
> +++ b/drivers/leds/leds-an30259a.c
> @@ -305,6 +305,13 @@ static int an30259a_probe(struct i2c_client *client)
>
> chip->regmap = devm_regmap_init_i2c(client, &an30259a_regmap_config);
>
> + if (IS_ERR(chip->regmap)) {
> + err = PTR_ERR(chip->regmap);
> + dev_err(&client->dev, "Failed to allocate register map: %d\n",
> + err);
> + return err;
This should goto exit as the mutex is created before this allocation on
ln 302
Dan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-16 12:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-16 12:06 [PATCH] leds: an30259a: add a check for devm_regmap_init_i2c Chuhong Yuan
2019-10-16 12:29 ` Dan Murphy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).