From: Joe Perches <joe@perches.com>
To: Peter Collingbourne <pcc@google.com>,
Bjorn Helgaas <helgaas@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Whitcroft <apw@canonical.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Kees Cook <keescook@chromium.org>,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] checkpatch: add warning for non-lore mailing list URLs
Date: Thu, 03 Nov 2022 18:27:35 -0700 [thread overview]
Message-ID: <8a23b1d3ee853cee73385e8144338f399cbe3165.camel@perches.com> (raw)
In-Reply-To: <Y2RlxvPAvzVXtw9t@google.com>
On Thu, 2022-11-03 at 18:07 -0700, Peter Collingbourne wrote:
> On Wed, Oct 19, 2022 at 03:28:43PM -0500, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@google.com>
> >
> > The lkml.org, marc.info, spinics.net, etc archives are not quite as useful
> > as lore.kernel.org because they use different styles, add advertising, and
> > may disappear in the future. The lore archives are more consistent and
> > more likely to stick around, so prefer https://lore.kernel.org URLs when
> > they exist.
>
> If the commit message contains a line like:
>
> Cc: linux-arm-kernel@lists.infradead.org
>
> this patch causes checkpatch.pl to complain. Would it be possible to
> restrict this to URLs?
Yes, I believe this would probably work well enough:
---
scripts/checkpatch.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 7be93c3df2bcb..fe25642d8bacc 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3336,7 +3336,8 @@ sub process {
}
# Check for mailing list archives other than lore.kernel.org
- if ($rawline =~ m{\b$obsolete_archives}) {
+ if ($rawline =~ m{\b$obsolete_archives} &&
+ $rawline !~ /^\s*cc:/i) {
WARN("PREFER_LORE_ARCHIVE",
"Use lore.kernel.org archive links when possible - see https://lore.kernel.org/lists.html\n" . $herecurr);
}
next prev parent reply other threads:[~2022-11-04 1:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 20:28 [PATCH] checkpatch: add warning for non-lore mailing list URLs Bjorn Helgaas
2022-10-19 21:12 ` Joe Perches
2022-11-04 1:07 ` Peter Collingbourne
2022-11-04 1:27 ` Joe Perches [this message]
2022-11-04 1:34 ` Peter Collingbourne
2022-11-04 1:40 ` Joe Perches
2022-11-04 16:49 ` Peter Collingbourne
2022-11-07 20:54 ` Bjorn Helgaas
2022-11-07 21:00 ` Peter Collingbourne
2022-11-14 22:43 ` Bjorn Helgaas
2022-11-14 22:50 ` Peter Collingbourne
-- strict thread matches above, loose matches on Subject: below --
2022-04-01 20:14 Bjorn Helgaas
2022-04-01 20:50 ` Randy Dunlap
2022-04-01 21:26 ` Bjorn Helgaas
2022-04-02 8:00 ` Kalle Valo
2020-12-17 23:56 Bjorn Helgaas
2020-12-18 0:50 ` Joe Perches
2021-02-10 8:22 ` Kees Cook
2021-02-10 17:45 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a23b1d3ee853cee73385e8144338f399cbe3165.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=bhelgaas@google.com \
--cc=dwaipayanray1@gmail.com \
--cc=helgaas@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=pcc@google.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).