From: Peter Collingbourne <pcc@google.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Joe Perches <joe@perches.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@canonical.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Kees Cook <keescook@chromium.org>,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] checkpatch: add warning for non-lore mailing list URLs
Date: Mon, 14 Nov 2022 14:50:16 -0800 [thread overview]
Message-ID: <CAMn1gO4_5TiVB2Z=qi8LrBoQOnnxr1sFiwx8f5qPURtH-CjC2Q@mail.gmail.com> (raw)
In-Reply-To: <20221114224315.GA939630@bhelgaas>
On Mon, Nov 14, 2022 at 2:43 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> On Mon, Nov 07, 2022 at 01:00:59PM -0800, Peter Collingbourne wrote:
> > On Mon, Nov 7, 2022 at 12:54 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
> > >
> > > On Thu, Nov 03, 2022 at 06:34:31PM -0700, Peter Collingbourne wrote:
> > > > On Thu, Nov 3, 2022 at 6:27 PM Joe Perches <joe@perches.com> wrote:
> > > > > On Thu, 2022-11-03 at 18:07 -0700, Peter Collingbourne wrote:
> > > > > > On Wed, Oct 19, 2022 at 03:28:43PM -0500, Bjorn Helgaas wrote:
> > > > > > > From: Bjorn Helgaas <bhelgaas@google.com>
> > > > > > >
> > > > > > > The lkml.org, marc.info, spinics.net, etc archives are not quite as useful
> > > > > > > as lore.kernel.org because they use different styles, add advertising, and
> > > > > > > may disappear in the future. The lore archives are more consistent and
> > > > > > > more likely to stick around, so prefer https://lore.kernel.org URLs when
> > > > > > > they exist.
> > > > > >
> > > > > > If the commit message contains a line like:
> > > > > >
> > > > > > Cc: linux-arm-kernel@lists.infradead.org
> > > > > >
> > > > > > this patch causes checkpatch.pl to complain. Would it be possible to
> > > > > > restrict this to URLs?
> > > > >
> > > > > Yes, I believe this would probably work well enough:
> > > > > ---
> > > > > scripts/checkpatch.pl | 3 ++-
> > > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > > > > index 7be93c3df2bcb..fe25642d8bacc 100755
> > > > > --- a/scripts/checkpatch.pl
> > > > > +++ b/scripts/checkpatch.pl
> > > > > @@ -3336,7 +3336,8 @@ sub process {
> > > > > }
> > > > >
> > > > > # Check for mailing list archives other than lore.kernel.org
> > > > > - if ($rawline =~ m{\b$obsolete_archives}) {
> > > > > + if ($rawline =~ m{\b$obsolete_archives} &&
> > > > > + $rawline !~ /^\s*cc:/i) {
> > > >
> > > > Can we make this (to|cc): instead? Otherwise developers (like me) who
> > > > use custom scripts to add To: headers to their patches before passing
> > > > them to checkpatch.pl will also hit this warning if their patch is
> > > > being sent To: one of these mailing lists.
> > >
> > > Why not make it look for "http" instead of the absence of "cc"?
> >
> > "https" as well, but yes, that would make more sense to me, and would
> > be less likely to require user workarounds.
>
> Maybe like this? (On top of my previous attempt, which is in -next)
>
>
> commit d15f85247948 ("checkpatch: warn only for URLs to non-lore archives")
> Author: Bjorn Helgaas <bhelgaas@google.com>
> Date: Mon Nov 14 16:33:12 2022 -0600
>
> checkpatch: warn only for URLs to non-lore archives
>
> Previously we warned for anything that contained the archive hostname, but
> some email addresses also contain those hostnames, and we'd rather not warn
> about those. Only warn if we see "http" before the archive hostname.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Peter Collingbourne <pcc@google.com>
Peter
next prev parent reply other threads:[~2022-11-14 22:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 20:28 [PATCH] checkpatch: add warning for non-lore mailing list URLs Bjorn Helgaas
2022-10-19 21:12 ` Joe Perches
2022-11-04 1:07 ` Peter Collingbourne
2022-11-04 1:27 ` Joe Perches
2022-11-04 1:34 ` Peter Collingbourne
2022-11-04 1:40 ` Joe Perches
2022-11-04 16:49 ` Peter Collingbourne
2022-11-07 20:54 ` Bjorn Helgaas
2022-11-07 21:00 ` Peter Collingbourne
2022-11-14 22:43 ` Bjorn Helgaas
2022-11-14 22:50 ` Peter Collingbourne [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-04-01 20:14 Bjorn Helgaas
2022-04-01 20:50 ` Randy Dunlap
2022-04-01 21:26 ` Bjorn Helgaas
2022-04-02 8:00 ` Kalle Valo
2020-12-17 23:56 Bjorn Helgaas
2020-12-18 0:50 ` Joe Perches
2021-02-10 8:22 ` Kees Cook
2021-02-10 17:45 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMn1gO4_5TiVB2Z=qi8LrBoQOnnxr1sFiwx8f5qPURtH-CjC2Q@mail.gmail.com' \
--to=pcc@google.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=bhelgaas@google.com \
--cc=dwaipayanray1@gmail.com \
--cc=helgaas@kernel.org \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).