linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH NETFILTER] netfilter: nfnetlink: suspicious RCU usage in ctnetlink_dump_helpinfo
       [not found] <65205a04-f1a3-9901-f6b7-eab8f482f37f@virtuozzo.com>
@ 2021-06-30  9:49 ` Florian Westphal
  2021-06-30 12:09   ` Pablo Neira Ayuso
  0 siblings, 1 reply; 3+ messages in thread
From: Florian Westphal @ 2021-06-30  9:49 UTC (permalink / raw)
  To: Vasily Averin
  Cc: Pablo Neira Ayuso, Jozsef Kadlecsik, Florian Westphal,
	Taehee Yoo, Julian Anastasov, netfilter-devel, coreteam,
	linux-kernel

Vasily Averin <vvs@virtuozzo.com> wrote:
> Two patches listed below removed ctnetlink_dump_helpinfo call from under
> rcu_read_lock. Now its rcu_dereference generates following warning:
> =============================
> WARNING: suspicious RCU usage
> 5.13.0+ #5 Not tainted
> -----------------------------
> net/netfilter/nf_conntrack_netlink.c:221 suspicious rcu_dereference_check() usage!

Reviewed-by: Florian Westphal <fw@strlen.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH NETFILTER] netfilter: nfnetlink: suspicious RCU usage in ctnetlink_dump_helpinfo
  2021-06-30  9:49 ` [PATCH NETFILTER] netfilter: nfnetlink: suspicious RCU usage in ctnetlink_dump_helpinfo Florian Westphal
@ 2021-06-30 12:09   ` Pablo Neira Ayuso
  2021-06-30 12:30     ` Vasily Averin
  0 siblings, 1 reply; 3+ messages in thread
From: Pablo Neira Ayuso @ 2021-06-30 12:09 UTC (permalink / raw)
  To: Vasily Averin
  Cc: Florian Westphal, Jozsef Kadlecsik, Taehee Yoo, Julian Anastasov,
	netfilter-devel, coreteam, linux-kernel


On Wed, Jun 30, 2021 at 11:49:49AM +0200, Florian Westphal wrote:
> Vasily Averin <vvs@virtuozzo.com> wrote:
> > Two patches listed below removed ctnetlink_dump_helpinfo call from under
> > rcu_read_lock. Now its rcu_dereference generates following warning:
> > =============================
> > WARNING: suspicious RCU usage
> > 5.13.0+ #5 Not tainted
> > -----------------------------
> > net/netfilter/nf_conntrack_netlink.c:221 suspicious rcu_dereference_check() usage!
> 
> Reviewed-by: Florian Westphal <fw@strlen.de>

I don't see this patch in netfilter's patchwork nor in
netfilter-devel@vger.kernel.org

Where did they go?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH NETFILTER] netfilter: nfnetlink: suspicious RCU usage in ctnetlink_dump_helpinfo
  2021-06-30 12:09   ` Pablo Neira Ayuso
@ 2021-06-30 12:30     ` Vasily Averin
  0 siblings, 0 replies; 3+ messages in thread
From: Vasily Averin @ 2021-06-30 12:30 UTC (permalink / raw)
  To: Pablo Neira Ayuso
  Cc: Florian Westphal, Jozsef Kadlecsik, Taehee Yoo, Julian Anastasov,
	netfilter-devel, coreteam, linux-kernel

On 6/30/21 3:09 PM, Pablo Neira Ayuso wrote:
> 
> On Wed, Jun 30, 2021 at 11:49:49AM +0200, Florian Westphal wrote:
>> Vasily Averin <vvs@virtuozzo.com> wrote:
>>> Two patches listed below removed ctnetlink_dump_helpinfo call from under
>>> rcu_read_lock. Now its rcu_dereference generates following warning:
>>> =============================
>>> WARNING: suspicious RCU usage
>>> 5.13.0+ #5 Not tainted
>>> -----------------------------
>>> net/netfilter/nf_conntrack_netlink.c:221 suspicious rcu_dereference_check() usage!
>>
>> Reviewed-by: Florian Westphal <fw@strlen.de>
> 
> I don't see this patch in netfilter's patchwork nor in
> netfilter-devel@vger.kernel.org
> 
> Where did they go?

My original letter was graylisted.

"
A message that you sent could not be delivered to one or more of its
recipients. This is a permanent error. The following address(es) failed:

coreteam@netfilter.org
host mail.netfilter.org [217.70.188.207]
SMTP error from remote mail server after RCPT TO:<coreteam@netfilter.org>:
450 4.2.0 <coreteam@netfilter.org>: Recipient address rejected:
Greylisted for 60 seconds: retry timeout exceeded
kadlec@netfilter.org
host mail.netfilter.org [217.70.188.207]
SMTP error from remote mail server after RCPT TO:<kadlec@netfilter.org>:
450 4.2.0 <kadlec@netfilter.org>: Recipient address rejected:
Greylisted for 60 seconds: retry timeout exceeded
pablo@netfilter.org
host mail.netfilter.org [217.70.188.207]
SMTP error from remote mail server after RCPT TO:<pablo@netfilter.org>:
450 4.2.0 <pablo@netfilter.org>: Recipient address rejected:
Greylisted for 60 seconds: retry timeout exceeded
linux-kernel@vger.kernel.org
host vger.kernel.org [23.128.96.18]
SMTP error from remote mail server after RCPT TO:<linux-kernel@vger.kernel.org>:
451 4.7.1 Hello [185.231.240.75], for recipient address <linux-kernel@vger.kernel.org> the policy analysis reported:
Greylisted, see http://postgrey.schweikert.ch/help/vger.kernel.org.html:
retry timeout exceeded
netfilter-devel@vger.kernel.org
host vger.kernel.org [23.128.96.18]
SMTP error from remote mail server after RCPT TO:<netfilter-devel@vger.kernel.org>:
451 4.7.1 Hello [185.231.240.75], for recipient address <netfilter-devel@vger.kernel.org> the policy analysis reported:
Greylisted, see http://postgrey.schweikert.ch/help/vger.kernel.org.html:
retry timeout exceeded
"
I'm expect it will be re-send in few hours.
othrevise I'll resend it once again via another mail server.

Thank you,
	Vasily Averin



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-30 12:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <65205a04-f1a3-9901-f6b7-eab8f482f37f@virtuozzo.com>
2021-06-30  9:49 ` [PATCH NETFILTER] netfilter: nfnetlink: suspicious RCU usage in ctnetlink_dump_helpinfo Florian Westphal
2021-06-30 12:09   ` Pablo Neira Ayuso
2021-06-30 12:30     ` Vasily Averin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).