From: Shawn Lin <shawn.lin@rock-chips.com>
To: Guenter Roeck <linux@roeck-us.net>, Ulf Hansson <ulf.hansson@linaro.org>
Cc: shawn.lin@rock-chips.com, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Anssi Hannula <anssi.hannula@bitwise.fi>,
Douglas Anderson <dianders@chromium.org>,
Brian Norris <briannorris@chromium.org>
Subject: Re: [PATCH] mmc: core: Fix access to HS400-ES devices
Date: Thu, 2 Mar 2017 09:12:52 +0800 [thread overview]
Message-ID: <8b22ae13-f197-4642-53b7-d5fcc63c082f@rock-chips.com> (raw)
In-Reply-To: <1488406307-8952-1-git-send-email-linux@roeck-us.net>
On 2017/3/2 6:11, Guenter Roeck wrote:
> HS400-ES devices fail to initialize with the following error messages.
>
> mmc1: power class selection to bus width 8 ddr 0 failed
> mmc1: error -110 whilst initialising MMC card
>
> This was seen on Samsung Chromebook Plus. Code analysis points to
> commit 3d4ef329757c ("mmc: core: fix multi-bit bus width without
> high-speed mode"), which attempts to set the bus width for all but
> HS200 devices unconditionally. However, for HS400-ES, the bus width
> is already selected.
>
Thanks Guenter for catching this early!
Well, I wasn't cc'ed for that patch and it was queued for just one day
without fully reviewed. And Doug pointed out the key point here, so,
Reviewed-by: Shawn Lin <shawn.lin@rock-chip.com>
btw, I think kernelci need some rk3399 platforms with hs400es
and CQ engine support for future test. I will try to find a way
to help kernelci to get some boards if possible..
> Cc: Anssi Hannula <anssi.hannula@bitwise.fi>
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Brian Norris <briannorris@chromium.org>
> Fixes: 3d4ef329757c ("mmc: core: fix multi-bit bus width ...")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/mmc/core/mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 7fd722868875..b502601df228 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -1730,7 +1730,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
> err = mmc_select_hs400(card);
> if (err)
> goto free_card;
> - } else {
> + } else if (!mmc_card_hs400es(card)) {
> /* Select the desired bus width optionally */
> err = mmc_select_bus_width(card);
> if (err > 0 && mmc_card_hs(card)) {
>
--
Best Regards
Shawn Lin
next prev parent reply other threads:[~2017-03-02 1:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 22:11 [PATCH] mmc: core: Fix access to HS400-ES devices Guenter Roeck
2017-03-01 23:33 ` Doug Anderson
2017-03-02 1:12 ` Shawn Lin [this message]
2017-03-07 3:42 ` Guenter Roeck
2017-03-10 8:46 ` Heiko Stübner
2017-03-14 16:22 ` [PATCH] " Ulf Hansson
2017-07-19 18:12 ` Doug Anderson
2017-07-19 19:32 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b22ae13-f197-4642-53b7-d5fcc63c082f@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=anssi.hannula@bitwise.fi \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).