linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Anssi Hannula <anssi.hannula@bitwise.fi>,
	Brian Norris <briannorris@chromium.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] mmc: core: Fix access to HS400-ES devices
Date: Wed, 19 Jul 2017 11:12:45 -0700	[thread overview]
Message-ID: <CAD=FV=WszhdQ8NY8atSzzhNfbZxjPzU8SthGiiHgQJO=942xAw@mail.gmail.com> (raw)
In-Reply-To: <CAPDyKFq61A0AgO=P0yVCYFDwym=32yVRAJG9rT0tBnyNjXEyaw@mail.gmail.com>

Hi,

On Tue, Mar 14, 2017 at 9:22 AM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> On 1 March 2017 at 23:11, Guenter Roeck <linux@roeck-us.net> wrote:
>> HS400-ES devices fail to initialize with the following error messages.
>>
>> mmc1: power class selection to bus width 8 ddr 0 failed
>> mmc1: error -110 whilst initialising MMC card
>>
>> This was seen on Samsung Chromebook Plus. Code analysis points to
>> commit 3d4ef329757c ("mmc: core: fix multi-bit bus width without
>> high-speed mode"), which attempts to set the bus width for all but
>> HS200 devices unconditionally. However, for HS400-ES, the bus width
>> is already selected.
>>
>> Cc: Anssi Hannula <anssi.hannula@bitwise.fi>
>> Cc: Douglas Anderson <dianders@chromium.org>
>> Cc: Brian Norris <briannorris@chromium.org>
>> Fixes: 3d4ef329757c ("mmc: core: fix multi-bit bus width ...")
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> Sorry for the delay. Been traveling.
>
> Applied for fixes, thanks!

+stable

The commit 3d4ef329757c ("mmc: core: fix multi-bit bus width without
high-speed mode") got backported to many stable branches, so probably
this commit 773dc118756b ("mmc: core: Fix access to HS400-ES devices")
also needs to get picked to the same stable branches.

In the very least v4.9 and v4.4 stable includes the broken patch but
not this fix.

-Doug

  reply	other threads:[~2017-07-19 18:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-01 22:11 [PATCH] mmc: core: Fix access to HS400-ES devices Guenter Roeck
2017-03-01 23:33 ` Doug Anderson
2017-03-02  1:12 ` Shawn Lin
2017-03-07  3:42 ` Guenter Roeck
2017-03-10  8:46 ` Heiko Stübner
2017-03-14 16:22 ` [PATCH] " Ulf Hansson
2017-07-19 18:12   ` Doug Anderson [this message]
2017-07-19 19:32     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=FV=WszhdQ8NY8atSzzhNfbZxjPzU8SthGiiHgQJO=942xAw@mail.gmail.com' \
    --to=dianders@chromium.org \
    --cc=anssi.hannula@bitwise.fi \
    --cc=briannorris@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=stable@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).