* Re: [PATCH] PCI: Use subdir-ccflags-* to inherit debug flag
[not found] <1612438215-33105-1-git-send-email-yangyicong@hisilicon.com>
@ 2021-02-04 16:10 ` Bjorn Helgaas
2021-02-05 1:32 ` Yicong Yang
2021-02-09 21:25 ` Bjorn Helgaas
1 sibling, 1 reply; 5+ messages in thread
From: Bjorn Helgaas @ 2021-02-04 16:10 UTC (permalink / raw)
To: Yicong Yang
Cc: linux-pci, prime.zeng, linuxarm, Masahiro Yamada, Michal Marek,
linux-kbuild, linux-kernel
[+cc Masahiro, Michal, linux-kbuild, linux-kernel]
On Thu, Feb 04, 2021 at 07:30:15PM +0800, Yicong Yang wrote:
> From: Junhao He <hejunhao2@hisilicon.com>
>
> Use subdir-ccflags-* instead of ccflags-* to inherit the debug
> settings from Kconfig when traversing subdirectories.
So I guess the current behavior is:
If CONFIG_PCI_DEBUG=y, add -DDEBUG to CFLAGS in the current
directory, but not in any subdirectories
and the behavior after this patch is:
If CONFIG_PCI_DEBUG=y, add -DDEBUG to CFLAGS in the current
directory and any subdirectories
Is that right? That makes sense to me. I wonder if any other places
have this issue?
'git grep "^ccflags.*-DDEBUG"' finds a few cases where subdirectories
use their own debug config options, e.g.,
drivers/i2c/Makefile:ccflags-$(CONFIG_I2C_DEBUG_CORE) := -DDEBUG
drivers/i2c/algos/Makefile:ccflags-$(CONFIG_I2C_DEBUG_ALGO) := -DDEBUG
drivers/i2c/busses/Makefile:ccflags-$(CONFIG_I2C_DEBUG_BUS) := -DDEBUG
drivers/i2c/muxes/Makefile:ccflags-$(CONFIG_I2C_DEBUG_BUS) := -DDEBUG
But some have subdirectories that look like they probably should be
included by using subdir-ccflags, e.g.,
drivers/base/Makefile:ccflags-$(CONFIG_DEBUG_DRIVER) := -DDEBUG
drivers/base/power/Makefile:ccflags-$(CONFIG_DEBUG_DRIVER) := -DDEBUG
# drivers/base/{firmware_loader,regmap,test}/ not included
drivers/hwmon/Makefile:ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG
# drivers/hwmon/{occ,pmbus}/ not included
drivers/pps/Makefile:ccflags-$(CONFIG_PPS_DEBUG) := -DDEBUG
drivers/pps/clients/Makefile:ccflags-$(CONFIG_PPS_DEBUG) := -DDEBUG
# drivers/pps/generators/ not included
There are many more places that add -DDEBUG to ccflags-y that *don't*
have subdirectories.
I wonder the default should be that we use subdir-ccflags all the
time, and use ccflags only when we actually want different
CONFIG_*_DEBUG options for subdirectories.
> Signed-off-by: Junhao He <hejunhao2@hisilicon.com>
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
> ---
> drivers/pci/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/Makefile b/drivers/pci/Makefile
> index 11cc794..d62c4ac 100644
> --- a/drivers/pci/Makefile
> +++ b/drivers/pci/Makefile
> @@ -36,4 +36,4 @@ obj-$(CONFIG_PCI_ENDPOINT) += endpoint/
> obj-y += controller/
> obj-y += switch/
>
> -ccflags-$(CONFIG_PCI_DEBUG) := -DDEBUG
> +subdir-ccflags-$(CONFIG_PCI_DEBUG) := -DDEBUG
> --
> 2.8.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PCI: Use subdir-ccflags-* to inherit debug flag
2021-02-04 16:10 ` [PATCH] PCI: Use subdir-ccflags-* to inherit debug flag Bjorn Helgaas
@ 2021-02-05 1:32 ` Yicong Yang
0 siblings, 0 replies; 5+ messages in thread
From: Yicong Yang @ 2021-02-05 1:32 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: linux-pci, prime.zeng, linuxarm, Masahiro Yamada, Michal Marek,
linux-kbuild, linux-kernel
On 2021/2/5 0:10, Bjorn Helgaas wrote:
> [+cc Masahiro, Michal, linux-kbuild, linux-kernel]
>
> On Thu, Feb 04, 2021 at 07:30:15PM +0800, Yicong Yang wrote:
>> From: Junhao He <hejunhao2@hisilicon.com>
>>
>> Use subdir-ccflags-* instead of ccflags-* to inherit the debug
>> settings from Kconfig when traversing subdirectories.
>
> So I guess the current behavior is:
>
> If CONFIG_PCI_DEBUG=y, add -DDEBUG to CFLAGS in the current
> directory, but not in any subdirectories
>
> and the behavior after this patch is:
>
> If CONFIG_PCI_DEBUG=y, add -DDEBUG to CFLAGS in the current
> directory and any subdirectories
>
> Is that right? That makes sense to me. I wonder if any other places
> have this issue?
that's right. we didn't check other places, but some have individual config
in their sub-directory as you mentioned below.
>
> 'git grep "^ccflags.*-DDEBUG"' finds a few cases where subdirectories
> use their own debug config options, e.g.,
>
> drivers/i2c/Makefile:ccflags-$(CONFIG_I2C_DEBUG_CORE) := -DDEBUG
> drivers/i2c/algos/Makefile:ccflags-$(CONFIG_I2C_DEBUG_ALGO) := -DDEBUG
> drivers/i2c/busses/Makefile:ccflags-$(CONFIG_I2C_DEBUG_BUS) := -DDEBUG
> drivers/i2c/muxes/Makefile:ccflags-$(CONFIG_I2C_DEBUG_BUS) := -DDEBUG
>
> But some have subdirectories that look like they probably should be
> included by using subdir-ccflags, e.g.,
>
> drivers/base/Makefile:ccflags-$(CONFIG_DEBUG_DRIVER) := -DDEBUG
> drivers/base/power/Makefile:ccflags-$(CONFIG_DEBUG_DRIVER) := -DDEBUG
> # drivers/base/{firmware_loader,regmap,test}/ not included
>
> drivers/hwmon/Makefile:ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG
> # drivers/hwmon/{occ,pmbus}/ not included
>
> drivers/pps/Makefile:ccflags-$(CONFIG_PPS_DEBUG) := -DDEBUG
> drivers/pps/clients/Makefile:ccflags-$(CONFIG_PPS_DEBUG) := -DDEBUG
> # drivers/pps/generators/ not included
>
> There are many more places that add -DDEBUG to ccflags-y that *don't*
> have subdirectories.
>
> I wonder the default should be that we use subdir-ccflags all the
> time, and use ccflags only when we actually want different
> CONFIG_*_DEBUG options for subdirectories.
agree. if there is no debug config in the sub-directory, the
config should be inherited from its parent directory using subdir-ccflags.
we can post a separate serial to issue other places.
Thanks,
Yicong
>
>> Signed-off-by: Junhao He <hejunhao2@hisilicon.com>
>> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
>> ---
>> drivers/pci/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/Makefile b/drivers/pci/Makefile
>> index 11cc794..d62c4ac 100644
>> --- a/drivers/pci/Makefile
>> +++ b/drivers/pci/Makefile
>> @@ -36,4 +36,4 @@ obj-$(CONFIG_PCI_ENDPOINT) += endpoint/
>> obj-y += controller/
>> obj-y += switch/
>>
>> -ccflags-$(CONFIG_PCI_DEBUG) := -DDEBUG
>> +subdir-ccflags-$(CONFIG_PCI_DEBUG) := -DDEBUG
>> --
>> 2.8.1
>>
>
> .
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PCI: Use subdir-ccflags-* to inherit debug flag
[not found] <1612438215-33105-1-git-send-email-yangyicong@hisilicon.com>
2021-02-04 16:10 ` [PATCH] PCI: Use subdir-ccflags-* to inherit debug flag Bjorn Helgaas
@ 2021-02-09 21:25 ` Bjorn Helgaas
2021-02-09 23:43 ` Krzysztof Wilczyński
2021-02-10 9:33 ` Yicong Yang
1 sibling, 2 replies; 5+ messages in thread
From: Bjorn Helgaas @ 2021-02-09 21:25 UTC (permalink / raw)
To: Yicong Yang
Cc: linux-pci, prime.zeng, linuxarm, Masahiro Yamada, Michal Marek,
linux-kbuild, linux-kernel
[+cc Masahiro, Michal, linux-kbuild, linux-kernel]
On Thu, Feb 04, 2021 at 07:30:15PM +0800, Yicong Yang wrote:
> From: Junhao He <hejunhao2@hisilicon.com>
>
> Use subdir-ccflags-* instead of ccflags-* to inherit the debug
> settings from Kconfig when traversing subdirectories.
>
> Signed-off-by: Junhao He <hejunhao2@hisilicon.com>
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
I applied this with Krzysztof's reviewed-by and the commit log below
to pci/misc for v5.12, thanks!
Feel free to copy or improve the commit log for use elsewhere.
> ---
> drivers/pci/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/Makefile b/drivers/pci/Makefile
> index 11cc794..d62c4ac 100644
> --- a/drivers/pci/Makefile
> +++ b/drivers/pci/Makefile
> @@ -36,4 +36,4 @@ obj-$(CONFIG_PCI_ENDPOINT) += endpoint/
> obj-y += controller/
> obj-y += switch/
>
> -ccflags-$(CONFIG_PCI_DEBUG) := -DDEBUG
> +subdir-ccflags-$(CONFIG_PCI_DEBUG) := -DDEBUG
commit e8e9aababe60 ("PCI: Apply CONFIG_PCI_DEBUG to entire drivers/pci hierarchy")
Author: Junhao He <hejunhao2@hisilicon.com>
Date: Thu Feb 4 19:30:15 2021 +0800
PCI: Apply CONFIG_PCI_DEBUG to entire drivers/pci hierarchy
CONFIG_PCI_DEBUG=y adds -DDEBUG to CFLAGS, which enables things like
pr_debug() and dev_dbg() (and hence pci_dbg()). Previously we added
-DDEBUG for files in drivers/pci/, but not files in subdirectories of
drivers/pci/.
Add -DDEBUG to CFLAGS for all files below drivers/pci/ so CONFIG_PCI_DEBUG
applies to the entire hierarchy.
[bhelgaas: commit log]
Link: https://lore.kernel.org/r/1612438215-33105-1-git-send-email-yangyicong@hisilicon.com
Signed-off-by: Junhao He <hejunhao2@hisilicon.com>
Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
diff --git a/drivers/pci/Makefile b/drivers/pci/Makefile
index 11cc79411e2d..d62c4ac4ae1b 100644
--- a/drivers/pci/Makefile
+++ b/drivers/pci/Makefile
@@ -36,4 +36,4 @@ obj-$(CONFIG_PCI_ENDPOINT) += endpoint/
obj-y += controller/
obj-y += switch/
-ccflags-$(CONFIG_PCI_DEBUG) := -DDEBUG
+subdir-ccflags-$(CONFIG_PCI_DEBUG) := -DDEBUG
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] PCI: Use subdir-ccflags-* to inherit debug flag
2021-02-09 21:25 ` Bjorn Helgaas
@ 2021-02-09 23:43 ` Krzysztof Wilczyński
2021-02-10 9:33 ` Yicong Yang
1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Wilczyński @ 2021-02-09 23:43 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Yicong Yang, linux-pci, prime.zeng, linuxarm, Masahiro Yamada,
Michal Marek, linux-kbuild, linux-kernel
Hi Bjorn,
Thank you! This looks great!
[...]
> commit e8e9aababe60 ("PCI: Apply CONFIG_PCI_DEBUG to entire drivers/pci hierarchy")
> Author: Junhao He <hejunhao2@hisilicon.com>
> Date: Thu Feb 4 19:30:15 2021 +0800
>
> PCI: Apply CONFIG_PCI_DEBUG to entire drivers/pci hierarchy
>
> CONFIG_PCI_DEBUG=y adds -DDEBUG to CFLAGS, which enables things like
> pr_debug() and dev_dbg() (and hence pci_dbg()). Previously we added
> -DDEBUG for files in drivers/pci/, but not files in subdirectories of
> drivers/pci/.
>
> Add -DDEBUG to CFLAGS for all files below drivers/pci/ so CONFIG_PCI_DEBUG
> applies to the entire hierarchy.
>
> [bhelgaas: commit log]
> Link: https://lore.kernel.org/r/1612438215-33105-1-git-send-email-yangyicong@hisilicon.com
> Signed-off-by: Junhao He <hejunhao2@hisilicon.com>
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
>
> diff --git a/drivers/pci/Makefile b/drivers/pci/Makefile
> index 11cc79411e2d..d62c4ac4ae1b 100644
> --- a/drivers/pci/Makefile
> +++ b/drivers/pci/Makefile
> @@ -36,4 +36,4 @@ obj-$(CONFIG_PCI_ENDPOINT) += endpoint/
> obj-y += controller/
> obj-y += switch/
>
> -ccflags-$(CONFIG_PCI_DEBUG) := -DDEBUG
> +subdir-ccflags-$(CONFIG_PCI_DEBUG) := -DDEBUG
And thank you again, Yicong, for fixing this. Much appreciated.
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PCI: Use subdir-ccflags-* to inherit debug flag
2021-02-09 21:25 ` Bjorn Helgaas
2021-02-09 23:43 ` Krzysztof Wilczyński
@ 2021-02-10 9:33 ` Yicong Yang
1 sibling, 0 replies; 5+ messages in thread
From: Yicong Yang @ 2021-02-10 9:33 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: linux-pci, prime.zeng, linuxarm, Masahiro Yamada, Michal Marek,
linux-kbuild, linux-kernel
On 2021/2/10 5:25, Bjorn Helgaas wrote:
> [+cc Masahiro, Michal, linux-kbuild, linux-kernel]
>
> On Thu, Feb 04, 2021 at 07:30:15PM +0800, Yicong Yang wrote:
>> From: Junhao He <hejunhao2@hisilicon.com>
>>
>> Use subdir-ccflags-* instead of ccflags-* to inherit the debug
>> settings from Kconfig when traversing subdirectories.
>>
>> Signed-off-by: Junhao He <hejunhao2@hisilicon.com>
>> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
>
> I applied this with Krzysztof's reviewed-by and the commit log below
> to pci/misc for v5.12, thanks!
>
> Feel free to copy or improve the commit log for use elsewhere.
>
thanks for improving the commit. i admit that i didn't make the it
clear enough. it's much better now.
Thanks,
Yicong
>> ---
>> drivers/pci/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/Makefile b/drivers/pci/Makefile
>> index 11cc794..d62c4ac 100644
>> --- a/drivers/pci/Makefile
>> +++ b/drivers/pci/Makefile
>> @@ -36,4 +36,4 @@ obj-$(CONFIG_PCI_ENDPOINT) += endpoint/
>> obj-y += controller/
>> obj-y += switch/
>>
>> -ccflags-$(CONFIG_PCI_DEBUG) := -DDEBUG
>> +subdir-ccflags-$(CONFIG_PCI_DEBUG) := -DDEBUG
>
> commit e8e9aababe60 ("PCI: Apply CONFIG_PCI_DEBUG to entire drivers/pci hierarchy")
> Author: Junhao He <hejunhao2@hisilicon.com>
> Date: Thu Feb 4 19:30:15 2021 +0800
>
> PCI: Apply CONFIG_PCI_DEBUG to entire drivers/pci hierarchy
>
> CONFIG_PCI_DEBUG=y adds -DDEBUG to CFLAGS, which enables things like
> pr_debug() and dev_dbg() (and hence pci_dbg()). Previously we added
> -DDEBUG for files in drivers/pci/, but not files in subdirectories of
> drivers/pci/.
>
> Add -DDEBUG to CFLAGS for all files below drivers/pci/ so CONFIG_PCI_DEBUG
> applies to the entire hierarchy.
>
> [bhelgaas: commit log]
> Link: https://lore.kernel.org/r/1612438215-33105-1-git-send-email-yangyicong@hisilicon.com
> Signed-off-by: Junhao He <hejunhao2@hisilicon.com>
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
>
> diff --git a/drivers/pci/Makefile b/drivers/pci/Makefile
> index 11cc79411e2d..d62c4ac4ae1b 100644
> --- a/drivers/pci/Makefile
> +++ b/drivers/pci/Makefile
> @@ -36,4 +36,4 @@ obj-$(CONFIG_PCI_ENDPOINT) += endpoint/
> obj-y += controller/
> obj-y += switch/
>
> -ccflags-$(CONFIG_PCI_DEBUG) := -DDEBUG
> +subdir-ccflags-$(CONFIG_PCI_DEBUG) := -DDEBUG
>
> .
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-02-10 9:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1612438215-33105-1-git-send-email-yangyicong@hisilicon.com>
2021-02-04 16:10 ` [PATCH] PCI: Use subdir-ccflags-* to inherit debug flag Bjorn Helgaas
2021-02-05 1:32 ` Yicong Yang
2021-02-09 21:25 ` Bjorn Helgaas
2021-02-09 23:43 ` Krzysztof Wilczyński
2021-02-10 9:33 ` Yicong Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).