* [PATCH v2 1/1] x86/tsr: Fix tsc frequency enumeration failure on Lightning Mountain SoC
@ 2020-07-30 10:01 Dilip Kota
2020-07-31 8:44 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Dilip Kota @ 2020-07-30 10:01 UTC (permalink / raw)
To: x86, tglx, mingo, bp, hpa, rahul.tanwar
Cc: hdegoede, linux-kernel, andy, cheol.yong.kim, chuanhua.lei,
qi-ming.wu, Dilip Kota
Frequency descriptor of Lightning Mountain SoC doesn't have all the
frequency entries so resulting in the below failure causing kernel hang.
[ 0.000000] Error MSR_FSB_FREQ index 15 is unknown
[ 0.000000] tsc: Fast TSC calibration failed
So, add all the frequency entries in the Lightning Mountain SoC frequency
descriptor.
Fixes: 0cc5359d8fd45 ("x86/cpu: Update init data for new Airmont CPU model")
Fixes: 812c2d7506fd ("x86/tsc_msr: Use named struct initializers")
Signed-off-by: Dilip Kota <eswara.kota@linux.intel.com>
---
Changes on v2:
Add description in the comments explaining about frequency entries.
arch/x86/kernel/tsc_msr.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/tsc_msr.c b/arch/x86/kernel/tsc_msr.c
index 4fec6f3a1858b2..83b54c65aad2f3 100644
--- a/arch/x86/kernel/tsc_msr.c
+++ b/arch/x86/kernel/tsc_msr.c
@@ -133,10 +133,15 @@ static const struct freq_desc freq_desc_ann = {
.mask = 0x0f,
};
-/* 24 MHz crystal? : 24 * 13 / 4 = 78 MHz */
+/*
+ * 24 MHz crystal? : 24 * 13 / 4 = 78 MHz
+ * Frequency step for Lightning Mountain SoC is fixed to 78 MHz,
+ * so all the frequency entries are 78000.
+ */
static const struct freq_desc freq_desc_lgm = {
.use_msr_plat = true,
- .freqs = { 78000, 78000, 78000, 78000, 78000, 78000, 78000, 78000 },
+ .freqs = { 78000, 78000, 78000, 78000, 78000, 78000, 78000, 78000, 78000,
+ 78000, 78000, 78000, 78000, 78000, 78000, 78000 },
.mask = 0x0f,
};
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/1] x86/tsr: Fix tsc frequency enumeration failure on Lightning Mountain SoC
2020-07-30 10:01 [PATCH v2 1/1] x86/tsr: Fix tsc frequency enumeration failure on Lightning Mountain SoC Dilip Kota
@ 2020-07-31 8:44 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2020-07-31 8:44 UTC (permalink / raw)
To: Dilip Kota
Cc: maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
Thomas Gleixner, Ingo Molnar, Borislav Petkov, H. Peter Anvin,
Tanwar, Rahul, Hans de Goede, Linux Kernel Mailing List,
Andy Shevchenko, cheol.yong.kim, chuanhua.lei, qi-ming.wu
On Thu, Jul 30, 2020 at 1:01 PM Dilip Kota <eswara.kota@linux.intel.com> wrote:
>
> Frequency descriptor of Lightning Mountain SoC doesn't have all the
> frequency entries so resulting in the below failure causing kernel hang.
>
> [ 0.000000] Error MSR_FSB_FREQ index 15 is unknown
> [ 0.000000] tsc: Fast TSC calibration failed
>
> So, add all the frequency entries in the Lightning Mountain SoC frequency
> descriptor.
>
I'm wondering if you get Tony's blessing for this change...
In any case, one nit-pick below and Cc Tony for the next version.
FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Fixes: 0cc5359d8fd45 ("x86/cpu: Update init data for new Airmont CPU model")
> Fixes: 812c2d7506fd ("x86/tsc_msr: Use named struct initializers")
> Signed-off-by: Dilip Kota <eswara.kota@linux.intel.com>
> ---
> Changes on v2:
> Add description in the comments explaining about frequency entries.
>
> arch/x86/kernel/tsc_msr.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/tsc_msr.c b/arch/x86/kernel/tsc_msr.c
> index 4fec6f3a1858b2..83b54c65aad2f3 100644
> --- a/arch/x86/kernel/tsc_msr.c
> +++ b/arch/x86/kernel/tsc_msr.c
> @@ -133,10 +133,15 @@ static const struct freq_desc freq_desc_ann = {
> .mask = 0x0f,
> };
>
> -/* 24 MHz crystal? : 24 * 13 / 4 = 78 MHz */
> +/*
> + * 24 MHz crystal? : 24 * 13 / 4 = 78 MHz
> + * Frequency step for Lightning Mountain SoC is fixed to 78 MHz,
> + * so all the frequency entries are 78000.
> + */
> static const struct freq_desc freq_desc_lgm = {
> .use_msr_plat = true,
> - .freqs = { 78000, 78000, 78000, 78000, 78000, 78000, 78000, 78000 },
> + .freqs = { 78000, 78000, 78000, 78000, 78000, 78000, 78000, 78000, 78000,
> + 78000, 78000, 78000, 78000, 78000, 78000, 78000 },
Keep 8 per line (or 4 per line).
> .mask = 0x0f,
> };
>
> --
> 2.11.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-31 8:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-30 10:01 [PATCH v2 1/1] x86/tsr: Fix tsc frequency enumeration failure on Lightning Mountain SoC Dilip Kota
2020-07-31 8:44 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).