From: Marek Vasut <marek.vasut@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Mark Brown <broonie@kernel.org>,
Steve Twiss <stwiss.opensource@diasemi.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3 01/10] mfd: da9063: Fix failpath in core
Date: Mon, 4 Jun 2018 15:08:20 +0200 [thread overview]
Message-ID: <8b76fcb6-87fc-36da-63af-4b77a09e6e59@gmail.com> (raw)
In-Reply-To: <20180604122410.GA21163@dell>
On 06/04/2018 02:24 PM, Lee Jones wrote:
> On Sat, 02 Jun 2018, Marek Vasut wrote:
>
>> In case mfd_add_devices() fails, da9063_irq_exit() is not called to
>> undo the IRQchip setup done by da9063_irq_init(). Fix this by adding
>> the missing fail path.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
>> Cc: Lee Jones <lee.jones@linaro.org>
>> Cc: Mark Brown <broonie@kernel.org>
>> Cc: Steve Twiss <stwiss.opensource@diasemi.com>
>> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
>> Cc: linux-renesas-soc@vger.kernel.org
>> ---
>> V3: New patch
>> ---
>> drivers/mfd/da9063-core.c | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mfd/da9063-core.c b/drivers/mfd/da9063-core.c
>> index 6c2870d4e754..8226ebd8b96d 100644
>> --- a/drivers/mfd/da9063-core.c
>> +++ b/drivers/mfd/da9063-core.c
>> @@ -229,10 +229,16 @@ int da9063_device_init(struct da9063 *da9063, unsigned int irq)
>> ret = mfd_add_devices(da9063->dev, -1, da9063_devs,
>> ARRAY_SIZE(da9063_devs), NULL, da9063->irq_base,
>> NULL);
>> - if (ret)
>> + if (ret) {
>> dev_err(da9063->dev, "Cannot add MFD cells\n");
>> + goto err_irq_exit;
>> + }
>>
>> return ret;
>> +
>> +err_irq_exit:
>> + da9063_irq_exit(da9063);
>> + return ret;
>> }
>>
>> void da9063_device_exit(struct da9063 *da9063)
>
> I haven't seen the later patches yet, so maybe the goto label expanded
> on, but if it's not, then this would be better:
>
> - if (ret)
> + if (ret) {
> dev_err(da9063->dev, "Cannot add MFD cells\n");
> + da9063_irq_exit(da9063);
> + }
>
> return ret;
> }
It did expand in the later patches, yes.
--
Best regards,
Marek Vasut
prev parent reply other threads:[~2018-06-04 13:08 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-02 10:11 [PATCH v3 01/10] mfd: da9063: Fix failpath in core Marek Vasut
2018-06-02 10:11 ` [PATCH v3 02/10] mfd: da9063: Use REGMAP_IRQ_REG Marek Vasut
2018-06-04 7:17 ` Geert Uytterhoeven
2018-06-04 12:26 ` Lee Jones
2018-06-04 16:23 ` Marek Vasut
2018-06-05 7:09 ` Lee Jones
2018-06-05 7:31 ` Geert Uytterhoeven
2018-06-05 8:16 ` Lee Jones
2018-06-05 19:48 ` Steve Twiss
2018-06-02 10:11 ` [PATCH v3 03/10] mfd: da9063: Rename PMIC_DA9063 to PMIC_CHIP_ID_DA9063 Marek Vasut
2018-06-04 12:26 ` Lee Jones
2018-06-04 18:31 ` Marek Vasut
2018-06-05 7:05 ` Lee Jones
2018-06-05 17:16 ` Steve Twiss
2018-06-05 17:20 ` Marek Vasut
2018-06-05 19:49 ` Steve Twiss
2018-06-02 10:11 ` [PATCH v3 04/10] mfd: da9063: Replace model with type Marek Vasut
2018-06-05 7:21 ` Lee Jones
2018-06-02 10:11 ` [PATCH v3 05/10] mfd: da9063: Add DA9063L type Marek Vasut
2018-06-05 7:22 ` Lee Jones
2018-06-05 19:50 ` Steve Twiss
2018-06-02 10:11 ` [PATCH v3 06/10] mfd: da9063: Add custom regmap for DA9063L Marek Vasut
2018-06-04 7:39 ` Geert Uytterhoeven
2018-06-04 16:25 ` Marek Vasut
2018-06-05 20:17 ` Steve Twiss
2018-06-05 23:02 ` Marek Vasut
2018-06-06 9:47 ` Steve Twiss
2018-06-06 9:50 ` Marek Vasut
2018-06-02 10:11 ` [PATCH v3 07/10] mfd: da9063: Add custom IRQ map " Marek Vasut
2018-06-05 7:47 ` Lee Jones
2018-06-05 7:54 ` Geert Uytterhoeven
2018-06-05 8:24 ` Lee Jones
2018-06-05 19:52 ` Steve Twiss
2018-06-05 22:58 ` Marek Vasut
2018-06-02 10:11 ` [PATCH v3 08/10] mfd: da9063: Register RTC only on DA9063L Marek Vasut
2018-06-05 7:53 ` Lee Jones
2018-06-05 9:29 ` Marek Vasut
2018-06-06 6:16 ` Lee Jones
2018-06-06 9:17 ` Marek Vasut
2018-06-07 5:04 ` Lee Jones
2018-06-07 10:57 ` Marek Vasut
2018-06-07 13:24 ` Lee Jones
2018-06-02 10:11 ` [PATCH v3 09/10] mfd: da9063: Handle less LDOs " Marek Vasut
2018-06-05 8:18 ` Lee Jones
2018-06-02 10:11 ` [PATCH v3 10/10] mfd: da9063: Add DA9063L support Marek Vasut
2018-06-05 8:18 ` Lee Jones
2018-06-05 19:47 ` Steve Twiss
2018-06-04 7:16 ` [PATCH v3 01/10] mfd: da9063: Fix failpath in core Geert Uytterhoeven
2018-06-04 8:28 ` Vaishali Thakkar
2018-06-04 12:24 ` Lee Jones
2018-06-04 13:08 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b76fcb6-87fc-36da-63af-4b77a09e6e59@gmail.com \
--to=marek.vasut@gmail.com \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=stwiss.opensource@diasemi.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).