[PATCH 0/9] Continuation line fixes

[PATCH 0/9] Continuation line fixes

[Joe Perches]

Fix undesired spaces caused by improper continuation line use

Joe Perches (9):
  arch/arm: Fix continuation lines
  arch/blackfin: Fix continuation lines
  drivers/infiniband: Fix continuation lines
  drivers/media: Fix continuation lines
  drivers/message: Fix continuation lines
  drivers/net: Fix continuation lines
  drivers/scsi: Fix continuation lines
  drivers/serial: Fix continuation lines
  mm: Fix continuation lines

 arch/arm/mach-s5pv210/clock.c       |    4 +-
 arch/blackfin/mach-common/smp.c     |    4 +-
 drivers/infiniband/hw/nes/nes_nic.c |    4 +-
 drivers/media/video/ov511.c         |    4 +-
 drivers/message/fusion/mptbase.c    |    8 +++---
 drivers/net/atlx/atl1.c             |    2 +-
 drivers/scsi/arcmsr/arcmsr_hba.c    |   50 +++++++++++++++++-----------------
 drivers/scsi/qla2xxx/qla_attr.c     |   18 ++++++------
 drivers/scsi/qla2xxx/qla_os.c       |    6 ++--
 drivers/serial/bfin_5xx.c           |    8 +++---
 mm/slab.c                           |    9 +++---
 11 files changed, 59 insertions(+), 58 deletions(-)

[PATCH 1/9] arch/arm: Fix continuation lines

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 arch/arm/mach-s5pv210/clock.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-s5pv210/clock.c b/arch/arm/mach-s5pv210/clock.c
index ccccae2..a989c5e 100644
--- a/arch/arm/mach-s5pv210/clock.c
+++ b/arch/arm/mach-s5pv210/clock.c
@@ -394,8 +394,8 @@ void __init_or_cpufreq s5pv210_setup_clocks(void)
 	pclk83 = hclk166 / GET_DIV(clkdiv0, S5P_CLKDIV0_PCLK83);
 	pclk66 = hclk133 / GET_DIV(clkdiv0, S5P_CLKDIV0_PCLK66);
 
-	printk(KERN_INFO "S5PV210: ARMCLK=%ld, HCLKM=%ld, HCLKD=%ld, \
-			HCLKP=%ld, PCLKM=%ld, PCLKD=%ld, PCLKP=%ld\n",
+	printk(KERN_INFO "S5PV210: ARMCLK=%ld, HCLKM=%ld, HCLKD=%ld, "
+			"HCLKP=%ld, PCLKM=%ld, PCLKD=%ld, PCLKP=%ld\n",
 	       armclk, hclk200, hclk166, hclk133, pclk100, pclk83, pclk66);
 
 	clk_fout_apll.rate = apll;
-- 
1.7.0.14.g7e948

[PATCH 2/9] arch/blackfin: Fix continuation lines

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 arch/blackfin/mach-common/smp.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/blackfin/mach-common/smp.c b/arch/blackfin/mach-common/smp.c
index 7803f22..f58a554 100644
--- a/arch/blackfin/mach-common/smp.c
+++ b/arch/blackfin/mach-common/smp.c
@@ -169,8 +169,8 @@ static irqreturn_t ipi_handler(int irq, void *dev_instance)
 			kfree(msg);
 			break;
 		default:
-			printk(KERN_CRIT "CPU%u: Unknown IPI message \
-			0x%lx\n", cpu, msg->type);
+			printk(KERN_CRIT "CPU%u: Unknown IPI message 0x%lx\n",
+			       cpu, msg->type);
 			kfree(msg);
 			break;
 		}
-- 
1.7.0.14.g7e948

[PATCH 3/9] drivers/infiniband: Fix continuation lines

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/infiniband/hw/nes/nes_nic.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/nes/nes_nic.c b/drivers/infiniband/hw/nes/nes_nic.c
index 91fdde3..9963676 100644
--- a/drivers/infiniband/hw/nes/nes_nic.c
+++ b/drivers/infiniband/hw/nes/nes_nic.c
@@ -902,9 +902,8 @@ static void nes_netdev_set_multicast_list(struct net_device *netdev)
 					nesvnic->nic_index &&
 					mc_index < max_pft_entries_avaiable) {
 						nes_debug(NES_DBG_NIC_RX,
-					"mc_index=%d skipping nic_index=%d,\
-					used for=%d \n", mc_index,
+					"mc_index=%d skipping nic_index=%d, "
+					"used for=%d\n", mc_index,
 					nesvnic->nic_index,
 					nesadapter->pft_mcast_map[mc_index]);
 				mc_index++;
-- 
1.7.0.14.g7e948

[PATCH 4/9] drivers/media: Fix continuation lines

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/media/video/ov511.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/video/ov511.c b/drivers/media/video/ov511.c
index e0bce8d..c34325c 100644
--- a/drivers/media/video/ov511.c
+++ b/drivers/media/video/ov511.c
@@ -57,8 +57,8 @@
 #define DRIVER_VERSION "v1.64 for Linux 2.5"
 #define EMAIL "mark@alpha.dyndns.org"
 #define DRIVER_AUTHOR "Mark McClelland <mark@alpha.dyndns.org> & Bret Wallach \
-	& Orion Sky Lawlor <olawlor@acm.org> & Kevin Moore & Charl P. Botha \
-	<cpbotha@ieee.org> & Claudio Matsuoka <claudio@conectiva.com>"
+& Orion Sky Lawlor <olawlor@acm.org> & Kevin Moore & Charl P. Botha \
+<cpbotha@ieee.org> & Claudio Matsuoka <claudio@conectiva.com>"
 #define DRIVER_DESC "ov511 USB Camera Driver"
 
 #define OV511_I2C_RETRIES 3
-- 
1.7.0.14.g7e948

[PATCH 5/9] drivers/message: Fix continuation lines

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/message/fusion/mptbase.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
index 5382b5a..6ab5f8e 100644
--- a/drivers/message/fusion/mptbase.c
+++ b/drivers/message/fusion/mptbase.c
@@ -83,17 +83,17 @@ MODULE_VERSION(my_VERSION);
 static int mpt_msi_enable_spi;
 module_param(mpt_msi_enable_spi, int, 0);
 MODULE_PARM_DESC(mpt_msi_enable_spi, " Enable MSI Support for SPI \
-		controllers (default=0)");
+controllers (default=0)");
 
 static int mpt_msi_enable_fc;
 module_param(mpt_msi_enable_fc, int, 0);
 MODULE_PARM_DESC(mpt_msi_enable_fc, " Enable MSI Support for FC \
-		controllers (default=0)");
+controllers (default=0)");
 
 static int mpt_msi_enable_sas;
 module_param(mpt_msi_enable_sas, int, 0);
 MODULE_PARM_DESC(mpt_msi_enable_sas, " Enable MSI Support for SAS \
-		controllers (default=0)");
+controllers (default=0)");
 
 
 static int mpt_channel_mapping;
@@ -105,7 +105,7 @@ static int mpt_set_debug_level(const char *val, struct kernel_param *kp);
 module_param_call(mpt_debug_level, mpt_set_debug_level, param_get_int,
 		  &mpt_debug_level, 0600);
 MODULE_PARM_DESC(mpt_debug_level, " debug level - refer to mptdebug.h \
-	- (default=0)");
+- (default=0)");
 
 int mpt_fwfault_debug;
 EXPORT_SYMBOL(mpt_fwfault_debug);
-- 
1.7.0.14.g7e948

[PATCH 6/9] drivers/net: Fix continuation lines

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/net/atlx/atl1.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c
index 9ba5470..0ebd820 100644
--- a/drivers/net/atlx/atl1.c
+++ b/drivers/net/atlx/atl1.c
@@ -84,7 +84,7 @@
 
 #define ATLX_DRIVER_VERSION "2.1.3"
 MODULE_AUTHOR("Xiong Huang <xiong.huang@atheros.com>, \
-	Chris Snook <csnook@redhat.com>, Jay Cliburn <jcliburn@gmail.com>");
+Chris Snook <csnook@redhat.com>, Jay Cliburn <jcliburn@gmail.com>");
 MODULE_LICENSE("GPL");
 MODULE_VERSION(ATLX_DRIVER_VERSION);
 
-- 
1.7.0.14.g7e948

[PATCH 7/9] drivers/scsi: Fix continuation lines

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/scsi/arcmsr/arcmsr_hba.c |   50 +++++++++++++++++++-------------------
 drivers/scsi/qla2xxx/qla_attr.c  |   18 +++++++-------
 drivers/scsi/qla2xxx/qla_os.c    |    6 ++--
 3 files changed, 37 insertions(+), 37 deletions(-)

diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
index 47d5d19..07a9fd6 100644
--- a/drivers/scsi/arcmsr/arcmsr_hba.c
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c
@@ -585,8 +585,8 @@ static void arcmsr_flush_hba_cache(struct AdapterControlBlock *acb)
 			break;
 		else {
 			retry_count--;
-			printk(KERN_NOTICE "arcmsr%d: wait 'flush adapter cache' \
-			timeout, retry count down = %d \n", acb->host->host_no, retry_count);
+			printk(KERN_NOTICE "arcmsr%d: wait 'flush adapter cache' "
+			"timeout, retry count down = %d\n", acb->host->host_no, retry_count);
 		}
 	} while (retry_count != 0);
 }
@@ -602,8 +602,8 @@ static void arcmsr_flush_hbb_cache(struct AdapterControlBlock *acb)
 			break;
 		else {
 			retry_count--;
-			printk(KERN_NOTICE "arcmsr%d: wait 'flush adapter cache' \
-			timeout,retry count down = %d \n", acb->host->host_no, retry_count);
+			printk(KERN_NOTICE "arcmsr%d: wait 'flush adapter cache' "
+			"timeout,retry count down = %d\n", acb->host->host_no, retry_count);
 		}
 	} while (retry_count != 0);
 }
@@ -732,14 +732,14 @@ static void arcmsr_drain_donequeue(struct AdapterControlBlock *acb, uint32_t fla
 			if (abortcmd) {
 				abortcmd->result |= DID_ABORT << 16;
 				arcmsr_ccb_complete(ccb, 1);
-				printk(KERN_NOTICE "arcmsr%d: ccb ='0x%p' \
-				isr got aborted command \n", acb->host->host_no, ccb);
+				printk(KERN_NOTICE "arcmsr%d: ccb ='0x%p' "
+				"isr got aborted command\n", acb->host->host_no, ccb);
 			}
 		}
-		printk(KERN_NOTICE "arcmsr%d: isr get an illegal ccb command \
-				done acb = '0x%p'"
-				"ccb = '0x%p' ccbacb = '0x%p' startdone = 0x%x"
-				" ccboutstandingcount = %d \n"
+		printk(KERN_NOTICE "arcmsr%d: isr get an illegal ccb command "
+				"done acb = '0x%p' "
+				"ccb = '0x%p' ccbacb = '0x%p' startdone = 0x%x "
+				"ccboutstandingcount = %d\n"
 				, acb->host->host_no
 				, acb
 				, ccb
@@ -1709,8 +1709,8 @@ static void arcmsr_get_hba_config(struct AdapterControlBlock *acb)
 
 	writel(ARCMSR_INBOUND_MESG0_GET_CONFIG, &reg->inbound_msgaddr0);
 	if (arcmsr_hba_wait_msgint_ready(acb)) {
-		printk(KERN_NOTICE "arcmsr%d: wait 'get adapter firmware \
-			miscellaneous data' timeout \n", acb->host->host_no);
+		printk(KERN_NOTICE "arcmsr%d: wait 'get adapter firmware "
+		       "miscellaneous data' timeout\n", acb->host->host_no);
 	}
 
 	count = 8;
@@ -1753,8 +1753,8 @@ static void arcmsr_get_hbb_config(struct AdapterControlBlock *acb)
 
 	writel(ARCMSR_MESSAGE_GET_CONFIG, reg->drv2iop_doorbell_reg);
 	if (arcmsr_hbb_wait_msgint_ready(acb)) {
-		printk(KERN_NOTICE "arcmsr%d: wait 'get adapter firmware \
-			miscellaneous data' timeout \n", acb->host->host_no);
+		printk(KERN_NOTICE "arcmsr%d: wait 'get adapter firmware "
+		       "miscellaneous data' timeout\n", acb->host->host_no);
 	}
 
 	count = 8;
@@ -1889,8 +1889,8 @@ static void arcmsr_polling_hbb_ccbdone(struct AdapterControlBlock *acb,
 			poll_ccb_done = (ccb == poll_ccb) ? 1:0;
 			if ((ccb->acb != acb) || (ccb->startdone != ARCMSR_CCB_START)) {
 				if ((ccb->startdone == ARCMSR_CCB_ABORTED) || (ccb == poll_ccb)) {
-					printk(KERN_NOTICE "arcmsr%d: \
-		scsi id = %d lun = %d ccb = '0x%p' poll command abort successfully \n"
+					printk(KERN_NOTICE "arcmsr%d: "
+		"scsi id = %d lun = %d ccb = '0x%p' poll command abort successfully\n"
 						,acb->host->host_no
 						,ccb->pcmd->device->id
 						,ccb->pcmd->device->lun
@@ -1958,8 +1958,8 @@ static int arcmsr_iop_confirm(struct AdapterControlBlock *acb)
 			writel(ARCMSR_INBOUND_MESG0_SET_CONFIG, \
 							&reg->inbound_msgaddr0);
 			if (arcmsr_hba_wait_msgint_ready(acb)) {
-				printk(KERN_NOTICE "arcmsr%d: ""set ccb high \
-				part physical address timeout\n",
+				printk(KERN_NOTICE "arcmsr%d: set ccb high "
+				"part physical address timeout\n",
 				acb->host->host_no);
 				return 1;
 			}
@@ -1999,14 +1999,14 @@ static int arcmsr_iop_confirm(struct AdapterControlBlock *acb)
 
 		writel(ARCMSR_MESSAGE_SET_CONFIG, reg->drv2iop_doorbell_reg);
 		if (arcmsr_hbb_wait_msgint_ready(acb)) {
-			printk(KERN_NOTICE "arcmsr%d: 'set command Q window' \
-			timeout \n",acb->host->host_no);
+			printk(KERN_NOTICE "arcmsr%d: 'set command Q window' "
+			"timeout\n",acb->host->host_no);
 			return 1;
 		}
 
 		writel(ARCMSR_MESSAGE_START_DRIVER_MODE, reg->drv2iop_doorbell_reg);
 		if (arcmsr_hbb_wait_msgint_ready(acb)) {
-			printk(KERN_NOTICE "arcmsr%d: 'can not set diver mode \n"\
+			printk(KERN_NOTICE "arcmsr%d: 'can not set diver mode\n"
 			,acb->host->host_no);
 			return 1;
 		}
@@ -2048,8 +2048,8 @@ static void arcmsr_start_hba_bgrb(struct AdapterControlBlock *acb)
 	acb->acb_flags |= ACB_F_MSG_START_BGRB;
 	writel(ARCMSR_INBOUND_MESG0_START_BGRB, &reg->inbound_msgaddr0);
 	if (arcmsr_hba_wait_msgint_ready(acb)) {
-		printk(KERN_NOTICE "arcmsr%d: wait 'start adapter background \
-				rebulid' timeout \n", acb->host->host_no);
+		printk(KERN_NOTICE "arcmsr%d: wait 'start adapter background "
+				"rebuild' timeout\n", acb->host->host_no);
 	}
 }
 
@@ -2059,8 +2059,8 @@ static void arcmsr_start_hbb_bgrb(struct AdapterControlBlock *acb)
 	acb->acb_flags |= ACB_F_MSG_START_BGRB;
 	writel(ARCMSR_MESSAGE_START_BGRB, reg->drv2iop_doorbell_reg);
 	if (arcmsr_hbb_wait_msgint_ready(acb)) {
-		printk(KERN_NOTICE "arcmsr%d: wait 'start adapter background \
-				rebulid' timeout \n",acb->host->host_no);
+		printk(KERN_NOTICE "arcmsr%d: wait 'start adapter background "
+				"rebuild' timeout\n",acb->host->host_no);
 	}
 }
 
diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c
index 90d1e06..ea87ea7 100644
--- a/drivers/scsi/qla2xxx/qla_attr.c
+++ b/drivers/scsi/qla2xxx/qla_attr.c
@@ -1946,9 +1946,9 @@ qla2x00_process_els(struct fc_bsg_job *bsg_job)
 	    (rsp_sg_cnt != bsg_job->reply_payload.sg_cnt))
 	{
 		DEBUG2(printk(KERN_INFO
-		    "dma mapping resulted in different sg counts \
-		    [request_sg_cnt: %x dma_request_sg_cnt: %x\
-		    reply_sg_cnt: %x dma_reply_sg_cnt: %x]\n",
+		    "dma mapping resulted in different sg counts "
+		    "[request_sg_cnt: %x dma_request_sg_cnt: %x "
+		    "reply_sg_cnt: %x dma_reply_sg_cnt: %x]\n",
 		    bsg_job->request_payload.sg_cnt, req_sg_cnt,
 		    bsg_job->reply_payload.sg_cnt, rsp_sg_cnt));
 		rval = -EAGAIN;
@@ -2040,9 +2040,9 @@ qla2x00_process_ct(struct fc_bsg_job *bsg_job)
 		(rsp_sg_cnt != bsg_job->reply_payload.sg_cnt))
 	{
 		DEBUG2(qla_printk(KERN_WARNING, ha,
-		    "dma mapping resulted in different sg counts \
-		    [request_sg_cnt: %x dma_request_sg_cnt: %x\
-		    reply_sg_cnt: %x dma_reply_sg_cnt: %x]\n",
+		    "dma mapping resulted in different sg counts "
+		    "[request_sg_cnt: %x dma_request_sg_cnt: %x "
+		    "reply_sg_cnt: %x dma_reply_sg_cnt: %x]\n",
 		    bsg_job->request_payload.sg_cnt, req_sg_cnt,
 		    bsg_job->reply_payload.sg_cnt, rsp_sg_cnt));
 		rval = -EAGAIN;
@@ -2184,9 +2184,9 @@ qla2x00_process_vendor_specific(struct fc_bsg_job *bsg_job)
 	    (elreq.rsp_sg_cnt != bsg_job->reply_payload.sg_cnt))
 	{
 		DEBUG2(printk(KERN_INFO
-		    "dma mapping resulted in different sg counts \
-		    [request_sg_cnt: %x dma_request_sg_cnt: %x\
-		    reply_sg_cnt: %x dma_reply_sg_cnt: %x]\n",
+		    "dma mapping resulted in different sg counts "
+		    "[request_sg_cnt: %x dma_request_sg_cnt: %x "
+		    "reply_sg_cnt: %x dma_reply_sg_cnt: %x]\n",
 		    bsg_job->request_payload.sg_cnt, elreq.req_sg_cnt,
 		    bsg_job->reply_payload.sg_cnt, elreq.rsp_sg_cnt));
 		rval = -EAGAIN;
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 46720b2..eccbff3 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -87,9 +87,9 @@ MODULE_PARM_DESC(ql2xiidmaenable,
 int ql2xmaxqueues = 1;
 module_param(ql2xmaxqueues, int, S_IRUGO|S_IRUSR);
 MODULE_PARM_DESC(ql2xmaxqueues,
-		"Enables MQ settings "
-		"Default is 1 for single queue. Set it to number \
-			of queues in MQ mode.");
+		 "Enables MQ settings "
+		 "Default is 1 for single queue. "
+		 "Set it to number of queues in MQ mode.");
 
 int ql2xmultique_tag;
 module_param(ql2xmultique_tag, int, S_IRUGO|S_IRUSR);
-- 
1.7.0.14.g7e948

[PATCH 8/9] drivers/serial: Fix continuation lines

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/serial/bfin_5xx.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/serial/bfin_5xx.c b/drivers/serial/bfin_5xx.c
index fcf273e..48f1986 100644
--- a/drivers/serial/bfin_5xx.c
+++ b/drivers/serial/bfin_5xx.c
@@ -733,8 +733,8 @@ static int bfin_serial_startup(struct uart_port *port)
 			IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING |
 			IRQF_DISABLED, "BFIN_UART_CTS", uart)) {
 			uart->cts_pin = -1;
-			pr_info("Unable to attach BlackFin UART CTS interrupt.\
-				 So, disable it.\n");
+			pr_info("Unable to attach BlackFin UART CTS interrupt."
+				" So, disable it.\n");
 		}
 	}
 	if (uart->rts_pin >= 0) {
@@ -746,8 +746,8 @@ static int bfin_serial_startup(struct uart_port *port)
 	if (request_irq(uart->status_irq,
 		bfin_serial_mctrl_cts_int,
 		IRQF_DISABLED, "BFIN_UART_MODEM_STATUS", uart)) {
-		pr_info("Unable to attach BlackFin UART Modem \
-			Status interrupt.\n");
+		pr_info("Unable to attach BlackFin UART Modem "
+			"Status interrupt.\n");
 	}
 
 	/* CTS RTS PINs are negative assertive. */
-- 
1.7.0.14.g7e948

[PATCH 9/9] mm: Fix continuation lines

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 mm/slab.c |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/mm/slab.c b/mm/slab.c
index a9f325b..ceb4e3a 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -4227,10 +4227,11 @@ static int s_show(struct seq_file *m, void *p)
 		unsigned long node_frees = cachep->node_frees;
 		unsigned long overflows = cachep->node_overflow;
 
-		seq_printf(m, " : globalstat %7lu %6lu %5lu %4lu \
-				%4lu %4lu %4lu %4lu %4lu", allocs, high, grown,
-				reaped, errors, max_freeable, node_allocs,
-				node_frees, overflows);
+		seq_printf(m, " : globalstat %7lu %6lu %5lu %4lu "
+			   "%4lu %4lu %4lu %4lu %4lu",
+			   allocs, high, grown,
+			   reaped, errors, max_freeable, node_allocs,
+			   node_frees, overflows);
 	}
 	/* cpu stats */
 	{
-- 
1.7.0.14.g7e948

Re: [Uclinux-dist-devel] [PATCH 8/9] drivers/serial: Fix continuation lines

[Mike Frysinger]

looks fine to me, thanks
Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike

Re: [Uclinux-dist-devel] [PATCH 2/9] arch/blackfin: Fix continuation lines

[Mike Frysinger]

looks fine, i'll merge into my tree.  thanks!
-mike

Re: [PATCH 6/9] drivers/net: Fix continuation lines

[David Miller]

From: Joe Perches <joe@perches.com>
Date: Fri, 26 Mar 2010 19:27:55 -0700

> Signed-off-by: Joe Perches <joe@perches.com>

Applied.

Re: [PATCH 9/9] mm: Fix continuation lines

[Pekka Enberg]

Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com>

Applied.

> ---
>  mm/slab.c |    9 +++++----
>  1 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/slab.c b/mm/slab.c
> index a9f325b..ceb4e3a 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -4227,10 +4227,11 @@ static int s_show(struct seq_file *m, void *p)
>  		unsigned long node_frees = cachep->node_frees;
>  		unsigned long overflows = cachep->node_overflow;
>  
> -		seq_printf(m, " : globalstat %7lu %6lu %5lu %4lu \
> -				%4lu %4lu %4lu %4lu %4lu", allocs, high, grown,
> -				reaped, errors, max_freeable, node_allocs,
> -				node_frees, overflows);
> +		seq_printf(m, " : globalstat %7lu %6lu %5lu %4lu "
> +			   "%4lu %4lu %4lu %4lu %4lu",
> +			   allocs, high, grown,
> +			   reaped, errors, max_freeable, node_allocs,
> +			   node_frees, overflows);
>  	}
>  	/* cpu stats */
>  	{

Re: [PATCH 1/9] arch/arm: Fix continuation lines

[Russell King - ARM Linux]

This is Samsung stuff, it should be copied to Ben (added).

On Fri, Mar 26, 2010 at 07:27:50PM -0700, Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  arch/arm/mach-s5pv210/clock.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-s5pv210/clock.c b/arch/arm/mach-s5pv210/clock.c
> index ccccae2..a989c5e 100644
> --- a/arch/arm/mach-s5pv210/clock.c
> +++ b/arch/arm/mach-s5pv210/clock.c
> @@ -394,8 +394,8 @@ void __init_or_cpufreq s5pv210_setup_clocks(void)
>  	pclk83 = hclk166 / GET_DIV(clkdiv0, S5P_CLKDIV0_PCLK83);
>  	pclk66 = hclk133 / GET_DIV(clkdiv0, S5P_CLKDIV0_PCLK66);
>  
> -	printk(KERN_INFO "S5PV210: ARMCLK=%ld, HCLKM=%ld, HCLKD=%ld, \
> -			HCLKP=%ld, PCLKM=%ld, PCLKD=%ld, PCLKP=%ld\n",
> +	printk(KERN_INFO "S5PV210: ARMCLK=%ld, HCLKM=%ld, HCLKD=%ld, "
> +			"HCLKP=%ld, PCLKM=%ld, PCLKD=%ld, PCLKP=%ld\n",
>  	       armclk, hclk200, hclk166, hclk133, pclk100, pclk83, pclk66);
>  
>  	clk_fout_apll.rate = apll;
> -- 
> 1.7.0.14.g7e948
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH] MAINTAINERS: arch/arm/s3c and arch/arm/s5p

[Joe Perches]

On Mon, 2010-04-12 at 20:47 +0100, Russell King - ARM Linux wrote:
> This is Samsung stuff, it should be copied to Ben (added).

Maybe this is appropriate?

Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |   40 ++++++++--------------------------------
 1 files changed, 8 insertions(+), 32 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 7a9ccda..5a0d6ef 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -902,48 +902,24 @@ W:	http://www.fluff.org/ben/linux/
 S:	Maintained
 F:	arch/arm/plat-s3c/
 F:	arch/arm/plat-s3c24xx/
+F:	arch/arm/plat-samsung/
 
-ARM/S3C2410 ARM ARCHITECTURE
+ARM/S3Cxxxx ARM ARCHITECTURE
 M:	Ben Dooks <ben-linux@fluff.org>
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
 W:	http://www.fluff.org/ben/linux/
 S:	Maintained
-F:	arch/arm/mach-s3c2410/
-
-ARM/S3C2440 ARM ARCHITECTURE
-M:	Ben Dooks <ben-linux@fluff.org>
-L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
-W:	http://www.fluff.org/ben/linux/
-S:	Maintained
-F:	arch/arm/mach-s3c2440/
-
-ARM/S3C2442 ARM ARCHITECTURE
-M:	Ben Dooks <ben-linux@fluff.org>
-L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
-W:	http://www.fluff.org/ben/linux/
-S:	Maintained
-F:	arch/arm/mach-s3c2442/
-
-ARM/S3C2443 ARM ARCHITECTURE
-M:	Ben Dooks <ben-linux@fluff.org>
-L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
-W:	http://www.fluff.org/ben/linux/
-S:	Maintained
-F:	arch/arm/mach-s3c2443/
-
-ARM/S3C6400 ARM ARCHITECTURE
-M:	Ben Dooks <ben-linux@fluff.org>
-L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
-W:	http://www.fluff.org/ben/linux/
-S:	Maintained
-F:	arch/arm/mach-s3c6400/
+F:	arch/arm/mach-s3c????/
+F:	arch/arm/plat-s3c????/
 
-ARM/S3C6410 ARM ARCHITECTURE
+ARM/S5Pxxxx ARM ARCHITECTURE
 M:	Ben Dooks <ben-linux@fluff.org>
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
 W:	http://www.fluff.org/ben/linux/
 S:	Maintained
-F:	arch/arm/mach-s3c6410/
+F:	arch/arm/mach-s5p????/
+F:	arch/arm/plat-s5p/
+F:	arch/arm/plat-s5p????/
 
 ARM/SHMOBILE ARM ARCHITECTURE
 M:	Paul Mundt <lethal@linux-sh.org>

Re: [PATCH] MAINTAINERS: arch/arm/s3c and arch/arm/s5p

[Kyungmin Park]

Hi,

On Tue, Apr 13, 2010 at 5:00 AM, Joe Perches <joe@perches.com> wrote:
> On Mon, 2010-04-12 at 20:47 +0100, Russell King - ARM Linux wrote:
>> This is Samsung stuff, it should be copied to Ben (added).
>
> Maybe this is appropriate?

No, s5p stubs are maintained by Samsung.
Of course Ben work on core part together, e.g., clock, interrupt.

Most s5pc1XX are done by Marek and Kyungmin Park except plat-samsung.
common part of Samsung SoCs.

Thank you,
Kyungmin Park

>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  MAINTAINERS |   40 ++++++++--------------------------------
>  1 files changed, 8 insertions(+), 32 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7a9ccda..5a0d6ef 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -902,48 +902,24 @@ W:        http://www.fluff.org/ben/linux/
>  S:     Maintained
>  F:     arch/arm/plat-s3c/
>  F:     arch/arm/plat-s3c24xx/
> +F:     arch/arm/plat-samsung/
>
> -ARM/S3C2410 ARM ARCHITECTURE
> +ARM/S3Cxxxx ARM ARCHITECTURE
>  M:     Ben Dooks <ben-linux@fluff.org>
>  L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
>  W:     http://www.fluff.org/ben/linux/
>  S:     Maintained
> -F:     arch/arm/mach-s3c2410/
> -
> -ARM/S3C2440 ARM ARCHITECTURE
> -M:     Ben Dooks <ben-linux@fluff.org>
> -L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> -W:     http://www.fluff.org/ben/linux/
> -S:     Maintained
> -F:     arch/arm/mach-s3c2440/
> -
> -ARM/S3C2442 ARM ARCHITECTURE
> -M:     Ben Dooks <ben-linux@fluff.org>
> -L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> -W:     http://www.fluff.org/ben/linux/
> -S:     Maintained
> -F:     arch/arm/mach-s3c2442/
> -
> -ARM/S3C2443 ARM ARCHITECTURE
> -M:     Ben Dooks <ben-linux@fluff.org>
> -L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> -W:     http://www.fluff.org/ben/linux/
> -S:     Maintained
> -F:     arch/arm/mach-s3c2443/
> -
> -ARM/S3C6400 ARM ARCHITECTURE
> -M:     Ben Dooks <ben-linux@fluff.org>
> -L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> -W:     http://www.fluff.org/ben/linux/
> -S:     Maintained
> -F:     arch/arm/mach-s3c6400/
> +F:     arch/arm/mach-s3c????/
> +F:     arch/arm/plat-s3c????/
>
> -ARM/S3C6410 ARM ARCHITECTURE
> +ARM/S5Pxxxx ARM ARCHITECTURE
>  M:     Ben Dooks <ben-linux@fluff.org>

It should be Byungho Min but now changed to Marek and Kyungmin Park

>  L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
>  W:     http://www.fluff.org/ben/linux/
>  S:     Maintained
> -F:     arch/arm/mach-s3c6410/
> +F:     arch/arm/mach-s5p????/
> +F:     arch/arm/plat-s5p/
> +F:     arch/arm/plat-s5p????/
>
>  ARM/SHMOBILE ARM ARCHITECTURE
>  M:     Paul Mundt <lethal@linux-sh.org>
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

Re: [PATCH] MAINTAINERS: arch/arm/s3c and arch/arm/s5p

[Joe Perches]

On Tue, 2010-04-13 at 08:53 +0900, Kyungmin Park wrote:
> No, s5p stubs are maintained by Samsung.
> Of course Ben work on core part together, e.g., clock, interrupt.
> 
> Most s5pc1XX are done by Marek and Kyungmin Park except plat-samsung.
> common part of Samsung SoCs.

So perhaps you'll add yourself and the correct entries to MAINTAINERS?

Re: [PATCH] MAINTAINERS: arch/arm/s3c and arch/arm/s5p

[Ben Dooks]

On Sat, Apr 17, 2010 at 04:43:34AM +0900, Kyungmin Park wrote:
> Please add me and marek.
> Ben how do you think? Marek is proper person since he posted a lot of s5p
> series patches.
> Note that byoungho min is no longer works on this series

I thought the System LSI group where wanting to maintain this, which is
why I've been holding off making any comment about what is going on.

Personally, I would like to see a co-maintainership between myself
and whoever at Samsung before completely handing over the responsibility.
 
> Thank you,
> Kyungmin Park
> 
> On Apr 12, 2010 7:47 PM, "Joe Perches" <joe@perches.com> wrote:
> 
> On Tue, 2010-04-13 at 08:53 +0900, Kyungmin Park wrote:
> > No, s5p stubs are maintained by Samsung.
> >...
> So perhaps you'll add yourself and the correct entries to MAINTAINERS?

> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


-- 
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

Re: [PATCH] MAINTAINERS: arch/arm/s3c and arch/arm/s5p

[Kyungmin Park]

On Tue, May 4, 2010 at 9:46 AM, Ben Dooks <ben-linux@fluff.org> wrote:
> On Sat, Apr 17, 2010 at 04:43:34AM +0900, Kyungmin Park wrote:
>> Please add me and marek.
>> Ben how do you think? Marek is proper person since he posted a lot of s5p
>> series patches.
>> Note that byoungho min is no longer works on this series
>
> I thought the System LSI group where wanting to maintain this, which is
> why I've been holding off making any comment about what is going on.
>
> Personally, I would like to see a co-maintainership between myself
> and whoever at Samsung before completely handing over the responsibility.

I agree. then how about the Marek, even though LSI want it. they don't
have enough experience with open source works. you can see the recent
their works at their git. but we are trying to modify and make a patch
with open source style.

Also we setup the public git for open source

Thank you,
Kyungmin Park

P.S., when do you expect to hand-over responsibility to others?
>
>> Thank you,
>> Kyungmin Park
>>
>> On Apr 12, 2010 7:47 PM, "Joe Perches" <joe@perches.com> wrote:
>>
>> On Tue, 2010-04-13 at 08:53 +0900, Kyungmin Park wrote:
>> > No, s5p stubs are maintained by Samsung.
>> >...
>> So perhaps you'll add yourself and the correct entries to MAINTAINERS?
>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
> --
> --
> Ben
>
> Q:      What's a light-year?
> A:      One-third less calories than a regular year.
>
>

RE: [PATCH] MAINTAINERS: arch/arm/s3c and arch/arm/s5p

[Kukjin Kim]

Kyungmin Park wrote:
> On Tue, May 4, 2010 at 9:46 AM, Ben Dooks <ben-linux@fluff.org> wrote:
> > On Sat, Apr 17, 2010 at 04:43:34AM +0900, Kyungmin Park wrote:
> >> Please add me and marek.
> >> Ben how do you think? Marek is proper person since he posted a lot of
s5p
> >> series patches.
> >> Note that byoungho min is no longer works on this series
> >
> > I thought the System LSI group where wanting to maintain this, which is
> > why I've been holding off making any comment about what is going on.
> >
> > Personally, I would like to see a co-maintainership between myself
> > and whoever at Samsung before completely handing over the responsibility.
> 
> I agree. then how about the Marek, even though LSI want it. they don't
> have enough experience with open source works. you can see the recent
> their works at their git. but we are trying to modify and make a patch
> with open source style.

Hi,

I don't agree with your opinion that System LSI doesn't have enough
experience.
What is 'enough experience' that you said? Is it about posting to mailing
list ?
I and my team members also have been posting Samsung SoC patches related to
Samsung SoC more than you think, even though you argued you and Marek posted
a lot of s5p series patches.

> Also we setup the public git for open source

When it comes to the public git, System LSI has setup the open git a few
months earlier than you.
I hope you stop criticizing us. :-)

Anyway, we will continue to make much contributions as now.

> Thank you,
> Kyungmin Park
> 
> P.S., when do you expect to hand-over responsibility to others?
> >
> >> Thank you,
> >> Kyungmin Park
> >>
> >> On Apr 12, 2010 7:47 PM, "Joe Perches" <joe@perches.com> wrote:
> >>
> >> On Tue, 2010-04-13 at 08:53 +0900, Kyungmin Park wrote:
> >> > No, s5p stubs are maintained by Samsung.
> >> >...
> >> So perhaps you'll add yourself and the correct entries to MAINTAINERS?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.