* [PATCH -next] gpio: fix SNPS_CREG kconfig dependency warning
@ 2018-10-13 3:46 Randy Dunlap
2018-10-15 14:24 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2018-10-13 3:46 UTC (permalink / raw)
To: linux-gpio, Linus Walleij; +Cc: LKML, Andrew Morton, Eugeniy Paltsev
From: Randy Dunlap <rdunlap@infradead.org>
Fix kconfig warning for GPIO_SNPS_CREG:
WARNING: unmet direct dependencies detected for OF_GPIO
Depends on [n]: GPIOLIB [=y] && OF [=n] && HAS_IOMEM [=y]
Selected by [y]:
- GPIO_SNPS_CREG [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && (ARC || COMPILE_TEST [=y])
Drivers in drivers/gpio/Kconfig depend on OF_GPIO, not select it.
This prevents attempting to build when OF is not enabled.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org
Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
---
Found in mmotm but comes from/applies to linux-next.
drivers/gpio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20181012.orig/drivers/gpio/Kconfig
+++ linux-next-20181012/drivers/gpio/Kconfig
@@ -439,7 +439,7 @@ config GPIO_SIOX
config GPIO_SNPS_CREG
bool "Synopsys GPIO via CREG (Control REGisters) driver"
depends on ARC || COMPILE_TEST
- select OF_GPIO
+ depends on OF_GPIO
help
This driver supports GPIOs via CREG on various Synopsys SoCs.
This is a single-register MMIO GPIO driver for complex cases
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] gpio: fix SNPS_CREG kconfig dependency warning
2018-10-13 3:46 [PATCH -next] gpio: fix SNPS_CREG kconfig dependency warning Randy Dunlap
@ 2018-10-15 14:24 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2018-10-15 14:24 UTC (permalink / raw)
To: Randy Dunlap
Cc: open list:GPIO SUBSYSTEM, linux-kernel, Andrew Morton, Eugeniy.Paltsev
On Sat, Oct 13, 2018 at 5:46 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kconfig warning for GPIO_SNPS_CREG:
>
> WARNING: unmet direct dependencies detected for OF_GPIO
> Depends on [n]: GPIOLIB [=y] && OF [=n] && HAS_IOMEM [=y]
> Selected by [y]:
> - GPIO_SNPS_CREG [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && (ARC || COMPILE_TEST [=y])
>
> Drivers in drivers/gpio/Kconfig depend on OF_GPIO, not select it.
> This prevents attempting to build when OF is not enabled.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-gpio@vger.kernel.org
> Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> ---
> Found in mmotm but comes from/applies to linux-next.
Patch applied, thanks!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-15 14:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-13 3:46 [PATCH -next] gpio: fix SNPS_CREG kconfig dependency warning Randy Dunlap
2018-10-15 14:24 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).