From: Wan Zongshun <vw@iommu.org>
To: Joerg Roedel <joro@8bytes.org>, Wan Zongshun <vincent.wan@amd.com>
Cc: iommu@lists.linux-foundation.org, mcuos.com@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/amd: Set AMD iommu callbacks for platform bus driver
Date: Mon, 9 May 2016 20:17:12 +0800 [thread overview]
Message-ID: <8c4cc9fc-26df-759e-6630-7bab927cf01b@iommu.org> (raw)
In-Reply-To: <20160509102041.GA13275@8bytes.org>
-------- Original Message --------
> On Thu, Apr 14, 2016 at 09:28:53AM -0400, Wan Zongshun wrote:
>> From: Wan Zongshun <Vincent.Wan@amd.com>
>>
>> AMD has more drivers will use ACPI to platform bus driver later,
>> all those devices need iommu support, such as eMMC acpi driver.
>>
>> Signed-off-by: Wan Zongshun <Vincent.Wan@amd.com>
>> ---
>> drivers/iommu/amd_iommu.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
>> index c430c10..547cdd4 100644
>> --- a/drivers/iommu/amd_iommu.c
>> +++ b/drivers/iommu/amd_iommu.c
>> @@ -21,6 +21,7 @@
>> #include <linux/pci.h>
>> #include <linux/acpi.h>
>> #include <linux/amba/bus.h>
>> +#include <linux/platform_device.h>
>> #include <linux/pci-ats.h>
>> #include <linux/bitmap.h>
>> #include <linux/slab.h>
>> @@ -2980,6 +2981,9 @@ int __init amd_iommu_init_api(void)
>> if (err)
>> return err;
>> #endif
>> + err = bus_set_iommu(&platform_bus_type, &amd_iommu_ops);
>> + if (err)
>> + return err;
>
> Is the platform_bus_type always defined or does this code needs to be
> guarded by another ifdef?
Joerg,
Currently, Only New eMMC driver will rely on this sdhci-acpi.c, but I
could not find a suitable ifdef XXX micro to limit this
platform_bus_type here like AMBA bus type before.
Do you think this MMC_SDHCI_ACPI is ok?
Vincent.
>
>
>
> Joerg
>
next prev parent reply other threads:[~2016-05-09 12:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 13:28 [PATCH] iommu/amd: Set AMD iommu callbacks for platform bus driver Wan Zongshun
2016-05-09 10:20 ` Joerg Roedel
2016-05-09 12:17 ` Wan Zongshun [this message]
2016-05-09 16:16 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c4cc9fc-26df-759e-6630-7bab927cf01b@iommu.org \
--to=vw@iommu.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcuos.com@gmail.com \
--cc=vincent.wan@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).