linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Wan Zongshun <vw@iommu.org>
Cc: Wan Zongshun <vincent.wan@amd.com>,
	iommu@lists.linux-foundation.org, mcuos.com@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/amd: Set AMD iommu callbacks for platform bus driver
Date: Mon, 9 May 2016 18:16:55 +0200	[thread overview]
Message-ID: <20160509161655.GF13971@8bytes.org> (raw)
In-Reply-To: <8c4cc9fc-26df-759e-6630-7bab927cf01b@iommu.org>

On Mon, May 09, 2016 at 08:17:12PM +0800, Wan Zongshun wrote:
> Currently, Only New eMMC driver will rely on this sdhci-acpi.c, but
> I could not find a suitable ifdef XXX micro to limit this
> platform_bus_type here like AMBA bus type before.
> 
> Do you think this MMC_SDHCI_ACPI is ok?

Okay, looks like platform_bus_type does not depend on any config-symbol.
So the patch is fine, but please add a comment why the iommu-ops are
needed on the platform bus.


	Joerg

      reply	other threads:[~2016-05-09 16:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-14 13:28 [PATCH] iommu/amd: Set AMD iommu callbacks for platform bus driver Wan Zongshun
2016-05-09 10:20 ` Joerg Roedel
2016-05-09 12:17   ` Wan Zongshun
2016-05-09 16:16     ` Joerg Roedel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160509161655.GF13971@8bytes.org \
    --to=joro@8bytes.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcuos.com@gmail.com \
    --cc=vincent.wan@amd.com \
    --cc=vw@iommu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).