* [PATCH -next] tracing: Make two symbols static
@ 2019-06-14 15:32 YueHaibing
2019-06-14 19:58 ` Zanussi, Tom
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-06-14 15:32 UTC (permalink / raw)
To: rostedt, mingo, tom.zanussi; +Cc: linux-kernel, YueHaibing
Fix sparse warnings:
kernel/trace/trace.c:6927:24: warning:
symbol 'get_tracing_log_err' was not declared. Should it be static?
kernel/trace/trace.c:8196:15: warning:
symbol 'trace_instance_dir' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
kernel/trace/trace.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index a092e40..650b141 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -6924,7 +6924,7 @@ struct tracing_log_err {
static DEFINE_MUTEX(tracing_err_log_lock);
-struct tracing_log_err *get_tracing_log_err(struct trace_array *tr)
+static struct tracing_log_err *get_tracing_log_err(struct trace_array *tr)
{
struct tracing_log_err *err;
@@ -8193,7 +8193,7 @@ static const struct file_operations buffer_percent_fops = {
.llseek = default_llseek,
};
-struct dentry *trace_instance_dir;
+static struct dentry *trace_instance_dir;
static void
init_tracer_tracefs(struct trace_array *tr, struct dentry *d_tracer);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] tracing: Make two symbols static
2019-06-14 15:32 [PATCH -next] tracing: Make two symbols static YueHaibing
@ 2019-06-14 19:58 ` Zanussi, Tom
0 siblings, 0 replies; 2+ messages in thread
From: Zanussi, Tom @ 2019-06-14 19:58 UTC (permalink / raw)
To: YueHaibing, rostedt, mingo; +Cc: linux-kernel
Hi YueHaibing,
On 6/14/2019 10:32 AM, YueHaibing wrote:
> Fix sparse warnings:
>
> kernel/trace/trace.c:6927:24: warning:
> symbol 'get_tracing_log_err' was not declared. Should it be static?
> kernel/trace/trace.c:8196:15: warning:
> symbol 'trace_instance_dir' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
These look fine to me.
Acked-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Thanks,
Tom
> ---
> kernel/trace/trace.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index a092e40..650b141 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -6924,7 +6924,7 @@ struct tracing_log_err {
>
> static DEFINE_MUTEX(tracing_err_log_lock);
>
> -struct tracing_log_err *get_tracing_log_err(struct trace_array *tr)
> +static struct tracing_log_err *get_tracing_log_err(struct trace_array *tr)
> {
> struct tracing_log_err *err;
>
> @@ -8193,7 +8193,7 @@ static const struct file_operations buffer_percent_fops = {
> .llseek = default_llseek,
> };
>
> -struct dentry *trace_instance_dir;
> +static struct dentry *trace_instance_dir;
>
> static void
> init_tracer_tracefs(struct trace_array *tr, struct dentry *d_tracer);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-14 19:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-14 15:32 [PATCH -next] tracing: Make two symbols static YueHaibing
2019-06-14 19:58 ` Zanussi, Tom
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).