Re: [PATCH] staging: erofs: Add a blank line after declarations

Re: [PATCH] staging: erofs: Add a blank line after declarations

[Gao Xiang]

Hi Sungkyung,

On 2018/12/12 23:50, Sungkyung Kim wrote:
> Fix a warning from checkpathch.pl: 'Missing a blank line after
> declarations'
> 
> Signed-off-by: Sungkyung Kim <jotun9935@gmail.com>
> ---
>  drivers/staging/erofs/inode.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
> index 04c61a9d7b76..82b6ad5badff 100644
> --- a/drivers/staging/erofs/inode.c
> +++ b/drivers/staging/erofs/inode.c
> @@ -278,6 +278,7 @@ struct inode *erofs_iget(struct super_block *sb,
>  	if (inode->i_state & I_NEW) {
>  		int err;
>  		struct erofs_vnode *vi = EROFS_V(inode);
> +

Thanks for your patch, is there a only one 'Missing a blank line after declarations' in erofs?

If not, could you have time check the other files? That is my personal thought, and
I cc-ed the staging mailing list as well.

Thanks,
Gao Xiang

>  		vi->nid = nid;
>  
>  		err = fill_inode(inode, isdir);
> 

Re: [PATCH] staging: erofs: Add a blank line after declarations

[Gao Xiang]

On 2018/12/13 11:29, 김성경 wrote:
> Thank you. I appreciate it for your prompt reply.
> 
> 
> As a result of checking through 'checkpatch.pl <http://checkpatch.pl>', there was only one coding style problem in 'erofs / inode.c' file.
> 
> 
> I will check for other files and send the patch file soon.

Yes, if you confirm that this is the only one place, I think this patch is ok for me personally. :)

Thanks,
Gao Xiang

> 
> 
> Thanks,
> 
> Sungkyung Kim 
> 
> 
> 2018년 12월 13일 (목) 오전 10:51, Gao Xiang <gaoxiang25@huawei.com <mailto:gaoxiang25@huawei.com>>님이 작성:
> 
>     Hi Sungkyung,
> 
>     On 2018/12/12 23:50, Sungkyung Kim wrote:
>     > Fix a warning from checkpathch.pl <http://checkpathch.pl>: 'Missing a blank line after
>     > declarations'
>     >
>     > Signed-off-by: Sungkyung Kim <jotun9935@gmail.com <mailto:jotun9935@gmail.com>>
>     > ---
>     >  drivers/staging/erofs/inode.c | 1 +
>     >  1 file changed, 1 insertion(+)
>     >
>     > diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
>     > index 04c61a9d7b76..82b6ad5badff 100644
>     > --- a/drivers/staging/erofs/inode.c
>     > +++ b/drivers/staging/erofs/inode.c
>     > @@ -278,6 +278,7 @@ struct inode *erofs_iget(struct super_block *sb,
>     >       if (inode->i_state & I_NEW) {
>     >               int err;
>     >               struct erofs_vnode *vi = EROFS_V(inode);
>     > +
> 
>     Thanks for your patch, is there a only one 'Missing a blank line after declarations' in erofs?
> 
>     If not, could you have time check the other files? That is my personal thought, and
>     I cc-ed the staging mailing list as well.
> 
>     Thanks,
>     Gao Xiang
> 
>     >               vi->nid = nid;
>     > 
>     >               err = fill_inode(inode, isdir);
>     >
> 

Re: [PATCH] staging: erofs: Add a blank line after declarations

[Chao Yu]

On 2018/12/13 9:51, Gao Xiang wrote:
> Hi Sungkyung,
> 
> On 2018/12/12 23:50, Sungkyung Kim wrote:
>> Fix a warning from checkpathch.pl: 'Missing a blank line after
>> declarations'
>>
>> Signed-off-by: Sungkyung Kim <jotun9935@gmail.com>
>> ---
>>  drivers/staging/erofs/inode.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
>> index 04c61a9d7b76..82b6ad5badff 100644
>> --- a/drivers/staging/erofs/inode.c
>> +++ b/drivers/staging/erofs/inode.c
>> @@ -278,6 +278,7 @@ struct inode *erofs_iget(struct super_block *sb,
>>  	if (inode->i_state & I_NEW) {
>>  		int err;
>>  		struct erofs_vnode *vi = EROFS_V(inode);
>> +
> 
> Thanks for your patch, is there a only one 'Missing a blank line after declarations' in erofs?
> 
> If not, could you have time check the other files? That is my personal thought, and
> I cc-ed the staging mailing list as well.

Agreed, it needs to check all files, and fix similar coding style issues in
one patch.

Thanks,

> 
> Thanks,
> Gao Xiang
> 
>>  		vi->nid = nid;
>>  
>>  		err = fill_inode(inode, isdir);
>>
> 
> .
>