From: Joe Perches <joe@perches.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME
Date: Thu, 10 May 2018 19:12:57 -0700 [thread overview]
Message-ID: <8cbdd3e5d08c3faf3e7d10e19e8261f3222ce27c.camel@perches.com> (raw)
In-Reply-To: <18d24efb4d5dafae2360cb2103b366098311998a.camel@perches.com>
On Thu, 2018-05-10 at 18:57 -0700, Joe Perches wrote:
> On Fri, 2018-05-11 at 10:51 +0900, Sergey Senozhatsky wrote:
> > On (05/10/18 08:45), Joe Perches wrote:
> > > There are more than 1000 uses of #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > > Make that the default define so these uses can be removed later via script.
> > >
> > > Signed-off-by: Joe Perches <joe@perches.com>
> >
> > In general, the idea looks OK to me, so FWIW
> > Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> >
> > A quick question:
> >
> > - Would "can be removed later via script" be so trivial?
> > What about these guys?
> >
> > drivers/of/address.c:#define pr_fmt(fmt) "OF: " fmt
> > drivers/of/base.c:#define pr_fmt(fmt) "OF: " fmt
> > drivers/of/dynamic.c:#define pr_fmt(fmt) "OF: " fmt
> > drivers/of/fdt.c:#define pr_fmt(fmt) "OF: fdt: " fmt
> > drivers/of/fdt_address.c:#define pr_fmt(fmt) "OF: fdt: " fmt
> > drivers/of/irq.c:#define pr_fmt(fmt) "OF: " fmt
> > drivers/of/of_numa.c:#define pr_fmt(fmt) "OF: NUMA: " fmt
> > drivers/of/of_reserved_mem.c:#define pr_fmt(fmt) "OF: reserved mem: " fmt
> > drivers/of/overlay.c:#define pr_fmt(fmt) "OF: overlay: " fmt
> > drivers/of/platform.c:#define pr_fmt(fmt) "OF: " fmt
> > drivers/of/property.c:#define pr_fmt(fmt) "OF: " fmt
> > drivers/of/resolver.c:#define pr_fmt(fmt) "OF: resolver: " fmt
>
> What about them?
>
> All those defines above are non-generic as they are
> specified to start with "OF: " and then some optional
> extra bit.
>
> Why should these defines be updated or modified?
What would be good, and is something that I will
eventually work on, is to make the KBUILD_MODNAME ": "
use a singleton looked up and inserted by the printk
subsystem instead of stored with each format.
next prev parent reply other threads:[~2018-05-11 2:13 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 15:45 [PATCH 00/18] Convert default pr_fmt from empty to KBUILD_MODNAME Joe Perches
2018-05-10 15:45 ` [PATCH 01/18] kernel: Use pr_fmt Joe Perches
2018-05-10 16:14 ` Paul Moore
2018-05-10 19:05 ` Kees Cook
2018-05-13 19:17 ` Jessica Yu
2018-05-14 13:38 ` Masami Hiramatsu
2018-05-14 18:06 ` Paul E. McKenney
2018-05-14 18:59 ` Paul Moore
2018-05-10 15:45 ` [PATCH 02/18] lib: " Joe Perches
2018-05-10 15:45 ` [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME Joe Perches
2018-05-10 16:28 ` Steven Rostedt
2018-05-11 21:39 ` [PATCH] ring_buffer: Update logging to use single line output Joe Perches
2018-07-12 2:57 ` Steven Rostedt
2018-07-12 4:42 ` Joe Perches
2018-07-12 13:00 ` Steven Rostedt
2018-05-11 1:51 ` [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME Sergey Senozhatsky
2018-05-11 1:57 ` Joe Perches
2018-05-11 2:12 ` Joe Perches [this message]
2018-05-11 2:24 ` Sergey Senozhatsky
2018-05-11 2:23 ` Sergey Senozhatsky
2018-05-11 2:33 ` Joe Perches
2018-05-11 2:41 ` Sergey Senozhatsky
2018-05-11 2:57 ` Joe Perches
2018-05-18 8:42 ` Petr Mladek
2018-05-18 9:10 ` Joe Perches
2018-05-18 20:29 ` Andy Shevchenko
2018-05-19 2:05 ` Joe Perches
2018-05-19 18:27 ` Andy Shevchenko
2018-05-10 15:45 ` [PATCH 04/18] x86: Remove pr_fmt duplicate logging prefixes Joe Perches
2018-05-13 19:27 ` [tip:x86/cleanups] " tip-bot for Joe Perches
2018-05-17 18:27 ` Borislav Petkov
2018-05-17 18:43 ` Joe Perches
2018-05-17 19:14 ` Thomas Gleixner
2019-02-21 6:25 ` Bjorn Helgaas
2018-05-10 15:45 ` [PATCH 05/18] x86/mtrr: Rename main.c to mtrr.c and remove duplicate prefixes Joe Perches
2018-05-13 19:28 ` [tip:x86/cleanups] " tip-bot for Joe Perches
2018-05-10 15:45 ` [PATCH 06/18] net: Remove pr_fmt duplicate logging prefixes Joe Perches
2018-05-10 15:45 ` [PATCH 07/18] blk-mq: " Joe Perches
2018-05-10 15:45 ` [PATCH 08/18] random: " Joe Perches
2018-05-10 15:45 ` [PATCH 09/18] ptp: " Joe Perches
2018-05-10 19:35 ` Richard Cochran
2018-05-10 15:45 ` [PATCH 10/18] efifb: " Joe Perches
2018-05-10 15:45 ` [PATCH 11/18] proc: " Joe Perches
2018-05-10 15:45 ` [PATCH 12/18] uprobes: " Joe Perches
2018-05-10 15:45 ` [PATCH 13/18] printk: " Joe Perches
2018-05-11 1:54 ` Sergey Senozhatsky
2018-05-18 8:43 ` Petr Mladek
2018-05-10 15:45 ` [PATCH 14/18] lib/mpi: " Joe Perches
2018-05-10 15:45 ` [PATCH 15/18] security: " Joe Perches
2018-05-10 16:15 ` Paul Moore
2018-05-10 15:45 ` [PATCH 16/18] aoe: " Joe Perches
2018-05-10 15:45 ` [PATCH 17/18] security: encrypted-keys: " Joe Perches
2018-05-10 18:09 ` James Morris
2018-05-10 15:45 ` [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output Joe Perches
2018-05-14 20:29 ` Paul E. McKenney
2018-05-14 20:37 ` Andy Shevchenko
2018-05-14 21:08 ` Paul E. McKenney
2018-05-14 20:52 ` Randy Dunlap
2018-05-14 21:05 ` Paul E. McKenney
2018-05-14 21:41 ` Joe Perches
2018-05-14 22:24 ` Paul E. McKenney
2018-05-14 22:54 ` Joe Perches
2018-05-14 23:58 ` Paul E. McKenney
2018-05-15 0:23 ` Joe Perches
2018-05-15 0:32 ` Paul E. McKenney
2018-05-15 1:22 ` Joe Perches
2018-05-15 3:41 ` Paul E. McKenney
2018-05-15 19:28 ` Paul E. McKenney
2018-05-15 21:11 ` Joe Perches
2018-05-15 21:23 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cbdd3e5d08c3faf3e7d10e19e8261f3222ce27c.camel@perches.com \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).