* [PATCH v2] dt-bindings: display/bridge: sil,sii8620: Convert to YAML binding
@ 2021-10-06 15:04 AngeloGioacchino Del Regno
2021-10-06 20:06 ` [PATCH v2] dt-bindings: display/bridge: sil, sii8620: " Andrzej Hajda
2021-10-14 20:26 ` [PATCH v2] dt-bindings: display/bridge: sil,sii8620: " Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2021-10-06 15:04 UTC (permalink / raw)
To: robh+dt
Cc: airlied, daniel, a.hajda, dri-devel, devicetree, linux-kernel,
AngeloGioacchino Del Regno
Convert the Silicon Image SiI8620 HDMI/MHL bridge documentation to YAML.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../bindings/display/bridge/sil,sii8620.yaml | 93 +++++++++++++++++++
.../bindings/display/bridge/sil-sii8620.txt | 33 -------
2 files changed, 93 insertions(+), 33 deletions(-)
create mode 100644 Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml
delete mode 100644 Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt
diff --git a/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml b/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml
new file mode 100644
index 000000000000..5a38595b6687
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml
@@ -0,0 +1,93 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/bridge/sil,sii8620.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Silicon Image SiI8620 HDMI/MHL bridge
+
+maintainers:
+ - Andrzej Hajda <a.hajda@samsung.com>
+
+properties:
+ compatible:
+ const: sil,sii8620
+
+ reg:
+ description: I2C address of the bridge
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ clock-names:
+ const: xtal
+
+ cvcc10-supply:
+ description: Digital Core Supply Voltage, 1.0V
+
+ iovcc18-supply:
+ description: I/O voltage supply, 1.8V
+
+ interrupts:
+ maxItems: 1
+
+ reset-gpios:
+ description: GPIO connected to the reset pin.
+ maxItems: 1
+
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+
+ properties:
+ port@0:
+ $ref: /schemas/graph.yaml#/properties/port
+ description:
+ Video port for HDMI input
+
+ required:
+ - port@0
+
+required:
+ - compatible
+ - reg
+ - cvcc10-supply
+ - iovcc18-supply
+ - interrupts
+ - ports
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ i2c1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ bridge@39 {
+ compatible = "sil,sii8620";
+ reg = <0x39>;
+ cvcc10-supply = <&ldo36_reg>;
+ iovcc18-supply = <&ldo34_reg>;
+ interrupt-parent = <&gpf0>;
+ interrupts = <2 IRQ_TYPE_LEVEL_HIGH>;
+ reset-gpios = <&gpv7 0 GPIO_ACTIVE_HIGH>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ mhl_to_hdmi: endpoint {
+ remote-endpoint = <&hdmi_to_mhl>;
+ };
+ };
+ };
+ };
+ };
+
+...
diff --git a/Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt b/Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt
deleted file mode 100644
index b05052f7d62f..000000000000
--- a/Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt
+++ /dev/null
@@ -1,33 +0,0 @@
-Silicon Image SiI8620 HDMI/MHL bridge bindings
-
-Required properties:
- - compatible: "sil,sii8620"
- - reg: i2c address of the bridge
- - cvcc10-supply: Digital Core Supply Voltage (1.0V)
- - iovcc18-supply: I/O Supply Voltage (1.8V)
- - interrupts: interrupt specifier of INT pin
- - reset-gpios: gpio specifier of RESET pin
- - clocks, clock-names: specification and name of "xtal" clock
- - video interfaces: Device node can contain video interface port
- node for HDMI encoder according to [1].
-
-[1]: Documentation/devicetree/bindings/media/video-interfaces.txt
-
-Example:
- sii8620@39 {
- reg = <0x39>;
- compatible = "sil,sii8620";
- cvcc10-supply = <&ldo36_reg>;
- iovcc18-supply = <&ldo34_reg>;
- interrupt-parent = <&gpf0>;
- interrupts = <2 0>;
- reset-gpio = <&gpv7 0 0>;
- clocks = <&pmu_system_controller 0>;
- clock-names = "xtal";
-
- port {
- mhl_to_hdmi: endpoint {
- remote-endpoint = <&hdmi_to_mhl>;
- };
- };
- };
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: display/bridge: sil, sii8620: Convert to YAML binding
2021-10-06 15:04 [PATCH v2] dt-bindings: display/bridge: sil,sii8620: Convert to YAML binding AngeloGioacchino Del Regno
@ 2021-10-06 20:06 ` Andrzej Hajda
2021-10-14 20:26 ` [PATCH v2] dt-bindings: display/bridge: sil,sii8620: " Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Andrzej Hajda @ 2021-10-06 20:06 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt
Cc: airlied, daniel, a.hajda, dri-devel, devicetree, linux-kernel
On 06.10.2021 17:04, AngeloGioacchino Del Regno wrote:
> Convert the Silicon Image SiI8620 HDMI/MHL bridge documentation to YAML.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../bindings/display/bridge/sil,sii8620.yaml | 93 +++++++++++++++++++
> .../bindings/display/bridge/sil-sii8620.txt | 33 -------
> 2 files changed, 93 insertions(+), 33 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml
> delete mode 100644 Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml b/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml
> new file mode 100644
> index 000000000000..5a38595b6687
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml
> @@ -0,0 +1,93 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/bridge/sil,sii8620.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Silicon Image SiI8620 HDMI/MHL bridge
> +
> +maintainers:
> + - Andrzej Hajda <a.hajda@samsung.com>
> +
> +properties:
> + compatible:
> + const: sil,sii8620
> +
> + reg:
> + description: I2C address of the bridge
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + const: xtal
> +
> + cvcc10-supply:
> + description: Digital Core Supply Voltage, 1.0V
> +
> + iovcc18-supply:
> + description: I/O voltage supply, 1.8V
> +
> + interrupts:
> + maxItems: 1
> +
> + reset-gpios:
> + description: GPIO connected to the reset pin.
> + maxItems: 1
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/properties/port
> + description:
> + Video port for HDMI input
> +
> + required:
> + - port@0
> +
> +required:
> + - compatible
> + - reg
> + - cvcc10-supply
> + - iovcc18-supply
> + - interrupts
> + - ports
What about gpios and other missing props.
With that fixed you can add my r-b.
Regards
Andrzej
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + bridge@39 {
> + compatible = "sil,sii8620";
> + reg = <0x39>;
> + cvcc10-supply = <&ldo36_reg>;
> + iovcc18-supply = <&ldo34_reg>;
> + interrupt-parent = <&gpf0>;
> + interrupts = <2 IRQ_TYPE_LEVEL_HIGH>;
> + reset-gpios = <&gpv7 0 GPIO_ACTIVE_HIGH>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + mhl_to_hdmi: endpoint {
> + remote-endpoint = <&hdmi_to_mhl>;
> + };
> + };
> + };
> + };
> + };
> +
> +...
> diff --git a/Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt b/Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt
> deleted file mode 100644
> index b05052f7d62f..000000000000
> --- a/Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt
> +++ /dev/null
> @@ -1,33 +0,0 @@
> -Silicon Image SiI8620 HDMI/MHL bridge bindings
> -
> -Required properties:
> - - compatible: "sil,sii8620"
> - - reg: i2c address of the bridge
> - - cvcc10-supply: Digital Core Supply Voltage (1.0V)
> - - iovcc18-supply: I/O Supply Voltage (1.8V)
> - - interrupts: interrupt specifier of INT pin
> - - reset-gpios: gpio specifier of RESET pin
> - - clocks, clock-names: specification and name of "xtal" clock
> - - video interfaces: Device node can contain video interface port
> - node for HDMI encoder according to [1].
> -
> -[1]: Documentation/devicetree/bindings/media/video-interfaces.txt
> -
> -Example:
> - sii8620@39 {
> - reg = <0x39>;
> - compatible = "sil,sii8620";
> - cvcc10-supply = <&ldo36_reg>;
> - iovcc18-supply = <&ldo34_reg>;
> - interrupt-parent = <&gpf0>;
> - interrupts = <2 0>;
> - reset-gpio = <&gpv7 0 0>;
> - clocks = <&pmu_system_controller 0>;
> - clock-names = "xtal";
> -
> - port {
> - mhl_to_hdmi: endpoint {
> - remote-endpoint = <&hdmi_to_mhl>;
> - };
> - };
> - };
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: display/bridge: sil,sii8620: Convert to YAML binding
2021-10-06 15:04 [PATCH v2] dt-bindings: display/bridge: sil,sii8620: Convert to YAML binding AngeloGioacchino Del Regno
2021-10-06 20:06 ` [PATCH v2] dt-bindings: display/bridge: sil, sii8620: " Andrzej Hajda
@ 2021-10-14 20:26 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-10-14 20:26 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: airlied, daniel, a.hajda, dri-devel, devicetree, linux-kernel
On Wed, Oct 06, 2021 at 05:04:59PM +0200, AngeloGioacchino Del Regno wrote:
> Convert the Silicon Image SiI8620 HDMI/MHL bridge documentation to YAML.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../bindings/display/bridge/sil,sii8620.yaml | 93 +++++++++++++++++++
> .../bindings/display/bridge/sil-sii8620.txt | 33 -------
> 2 files changed, 93 insertions(+), 33 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml
> delete mode 100644 Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml b/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml
> new file mode 100644
> index 000000000000..5a38595b6687
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml
> @@ -0,0 +1,93 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/bridge/sil,sii8620.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Silicon Image SiI8620 HDMI/MHL bridge
> +
> +maintainers:
> + - Andrzej Hajda <a.hajda@samsung.com>
> +
> +properties:
> + compatible:
> + const: sil,sii8620
> +
> + reg:
> + description: I2C address of the bridge
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + const: xtal
> +
> + cvcc10-supply:
> + description: Digital Core Supply Voltage, 1.0V
> +
> + iovcc18-supply:
> + description: I/O voltage supply, 1.8V
> +
> + interrupts:
> + maxItems: 1
> +
> + reset-gpios:
> + description: GPIO connected to the reset pin.
> + maxItems: 1
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/properties/port
> + description:
> + Video port for HDMI input
No need for 'ports' with only one port. However, this *should* have an
output port for a connector, so I'm okay with this change. However,
don't add that now. Just note the addition of 'ports' in the commit msg.
> +
> + required:
> + - port@0
> +
> +required:
> + - compatible
> + - reg
> + - cvcc10-supply
> + - iovcc18-supply
> + - interrupts
> + - ports
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c1 {
i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + bridge@39 {
> + compatible = "sil,sii8620";
> + reg = <0x39>;
> + cvcc10-supply = <&ldo36_reg>;
> + iovcc18-supply = <&ldo34_reg>;
> + interrupt-parent = <&gpf0>;
> + interrupts = <2 IRQ_TYPE_LEVEL_HIGH>;
> + reset-gpios = <&gpv7 0 GPIO_ACTIVE_HIGH>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + mhl_to_hdmi: endpoint {
> + remote-endpoint = <&hdmi_to_mhl>;
> + };
> + };
> + };
> + };
> + };
> +
> +...
> diff --git a/Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt b/Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt
> deleted file mode 100644
> index b05052f7d62f..000000000000
> --- a/Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt
> +++ /dev/null
> @@ -1,33 +0,0 @@
> -Silicon Image SiI8620 HDMI/MHL bridge bindings
> -
> -Required properties:
> - - compatible: "sil,sii8620"
> - - reg: i2c address of the bridge
> - - cvcc10-supply: Digital Core Supply Voltage (1.0V)
> - - iovcc18-supply: I/O Supply Voltage (1.8V)
> - - interrupts: interrupt specifier of INT pin
> - - reset-gpios: gpio specifier of RESET pin
> - - clocks, clock-names: specification and name of "xtal" clock
> - - video interfaces: Device node can contain video interface port
> - node for HDMI encoder according to [1].
> -
> -[1]: Documentation/devicetree/bindings/media/video-interfaces.txt
> -
> -Example:
> - sii8620@39 {
> - reg = <0x39>;
> - compatible = "sil,sii8620";
> - cvcc10-supply = <&ldo36_reg>;
> - iovcc18-supply = <&ldo34_reg>;
> - interrupt-parent = <&gpf0>;
> - interrupts = <2 0>;
> - reset-gpio = <&gpv7 0 0>;
> - clocks = <&pmu_system_controller 0>;
> - clock-names = "xtal";
> -
> - port {
> - mhl_to_hdmi: endpoint {
> - remote-endpoint = <&hdmi_to_mhl>;
> - };
> - };
> - };
> --
> 2.33.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-14 20:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-06 15:04 [PATCH v2] dt-bindings: display/bridge: sil,sii8620: Convert to YAML binding AngeloGioacchino Del Regno
2021-10-06 20:06 ` [PATCH v2] dt-bindings: display/bridge: sil, sii8620: " Andrzej Hajda
2021-10-14 20:26 ` [PATCH v2] dt-bindings: display/bridge: sil,sii8620: " Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).