From: Thor Thayer <thor.thayer@linux.intel.com>
To: "Ooi, Joyce" <joyce.ooi@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Dalon Westergreen <dalon.westergreen@linux.intel.com>,
Tan Ley Foon <ley.foon.tan@intel.com>,
See Chin Liang <chin.liang.see@intel.com>,
Dinh Nguyen <dinh.nguyen@intel.com>,
Dalon Westergreen <dalon.westergreen@intel.com>
Subject: Re: [PATCH v4 04/10] net: eth: altera: add optional function to start tx dma
Date: Thu, 23 Jul 2020 11:35:04 -0500 [thread overview]
Message-ID: <8d16280c-af08-ac70-dcee-2646ccefc820@linux.intel.com> (raw)
In-Reply-To: <20200708072401.169150-5-joyce.ooi@intel.com>
On 7/8/20 2:23 AM, Ooi, Joyce wrote:
> From: Dalon Westergreen <dalon.westergreen@intel.com>
>
> Allow for optional start up of tx dma if the start_txdma
> function is defined in altera_dmaops.
>
> Signed-off-by: Dalon Westergreen <dalon.westergreen@intel.com>
> Signed-off-by: Joyce Ooi <joyce.ooi@intel.com>
> ---
> v2: no change
> v3: no change
> v4: no change
> ---
> drivers/net/ethernet/altera/altera_tse.h | 1 +
> drivers/net/ethernet/altera/altera_tse_main.c | 5 +++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/net/ethernet/altera/altera_tse.h b/drivers/net/ethernet/altera/altera_tse.h
> index 7d0c98fc103e..26c5541fda27 100644
> --- a/drivers/net/ethernet/altera/altera_tse.h
> +++ b/drivers/net/ethernet/altera/altera_tse.h
> @@ -401,6 +401,7 @@ struct altera_dmaops {
> int (*init_dma)(struct altera_tse_private *priv);
> void (*uninit_dma)(struct altera_tse_private *priv);
> void (*start_rxdma)(struct altera_tse_private *priv);
> + void (*start_txdma)(struct altera_tse_private *priv);
> };
>
> /* This structure is private to each device.
> diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
> index a3749ffdcac9..0a724e4d2c8c 100644
> --- a/drivers/net/ethernet/altera/altera_tse_main.c
> +++ b/drivers/net/ethernet/altera/altera_tse_main.c
> @@ -1244,6 +1244,9 @@ static int tse_open(struct net_device *dev)
>
> priv->dmaops->start_rxdma(priv);
>
> + if (priv->dmaops->start_txdma)
> + priv->dmaops->start_txdma(priv);
> +
> /* Start MAC Rx/Tx */
> spin_lock(&priv->mac_cfg_lock);
> tse_set_mac(priv, true);
> @@ -1646,6 +1649,7 @@ static const struct altera_dmaops altera_dtype_sgdma = {
> .init_dma = sgdma_initialize,
> .uninit_dma = sgdma_uninitialize,
> .start_rxdma = sgdma_start_rxdma,
> + .start_txdma = NULL,
> };
>
> static const struct altera_dmaops altera_dtype_msgdma = {
> @@ -1665,6 +1669,7 @@ static const struct altera_dmaops altera_dtype_msgdma = {
> .init_dma = msgdma_initialize,
> .uninit_dma = msgdma_uninitialize,
> .start_rxdma = msgdma_start_rxdma,
> + .start_txdma = NULL,
> };
>
> static const struct of_device_id altera_tse_ids[] = {
>
Reviewed-by: Thor Thayer <thor.thayer@linux.intel.com>
next prev parent reply other threads:[~2020-07-23 16:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 7:23 [PATCH v4 00/10] net: eth: altera: tse: Add PTP and mSGDMA prefetcher Ooi, Joyce
2020-07-08 7:23 ` [PATCH v4 01/10] net: eth: altera: tse_start_xmit ignores tx_buffer call response Ooi, Joyce
2020-07-23 16:32 ` Thor Thayer
2020-07-08 7:23 ` [PATCH v4 02/10] net: eth: altera: set rx and tx ring size before init_dma call Ooi, Joyce
2020-07-23 16:33 ` Thor Thayer
2020-07-08 7:23 ` [PATCH v4 03/10] net: eth: altera: fix altera_dmaops declaration Ooi, Joyce
2020-07-23 16:33 ` Thor Thayer
2020-07-08 7:23 ` [PATCH v4 04/10] net: eth: altera: add optional function to start tx dma Ooi, Joyce
2020-07-23 16:35 ` Thor Thayer [this message]
2020-07-08 7:23 ` [PATCH v4 05/10] net: eth: altera: Move common functions to altera_utils Ooi, Joyce
2020-07-23 16:39 ` Thor Thayer
2020-07-08 7:23 ` [PATCH v4 06/10] net: eth: altera: Add missing identifier names to function declarations Ooi, Joyce
2020-07-23 16:40 ` Thor Thayer
2020-07-08 7:23 ` [PATCH v4 07/10] net: eth: altera: change tx functions to type netdev_tx_t Ooi, Joyce
2020-07-23 16:41 ` Thor Thayer
2020-07-08 7:23 ` [PATCH v4 08/10] net: eth: altera: add support for ptp and timestamping Ooi, Joyce
2020-07-09 11:31 ` Richard Cochran
2020-07-15 3:48 ` Ooi, Joyce
2020-07-23 17:05 ` Thor Thayer
2020-07-08 7:24 ` [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher Ooi, Joyce
2020-07-08 17:33 ` David Miller
2020-07-14 14:36 ` Ooi, Joyce
2020-07-08 21:49 ` Jakub Kicinski
2020-07-14 14:35 ` Ooi, Joyce
2020-07-14 15:55 ` Jakub Kicinski
2020-07-14 15:58 ` Westergreen, Dalon
2020-07-14 16:29 ` Jakub Kicinski
2020-07-14 18:51 ` Westergreen, Dalon
2020-07-14 19:13 ` Jakub Kicinski
2020-07-14 20:23 ` David Miller
2020-07-14 23:25 ` Westergreen, Dalon
2020-07-08 7:24 ` [PATCH v4 10/10] net: eth: altera: update devicetree bindings documentation Ooi, Joyce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d16280c-af08-ac70-dcee-2646ccefc820@linux.intel.com \
--to=thor.thayer@linux.intel.com \
--cc=chin.liang.see@intel.com \
--cc=dalon.westergreen@intel.com \
--cc=dalon.westergreen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dinh.nguyen@intel.com \
--cc=joyce.ooi@intel.com \
--cc=kuba@kernel.org \
--cc=ley.foon.tan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).