From: "Ooi, Joyce" <joyce.ooi@intel.com>
To: David Miller <davem@davemloft.net>
Cc: "thor.thayer@linux.intel.com" <thor.thayer@linux.intel.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dalon.westergreen@linux.intel.com"
<dalon.westergreen@linux.intel.com>,
"Tan, Ley Foon" <ley.foon.tan@intel.com>,
"See, Chin Liang" <chin.liang.see@intel.com>,
"Nguyen, Dinh" <dinh.nguyen@intel.com>,
"Westergreen, Dalon" <dalon.westergreen@intel.com>
Subject: RE: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher
Date: Tue, 14 Jul 2020 14:36:32 +0000 [thread overview]
Message-ID: <CY4PR11MB1253B09441D400910C611807F2610@CY4PR11MB1253.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200708.103354.707974548958033107.davem@davemloft.net>
> -----Original Message-----
> From: David Miller <davem@davemloft.net>
> Sent: Thursday, July 9, 2020 1:34 AM
> To: Ooi, Joyce <joyce.ooi@intel.com>
> Cc: thor.thayer@linux.intel.com; kuba@kernel.org; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org; dalon.westergreen@linux.intel.com; Tan, Ley
> Foon <ley.foon.tan@intel.com>; See, Chin Liang <chin.liang.see@intel.com>;
> Nguyen, Dinh <dinh.nguyen@intel.com>; Westergreen, Dalon
> <dalon.westergreen@intel.com>
> Subject: Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher
>
> From: "Ooi, Joyce" <joyce.ooi@intel.com>
> Date: Wed, 8 Jul 2020 15:24:00 +0800
>
> > +int msgdma_pref_initialize(struct altera_tse_private *priv) {
> > + int i;
> > + struct msgdma_pref_extended_desc *rx_descs;
> > + struct msgdma_pref_extended_desc *tx_descs;
> > + dma_addr_t rx_descsphys;
> > + dma_addr_t tx_descsphys;
>
> Reverse christmas tree please.
>
> > +netdev_tx_t msgdma_pref_tx_buffer(struct altera_tse_private *priv,
> > + struct tse_buffer *buffer)
> > +{
> > + u32 desc_entry = priv->tx_prod % (priv->tx_ring_size * 2);
> > + struct msgdma_pref_extended_desc *tx_descs = priv->pref_txdesc;
>
> Likewise.
>
> > +u32 msgdma_pref_tx_completions(struct altera_tse_private *priv) {
> > + u32 control;
> > + u32 ready = 0;
> > + u32 cons = priv->tx_cons;
> > + u32 desc_ringsize = priv->tx_ring_size * 2;
> > + u32 ringsize = priv->tx_ring_size;
> > + u64 ns = 0;
> > + struct msgdma_pref_extended_desc *cur;
> > + struct tse_buffer *tx_buff;
> > + struct skb_shared_hwtstamps shhwtstamp;
> > + int i;
>
> Likewise.
>
> > +u32 msgdma_pref_rx_status(struct altera_tse_private *priv) {
> > + u32 rxstatus = 0;
> > + u32 pktlength;
> > + u32 pktstatus;
> > + u64 ns = 0;
> > + u32 entry = priv->rx_cons % priv->rx_ring_size;
> > + u32 desc_entry = priv->rx_prod % (priv->rx_ring_size * 2);
> > + struct msgdma_pref_extended_desc *rx_descs = priv->pref_rxdesc;
> > + struct skb_shared_hwtstamps *shhwtstamp = NULL;
> > + struct tse_buffer *rx_buff = priv->rx_ring;
>
> Likewise.
>
> > + } else if (priv->dmaops &&
> > + priv->dmaops->altera_dtype ==
> > + ALTERA_DTYPE_MSGDMA_PREF) {
>
> This is not properly formatted.
>
> On a multi-line conditional, every subsequent line after the first should align
> with the first column after the openning parenthesis of the first line.
Noted, will make the changes.
next prev parent reply other threads:[~2020-07-14 14:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 7:23 [PATCH v4 00/10] net: eth: altera: tse: Add PTP and mSGDMA prefetcher Ooi, Joyce
2020-07-08 7:23 ` [PATCH v4 01/10] net: eth: altera: tse_start_xmit ignores tx_buffer call response Ooi, Joyce
2020-07-23 16:32 ` Thor Thayer
2020-07-08 7:23 ` [PATCH v4 02/10] net: eth: altera: set rx and tx ring size before init_dma call Ooi, Joyce
2020-07-23 16:33 ` Thor Thayer
2020-07-08 7:23 ` [PATCH v4 03/10] net: eth: altera: fix altera_dmaops declaration Ooi, Joyce
2020-07-23 16:33 ` Thor Thayer
2020-07-08 7:23 ` [PATCH v4 04/10] net: eth: altera: add optional function to start tx dma Ooi, Joyce
2020-07-23 16:35 ` Thor Thayer
2020-07-08 7:23 ` [PATCH v4 05/10] net: eth: altera: Move common functions to altera_utils Ooi, Joyce
2020-07-23 16:39 ` Thor Thayer
2020-07-08 7:23 ` [PATCH v4 06/10] net: eth: altera: Add missing identifier names to function declarations Ooi, Joyce
2020-07-23 16:40 ` Thor Thayer
2020-07-08 7:23 ` [PATCH v4 07/10] net: eth: altera: change tx functions to type netdev_tx_t Ooi, Joyce
2020-07-23 16:41 ` Thor Thayer
2020-07-08 7:23 ` [PATCH v4 08/10] net: eth: altera: add support for ptp and timestamping Ooi, Joyce
2020-07-09 11:31 ` Richard Cochran
2020-07-15 3:48 ` Ooi, Joyce
2020-07-23 17:05 ` Thor Thayer
2020-07-08 7:24 ` [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher Ooi, Joyce
2020-07-08 17:33 ` David Miller
2020-07-14 14:36 ` Ooi, Joyce [this message]
2020-07-08 21:49 ` Jakub Kicinski
2020-07-14 14:35 ` Ooi, Joyce
2020-07-14 15:55 ` Jakub Kicinski
2020-07-14 15:58 ` Westergreen, Dalon
2020-07-14 16:29 ` Jakub Kicinski
2020-07-14 18:51 ` Westergreen, Dalon
2020-07-14 19:13 ` Jakub Kicinski
2020-07-14 20:23 ` David Miller
2020-07-14 23:25 ` Westergreen, Dalon
2020-07-08 7:24 ` [PATCH v4 10/10] net: eth: altera: update devicetree bindings documentation Ooi, Joyce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR11MB1253B09441D400910C611807F2610@CY4PR11MB1253.namprd11.prod.outlook.com \
--to=joyce.ooi@intel.com \
--cc=chin.liang.see@intel.com \
--cc=dalon.westergreen@intel.com \
--cc=dalon.westergreen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dinh.nguyen@intel.com \
--cc=kuba@kernel.org \
--cc=ley.foon.tan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=thor.thayer@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).