* [PATCH] tpm: ibmvtpm: fix error return code in tpm_ibmvtpm_probe()
@ 2020-11-24 13:52 Wang Hai
2020-11-24 14:28 ` Stefan Berger
2020-11-26 3:35 ` Jarkko Sakkinen
0 siblings, 2 replies; 4+ messages in thread
From: Wang Hai @ 2020-11-24 13:52 UTC (permalink / raw)
To: mpe, benh, paulus, peterhuewe, jarkko, jgg, stefanb, nayna
Cc: linuxppc-dev, linux-integrity, linux-kernel
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
drivers/char/tpm/tpm_ibmvtpm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
index 994385bf37c0..813eb2cac0ce 100644
--- a/drivers/char/tpm/tpm_ibmvtpm.c
+++ b/drivers/char/tpm/tpm_ibmvtpm.c
@@ -687,6 +687,7 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
ibmvtpm->rtce_buf != NULL,
HZ)) {
dev_err(dev, "CRQ response timed out\n");
+ rc = -ETIMEDOUT;
goto init_irq_cleanup;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tpm: ibmvtpm: fix error return code in tpm_ibmvtpm_probe()
2020-11-24 13:52 [PATCH] tpm: ibmvtpm: fix error return code in tpm_ibmvtpm_probe() Wang Hai
@ 2020-11-24 14:28 ` Stefan Berger
2020-11-26 3:35 ` Jarkko Sakkinen
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Berger @ 2020-11-24 14:28 UTC (permalink / raw)
To: Wang Hai, mpe, benh, paulus, peterhuewe, jarkko, jgg, nayna
Cc: linuxppc-dev, linux-integrity, linux-kernel
On 11/24/20 8:52 AM, Wang Hai wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
> ---
> drivers/char/tpm/tpm_ibmvtpm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
> index 994385bf37c0..813eb2cac0ce 100644
> --- a/drivers/char/tpm/tpm_ibmvtpm.c
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -687,6 +687,7 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
> ibmvtpm->rtce_buf != NULL,
> HZ)) {
> dev_err(dev, "CRQ response timed out\n");
> + rc = -ETIMEDOUT;
> goto init_irq_cleanup;
> }
>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tpm: ibmvtpm: fix error return code in tpm_ibmvtpm_probe()
2020-11-24 13:52 [PATCH] tpm: ibmvtpm: fix error return code in tpm_ibmvtpm_probe() Wang Hai
2020-11-24 14:28 ` Stefan Berger
@ 2020-11-26 3:35 ` Jarkko Sakkinen
2020-12-22 13:36 ` Stefan Berger
1 sibling, 1 reply; 4+ messages in thread
From: Jarkko Sakkinen @ 2020-11-26 3:35 UTC (permalink / raw)
To: Wang Hai, mpe, benh, paulus, peterhuewe, jgg, stefanb, nayna
Cc: linuxppc-dev, linux-integrity, linux-kernel
On Tue, 2020-11-24 at 21:52 +0800, Wang Hai wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before
> proceeding")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
Provide a reasoning for -ETIMEOUT in the commit message.
/Jarkko
> ---
> drivers/char/tpm/tpm_ibmvtpm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c
> b/drivers/char/tpm/tpm_ibmvtpm.c
> index 994385bf37c0..813eb2cac0ce 100644
> --- a/drivers/char/tpm/tpm_ibmvtpm.c
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -687,6 +687,7 @@ static int tpm_ibmvtpm_probe(struct vio_dev
> *vio_dev,
> ibmvtpm->rtce_buf != NULL,
> HZ)) {
> dev_err(dev, "CRQ response timed out\n");
> + rc = -ETIMEDOUT;
> goto init_irq_cleanup;
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tpm: ibmvtpm: fix error return code in tpm_ibmvtpm_probe()
2020-11-26 3:35 ` Jarkko Sakkinen
@ 2020-12-22 13:36 ` Stefan Berger
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Berger @ 2020-12-22 13:36 UTC (permalink / raw)
To: Jarkko Sakkinen, Wang Hai, mpe, benh, paulus, peterhuewe, jgg, nayna
Cc: linuxppc-dev, linux-integrity, linux-kernel
On 11/25/20 10:35 PM, Jarkko Sakkinen wrote:
> On Tue, 2020-11-24 at 21:52 +0800, Wang Hai wrote:
>> Fix to return a negative error code from the error handling
>> case instead of 0, as done elsewhere in this function.
>>
>> Fixes: d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before
>> proceeding")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Wang Hai <wanghai38@huawei.com>
> Provide a reasoning for -ETIMEOUT in the commit message.
>
> /Jarkko
Was this patch ever applied? I don't seem to find the infradead git tree ...
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-22 13:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-24 13:52 [PATCH] tpm: ibmvtpm: fix error return code in tpm_ibmvtpm_probe() Wang Hai
2020-11-24 14:28 ` Stefan Berger
2020-11-26 3:35 ` Jarkko Sakkinen
2020-12-22 13:36 ` Stefan Berger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).