linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ACPICA: add missing macro ACPI_FUNCTION_TRACE() for ns_repair_HID()
@ 2022-10-25 11:36 Xiongfeng Wang
  2022-10-25 12:38 ` Sudeep Holla
  0 siblings, 1 reply; 3+ messages in thread
From: Xiongfeng Wang @ 2022-10-25 11:36 UTC (permalink / raw)
  To: robert.moore, rafael.j.wysocki, lenb
  Cc: linux-acpi, devel, linux-kernel, wangxiongfeng2, liwei391

The following commit add function tracing macros for the namespace repair
mechanism.

  commit 0766efdf9a9d24eaefe260c787f49af225018b16
  ACPICA: Add function trace macros to improve debugging

But it missed the trace macro for the entry of ns_repair_HID(). Let's
add it.

Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
---
 drivers/acpi/acpica/nsrepair2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/acpica/nsrepair2.c b/drivers/acpi/acpica/nsrepair2.c
index dd533c887e3a..957d7eb4861f 100644
--- a/drivers/acpi/acpica/nsrepair2.c
+++ b/drivers/acpi/acpica/nsrepair2.c
@@ -499,7 +499,7 @@ acpi_ns_repair_HID(struct acpi_evaluate_info *info,
 	char *source;
 	char *dest;
 
-	ACPI_FUNCTION_NAME(ns_repair_HID);
+	ACPI_FUNCTION_TRACE(ns_repair_HID);
 
 	/* We only care about string _HID objects (not integers) */
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ACPICA: add missing macro ACPI_FUNCTION_TRACE() for ns_repair_HID()
  2022-10-25 11:36 [PATCH] ACPICA: add missing macro ACPI_FUNCTION_TRACE() for ns_repair_HID() Xiongfeng Wang
@ 2022-10-25 12:38 ` Sudeep Holla
  2022-10-26  1:08   ` Xiongfeng Wang
  0 siblings, 1 reply; 3+ messages in thread
From: Sudeep Holla @ 2022-10-25 12:38 UTC (permalink / raw)
  To: Xiongfeng Wang
  Cc: robert.moore, rafael.j.wysocki, lenb, linux-acpi, devel,
	linux-kernel, liwei391

Hi Xiongfeng,

On Tue, Oct 25, 2022 at 07:36:43PM +0800, Xiongfeng Wang wrote:
> The following commit add function tracing macros for the namespace repair
> mechanism.
> 
>   commit 0766efdf9a9d24eaefe260c787f49af225018b16
>   ACPICA: Add function trace macros to improve debugging
> 
> But it missed the trace macro for the entry of ns_repair_HID(). Let's
> add it.
>

Generally all ACPICA changes need to be submitted to the upstream project
via GitHub at https://github.com/acpica/acpica. It will be imported to the
Linux project from there.

-- 
Regards,
Sudeep

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ACPICA: add missing macro ACPI_FUNCTION_TRACE() for ns_repair_HID()
  2022-10-25 12:38 ` Sudeep Holla
@ 2022-10-26  1:08   ` Xiongfeng Wang
  0 siblings, 0 replies; 3+ messages in thread
From: Xiongfeng Wang @ 2022-10-26  1:08 UTC (permalink / raw)
  To: Sudeep Holla
  Cc: robert.moore, rafael.j.wysocki, lenb, linux-acpi, devel,
	linux-kernel, liwei391

Hi Sudeep,

On 2022/10/25 20:38, Sudeep Holla wrote:
> Hi Xiongfeng,
> 
> On Tue, Oct 25, 2022 at 07:36:43PM +0800, Xiongfeng Wang wrote:
>> The following commit add function tracing macros for the namespace repair
>> mechanism.
>>
>>   commit 0766efdf9a9d24eaefe260c787f49af225018b16
>>   ACPICA: Add function trace macros to improve debugging
>>
>> But it missed the trace macro for the entry of ns_repair_HID(). Let's
>> add it.
>>
> 
> Generally all ACPICA changes need to be submitted to the upstream project
> via GitHub at https://github.com/acpica/acpica. It will be imported to the
> Linux project from there.

Thanks for your reply! I will submit it the ACPICA project on GitHub.

Thanks,
Xiongfeng

> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-10-26  1:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-25 11:36 [PATCH] ACPICA: add missing macro ACPI_FUNCTION_TRACE() for ns_repair_HID() Xiongfeng Wang
2022-10-25 12:38 ` Sudeep Holla
2022-10-26  1:08   ` Xiongfeng Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).