From: Andrej Picej <andrej.picej@norik.com>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
Support Opensource <Support.Opensource@diasemi.com>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>
Cc: "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-imx@nxp.com" <linux-imx@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 2/4] watchdog: da9062: reset board on watchdog timeout
Date: Thu, 2 Dec 2021 09:31:16 +0100 [thread overview]
Message-ID: <8de702cf-3454-44be-d522-6af3515079a3@norik.com> (raw)
In-Reply-To: <DB9PR10MB4652EF562CD20FB72FDBD71880689@DB9PR10MB4652.EURPRD10.PROD.OUTLOOK.COM>
>
> Personally I'd stick this code in the probe(). The value won't change once it's
> set, and that seems the more logical place for it in my opinion.
>
I think that's a good idea and I don't have a reason why we shouldn't do
that.
Will send the next version of the patch series with this change.
Thanks for review.
BR,
Andrej
next prev parent reply other threads:[~2021-12-02 8:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 8:15 [PATCH v3 1/4] mfd: da9062: make register CONFIG_I writable Andrej Picej
2021-12-01 8:15 ` [PATCH v3 2/4] watchdog: da9062: reset board on watchdog timeout Andrej Picej
2021-12-01 20:05 ` Adam Thomson
2021-12-02 8:31 ` Andrej Picej [this message]
2021-12-01 21:26 ` Guenter Roeck
2021-12-02 8:34 ` Andrej Picej
[not found] ` <13e0b9047f114722a0b4ebb4c1d24f2b@dh-electronics.com>
2021-12-02 7:43 ` Andrej Picej
2021-12-02 12:12 ` Adam Thomson
2021-12-01 8:15 ` [PATCH v3 3/4] dt-bindings: watchdog: da9062: add watchdog timeout mode Andrej Picej
2021-12-01 8:15 ` [PATCH v3 4/4] ARM: dts: imx6: phycore-som: set watchdog timeout mode to shutdown Andrej Picej
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8de702cf-3454-44be-d522-6af3515079a3@norik.com \
--to=andrej.picej@norik.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).