* [PATCH v1] scsi: lpfc: Add auto select on IRQ_POLL
@ 2021-01-26 0:05 Tong Zhang
2021-01-26 13:25 ` James Smart
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tong Zhang @ 2021-01-26 0:05 UTC (permalink / raw)
To: James E.J. Bottomley, Martin K. Petersen, linux-scsi, linux-kernel
Cc: ztong0001
lpfc depends on irq_poll library, but it is not selected automatically.
When irq_poll is not selected, compiling it can run into following error
ERROR: modpost: "irq_poll_init" [drivers/scsi/lpfc/lpfc.ko] undefined!
ERROR: modpost: "irq_poll_sched" [drivers/scsi/lpfc/lpfc.ko] undefined!
ERROR: modpost: "irq_poll_complete" [drivers/scsi/lpfc/lpfc.ko] undefined!
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
---
drivers/scsi/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 701b61ec76ee..c79ac0731b13 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -1159,6 +1159,7 @@ config SCSI_LPFC
depends on NVME_TARGET_FC || NVME_TARGET_FC=n
depends on NVME_FC || NVME_FC=n
select CRC_T10DIF
+ select IRQ_POLL
help
This lpfc driver supports the Emulex LightPulse
Family of Fibre Channel PCI host adapters.
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] scsi: lpfc: Add auto select on IRQ_POLL
2021-01-26 0:05 [PATCH v1] scsi: lpfc: Add auto select on IRQ_POLL Tong Zhang
@ 2021-01-26 13:25 ` James Smart
2021-01-27 3:12 ` Martin K. Petersen
2021-01-29 19:01 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: James Smart @ 2021-01-26 13:25 UTC (permalink / raw)
To: Tong Zhang, James E.J. Bottomley, Martin K. Petersen, linux-scsi,
linux-kernel
On 1/25/2021 4:05 PM, Tong Zhang wrote:
> lpfc depends on irq_poll library, but it is not selected automatically.
> When irq_poll is not selected, compiling it can run into following error
>
> ERROR: modpost: "irq_poll_init" [drivers/scsi/lpfc/lpfc.ko] undefined!
> ERROR: modpost: "irq_poll_sched" [drivers/scsi/lpfc/lpfc.ko] undefined!
> ERROR: modpost: "irq_poll_complete" [drivers/scsi/lpfc/lpfc.ko] undefined!
>
> Signed-off-by: Tong Zhang <ztong0001@gmail.com>
> ---
> drivers/scsi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 701b61ec76ee..c79ac0731b13 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -1159,6 +1159,7 @@ config SCSI_LPFC
> depends on NVME_TARGET_FC || NVME_TARGET_FC=n
> depends on NVME_FC || NVME_FC=n
> select CRC_T10DIF
> + select IRQ_POLL
> help
> This lpfc driver supports the Emulex LightPulse
> Family of Fibre Channel PCI host adapters.
Reviewed-by: James Smart <jsmart2021@gmail.com>
-- james
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] scsi: lpfc: Add auto select on IRQ_POLL
2021-01-26 0:05 [PATCH v1] scsi: lpfc: Add auto select on IRQ_POLL Tong Zhang
2021-01-26 13:25 ` James Smart
@ 2021-01-27 3:12 ` Martin K. Petersen
2021-01-29 19:01 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2021-01-27 3:12 UTC (permalink / raw)
To: Tong Zhang
Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi, linux-kernel
Tong,
> lpfc depends on irq_poll library, but it is not selected
> automatically. When irq_poll is not selected, compiling it can run
> into following error
Applied to 5.12/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] scsi: lpfc: Add auto select on IRQ_POLL
2021-01-26 0:05 [PATCH v1] scsi: lpfc: Add auto select on IRQ_POLL Tong Zhang
2021-01-26 13:25 ` James Smart
2021-01-27 3:12 ` Martin K. Petersen
@ 2021-01-29 19:01 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2021-01-29 19:01 UTC (permalink / raw)
To: James E.J. Bottomley, linux-kernel, Tong Zhang, linux-scsi
Cc: Martin K . Petersen
On Mon, 25 Jan 2021 19:05:54 -0500, Tong Zhang wrote:
> lpfc depends on irq_poll library, but it is not selected automatically.
> When irq_poll is not selected, compiling it can run into following error
>
> ERROR: modpost: "irq_poll_init" [drivers/scsi/lpfc/lpfc.ko] undefined!
> ERROR: modpost: "irq_poll_sched" [drivers/scsi/lpfc/lpfc.ko] undefined!
> ERROR: modpost: "irq_poll_complete" [drivers/scsi/lpfc/lpfc.ko] undefined!
Applied to 5.12/scsi-queue, thanks!
[1/1] scsi: lpfc: Add auto select on IRQ_POLL
https://git.kernel.org/mkp/scsi/c/fad0a16130b6
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-29 19:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-26 0:05 [PATCH v1] scsi: lpfc: Add auto select on IRQ_POLL Tong Zhang
2021-01-26 13:25 ` James Smart
2021-01-27 3:12 ` Martin K. Petersen
2021-01-29 19:01 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).