* [PATCH] staging: erofs: drop unneeded -Wall addition
@ 2019-05-15 4:31 Masahiro Yamada
2019-05-15 5:18 ` Gao Xiang
2019-05-15 6:52 ` Chao Yu
0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2019-05-15 4:31 UTC (permalink / raw)
To: Gao Xiang, Chao Yu, linux-erofs, Greg KH, devel
Cc: Masahiro Yamada, linux-kernel
The top level Makefile adds -Wall globally:
KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \
I see two "-Wall" added for compiling objects in drivers/staging/erofs/.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/staging/erofs/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/erofs/Makefile b/drivers/staging/erofs/Makefile
index 38ab344a285e..a34248a2a16a 100644
--- a/drivers/staging/erofs/Makefile
+++ b/drivers/staging/erofs/Makefile
@@ -2,7 +2,7 @@
EROFS_VERSION = "1.0pre1"
-ccflags-y += -Wall -DEROFS_VERSION=\"$(EROFS_VERSION)\"
+ccflags-y += -DEROFS_VERSION=\"$(EROFS_VERSION)\"
obj-$(CONFIG_EROFS_FS) += erofs.o
# staging requirement: to be self-contained in its own directory
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: erofs: drop unneeded -Wall addition
2019-05-15 4:31 [PATCH] staging: erofs: drop unneeded -Wall addition Masahiro Yamada
@ 2019-05-15 5:18 ` Gao Xiang
2019-05-15 6:52 ` Chao Yu
1 sibling, 0 replies; 3+ messages in thread
From: Gao Xiang @ 2019-05-15 5:18 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Chao Yu, linux-erofs, Greg KH, devel, linux-kernel, Miao Xie
On 2019/5/15 12:31, Masahiro Yamada wrote:
> The top level Makefile adds -Wall globally:
>
> KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \
>
> I see two "-Wall" added for compiling objects in drivers/staging/erofs/.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Looks good to me and sorry about adding this flag...
Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
Thanks,
Gao Xiang
> ---
>
> drivers/staging/erofs/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/erofs/Makefile b/drivers/staging/erofs/Makefile
> index 38ab344a285e..a34248a2a16a 100644
> --- a/drivers/staging/erofs/Makefile
> +++ b/drivers/staging/erofs/Makefile
> @@ -2,7 +2,7 @@
>
> EROFS_VERSION = "1.0pre1"
>
> -ccflags-y += -Wall -DEROFS_VERSION=\"$(EROFS_VERSION)\"
> +ccflags-y += -DEROFS_VERSION=\"$(EROFS_VERSION)\"
>
> obj-$(CONFIG_EROFS_FS) += erofs.o
> # staging requirement: to be self-contained in its own directory
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: erofs: drop unneeded -Wall addition
2019-05-15 4:31 [PATCH] staging: erofs: drop unneeded -Wall addition Masahiro Yamada
2019-05-15 5:18 ` Gao Xiang
@ 2019-05-15 6:52 ` Chao Yu
1 sibling, 0 replies; 3+ messages in thread
From: Chao Yu @ 2019-05-15 6:52 UTC (permalink / raw)
To: Masahiro Yamada, Gao Xiang, linux-erofs, Greg KH, devel; +Cc: linux-kernel
On 2019/5/15 12:31, Masahiro Yamada wrote:
> The top level Makefile adds -Wall globally:
>
> KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \
>
> I see two "-Wall" added for compiling objects in drivers/staging/erofs/.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-15 6:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-15 4:31 [PATCH] staging: erofs: drop unneeded -Wall addition Masahiro Yamada
2019-05-15 5:18 ` Gao Xiang
2019-05-15 6:52 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).