From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v5 4/5] perf stat: Save aggr value to first member of prev_raw_counts
Date: Mon, 18 May 2020 22:44:59 +0800 [thread overview]
Message-ID: <8ea36c95-3b38-a31e-b05a-41c9ccbada51@linux.intel.com> (raw)
In-Reply-To: <20200518124826.GF3726797@krava>
On 5/18/2020 8:48 PM, Jiri Olsa wrote:
> On Thu, May 14, 2020 at 01:36:37PM +0800, Jin Yao wrote:
>> To collect the overall statistics for interval mode, we copy the
>> counts from evsel->prev_raw_counts to evsel->counts.
>>
>> For AGGR_GLOBAL mode, because the perf_stat_process_counter creates
>> aggr values from per cpu values, but the per cpu values are 0,
>> so the calculated aggr values will be always 0.
>>
>> This patch uses a trick that saves the previous aggr value to
>> the first member of perf_counts, then aggr calculation in
>> process_counter_values can work correctly for AGGR_GLOBAL.
>>
>> Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
>> ---
>> tools/perf/util/stat.c | 10 ++++++++++
>> tools/perf/util/stat.h | 1 +
>> 2 files changed, 11 insertions(+)
>>
>> diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c
>> index aadc723ce871..fbabdd5b9b62 100644
>> --- a/tools/perf/util/stat.c
>> +++ b/tools/perf/util/stat.c
>> @@ -249,6 +249,16 @@ void perf_evlist__copy_prev_raw_counts(struct evlist *evlist)
>> perf_evsel__copy_prev_raw_counts(evsel);
>> }
>>
>
> much better, please put some comments in here explaning wha
> is this for, because it's not obvious ;-)
>
> thanks,
> jirka
>
Thanks, I will put some comments in v6.
Thanks
Jin Yao
>> +void perf_evlist__save_aggr_prev_raw_counts(struct evlist *evlist)
>> +{
>> + struct evsel *evsel;
>> +
>> + evlist__for_each_entry(evlist, evsel) {
>> + *perf_counts(evsel->prev_raw_counts, 0, 0) =
>> + evsel->prev_raw_counts->aggr;
>> + }
>> +}
>> +
>> static void zero_per_pkg(struct evsel *counter)
>> {
>> if (counter->per_pkg_mask)
>> diff --git a/tools/perf/util/stat.h b/tools/perf/util/stat.h
>> index 62cf72c71869..18ead55756cc 100644
>> --- a/tools/perf/util/stat.h
>> +++ b/tools/perf/util/stat.h
>> @@ -199,6 +199,7 @@ void perf_evlist__free_stats(struct evlist *evlist);
>> void perf_evlist__reset_stats(struct evlist *evlist);
>> void perf_evlist__reset_prev_raw_counts(struct evlist *evlist);
>> void perf_evlist__copy_prev_raw_counts(struct evlist *evlist);
>> +void perf_evlist__save_aggr_prev_raw_counts(struct evlist *evlist);
>>
>> int perf_stat_process_counter(struct perf_stat_config *config,
>> struct evsel *counter);
>> --
>> 2.17.1
>>
>
next prev parent reply other threads:[~2020-05-18 14:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 5:36 [PATCH v5 0/5] perf stat: Support overall statistics for interval mode Jin Yao
2020-05-14 5:36 ` [PATCH v5 1/5] perf stat: Fix wrong per-thread runtime stat " Jin Yao
2020-05-14 5:36 ` [PATCH v5 2/5] perf counts: Reset prev_raw_counts counts Jin Yao
2020-05-14 5:36 ` [PATCH v5 3/5] perf stat: Copy counts from prev_raw_counts to evsel->counts Jin Yao
2020-05-14 5:36 ` [PATCH v5 4/5] perf stat: Save aggr value to first member of prev_raw_counts Jin Yao
2020-05-18 12:48 ` Jiri Olsa
2020-05-18 14:44 ` Jin, Yao [this message]
2020-05-14 5:36 ` [PATCH v5 5/5] perf stat: Report summary for interval mode Jin Yao
2020-05-18 12:47 ` Jiri Olsa
2020-05-19 2:51 ` Jin, Yao
2020-05-14 9:53 ` [PATCH v5 0/5] perf stat: Support overall statistics " kajoljain
2020-05-14 13:44 ` Jin, Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ea36c95-3b38-a31e-b05a-41c9ccbada51@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).