* [PATCH] selftests: sparc64: delete RUN_TESTS and EMIT_TESTS overrides
@ 2018-06-12 23:24 Shuah Khan (Samsung OSG)
2018-06-13 17:18 ` Tom Hromatka
0 siblings, 1 reply; 3+ messages in thread
From: Shuah Khan (Samsung OSG) @ 2018-06-12 23:24 UTC (permalink / raw)
To: shuah, tom.hromatka; +Cc: linux-kselftest, linux-kernel
Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in
lib.mk. Common defines work just fine and there is no need to define
custom overrides.
Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
---
tools/testing/selftests/sparc64/Makefile | 8 --------
1 file changed, 8 deletions(-)
diff --git a/tools/testing/selftests/sparc64/Makefile b/tools/testing/selftests/sparc64/Makefile
index 442f0ca45441..76b2206932c3 100644
--- a/tools/testing/selftests/sparc64/Makefile
+++ b/tools/testing/selftests/sparc64/Makefile
@@ -28,10 +28,6 @@ all:
fi \
done
-override define RUN_TESTS
- @cd $(OUTPUT); ./run.sh
-endef
-
override define INSTALL_RULE
mkdir -p $(INSTALL_PATH)
install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES)
@@ -43,10 +39,6 @@ override define INSTALL_RULE
done;
endef
-override define EMIT_TESTS
- echo "./run.sh"
-endef
-
override define CLEAN
@for DIR in $(SUBDIRS); do \
BUILD_TARGET=$(OUTPUT)/$$DIR; \
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests: sparc64: delete RUN_TESTS and EMIT_TESTS overrides
2018-06-12 23:24 [PATCH] selftests: sparc64: delete RUN_TESTS and EMIT_TESTS overrides Shuah Khan (Samsung OSG)
@ 2018-06-13 17:18 ` Tom Hromatka
2018-06-15 16:38 ` Shuah Khan
0 siblings, 1 reply; 3+ messages in thread
From: Tom Hromatka @ 2018-06-13 17:18 UTC (permalink / raw)
To: Shuah Khan (Samsung OSG); +Cc: linux-kselftest, linux-kernel
Thanks for the clean up, Shuah. Looks good to me.
Tom
On 06/12/2018 05:24 PM, Shuah Khan (Samsung OSG) wrote:
> Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in
> lib.mk. Common defines work just fine and there is no need to define
> custom overrides.
>
> Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
Reviewed-by: Tom Hromatka <tom.hromatka@oracle.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests: sparc64: delete RUN_TESTS and EMIT_TESTS overrides
2018-06-13 17:18 ` Tom Hromatka
@ 2018-06-15 16:38 ` Shuah Khan
0 siblings, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2018-06-15 16:38 UTC (permalink / raw)
To: Tom Hromatka, davem; +Cc: linux-kselftest, linux-kernel, Shuah Khan
On 06/13/2018 11:18 AM, Tom Hromatka wrote:
> Thanks for the clean up, Shuah. Looks good to me.
>
> Tom
>
>
>
> On 06/12/2018 05:24 PM, Shuah Khan (Samsung OSG) wrote:
>> Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in
>> lib.mk. Common defines work just fine and there is no need to define
>> custom overrides.
>>
>> Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
>
> Reviewed-by: Tom Hromatka <tom.hromatka@oracle.com>
>
>
get_maintainers didn't include your name for this patch. Would you like to
take this fix through sparc tree? This is cleanup fix would be good candidate
for 4.18-rc2
If so, please let me know if you would like me to resend the patch
with Tom's Reviewed-by tag.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-15 16:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-12 23:24 [PATCH] selftests: sparc64: delete RUN_TESTS and EMIT_TESTS overrides Shuah Khan (Samsung OSG)
2018-06-13 17:18 ` Tom Hromatka
2018-06-15 16:38 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).