From: Taniya Das <tdas@codeaurora.org>
To: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>
Cc: Rajendra Nayak <rnayak@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, robh@kernel.org, robh+dt@kernel.org
Subject: Re: [PATCH v1 2/2] clk: qcom: Add lpass clock controller driver for SC7280
Date: Wed, 6 Oct 2021 07:09:12 +0530 [thread overview]
Message-ID: <8ec18abf-0ab4-a033-c7ad-6819bf506b61@codeaurora.org> (raw)
In-Reply-To: <163047470651.42057.13433048930627060805@swboyd.mtv.corp.google.com>
Hello Stephen,
Thanks for your review.
On 9/1/2021 11:08 AM, Stephen Boyd wrote:
> Quoting Taniya Das (2021-08-31 03:36:42)
>> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
>> index 0a55967..cd7a5a1 100644
>> --- a/drivers/clk/qcom/Kconfig
>> +++ b/drivers/clk/qcom/Kconfig
>> @@ -394,6 +394,14 @@ config SC_LPASS_CORECC_7180
>> Say Y if you want to use LPASS clocks and power domains of the LPASS
>> core clock controller.
>>
>> +config SC_LPASSCC_7280
>> + tristate "SC7280 Low Power Audio Subsystem (LPAAS) Clock Controller"
>> + select SC_GCC_7280
>> + help
>> + Support for the LPASS clock controller on SC7280 devices.
>> + Say Y if you want to use the LPASS branch clocks of the LPASS clock
>> + controller to reset the LPASS subsystem.
>> +
>
> Can you send another patch to move SC_LPASS_CORECC_7180 under
> SC_GPUCC_7180? This file should be sorted on Kconfig symbol
> alphabetically.
>
Yes, will send a patch to fix.
>> config SC_GPUCC_7180
>> tristate "SC7180 Graphics Clock Controller"
>> select SC_GCC_7180
>> diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile
>> index 9825ef8..1b33f49 100644
>> --- a/drivers/clk/qcom/Makefile
>> +++ b/drivers/clk/qcom/Makefile
>> @@ -66,6 +66,7 @@ obj-$(CONFIG_SC_GCC_8180X) += gcc-sc8180x.o
>> obj-$(CONFIG_SC_GPUCC_7180) += gpucc-sc7180.o
>> obj-$(CONFIG_SC_GPUCC_7280) += gpucc-sc7280.o
>> obj-$(CONFIG_SC_LPASS_CORECC_7180) += lpasscorecc-sc7180.o
>> +obj-$(CONFIG_SC_LPASSCC_7280) += lpasscc-sc7280.o
>
> This one got it right, almost. LPASSCC comes before LPASS_CORECC though.
>
Next patch will fix.
>> obj-$(CONFIG_SC_MSS_7180) += mss-sc7180.o
>> obj-$(CONFIG_SC_VIDEOCC_7180) += videocc-sc7180.o
>> obj-$(CONFIG_SC_VIDEOCC_7280) += videocc-sc7280.o
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.
--
next prev parent reply other threads:[~2021-10-06 1:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 10:36 [PATCH v1 1/2] dt-bindings: clock: Add YAML schemas for LPASS clocks on SC7280 Taniya Das
2021-08-31 10:36 ` [PATCH v1 2/2] clk: qcom: Add lpass clock controller driver for SC7280 Taniya Das
2021-09-01 5:38 ` Stephen Boyd
2021-10-06 1:39 ` Taniya Das [this message]
2021-09-01 1:45 ` [PATCH v1 1/2] dt-bindings: clock: Add YAML schemas for LPASS clocks on SC7280 Rob Herring
2021-10-06 1:39 ` Taniya Das
-- strict thread matches above, loose matches on Subject: below --
2021-04-09 11:54 Taniya Das
2021-04-09 11:54 ` [PATCH v1 2/2] clk: qcom: Add lpass clock controller driver for SC7280 Taniya Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ec18abf-0ab4-a033-c7ad-6819bf506b61@codeaurora.org \
--to=tdas@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).