From: Rob Herring <robh@kernel.org>
To: Taniya Das <tdas@codeaurora.org>
Cc: "Stephen Boyd" <sboyd@kernel.org>,
"Michael Turquette " <mturquette@baylibre.com>,
"Rajendra Nayak" <rnayak@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: clock: Add YAML schemas for LPASS clocks on SC7280
Date: Tue, 31 Aug 2021 20:45:11 -0500 [thread overview]
Message-ID: <YS7bJ7bu6Ud2f+vB@robh.at.kernel.org> (raw)
In-Reply-To: <1630406202-3919-1-git-send-email-tdas@codeaurora.org>
On Tue, Aug 31, 2021 at 04:06:41PM +0530, Taniya Das wrote:
> The LPASS(Low Power Audio Subsystem) clock provider have a bunch of generic
> properties that are needed in a device tree. Add the LPASS clock IDs for
> LPASS PIL client to request for the clocks.
>
> Signed-off-by: Taniya Das <tdas@codeaurora.org>
> ---
> .../bindings/clock/qcom,sc7280-lpasscc.yaml | 69 ++++++++++++++++++++++
> include/dt-bindings/clock/qcom,lpass-sc7280.h | 16 +++++
> 2 files changed, 85 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml
> create mode 100644 include/dt-bindings/clock/qcom,lpass-sc7280.h
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml
> new file mode 100644
> index 0000000..7b62763
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml
> @@ -0,0 +1,69 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/qcom,sc7280-lpasscc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm LPASS Core Clock Controller Binding for SC7280
> +
> +maintainers:
> + - Taniya Das <tdas@codeaurora.org>
> +
> +description: |
> + Qualcomm LPASS core clock control module which supports the clocks and
> + power domains on SC7280.
> +
> + See also:
> + - dt-bindings/clock/qcom,lpass-sc7280.h
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,sc7280-lpasscc
> +
> + clocks:
> + items:
> + - description: gcc_cfg_noc_lpass_clk from GCC
> +
> + clock-names:
> + items:
> + - const: iface
> +
> + '#clock-cells':
> + const: 1
> +
> + reg:
> + minItems: 3
Don't need minItems equal to 'items' length.
> + items:
> + - description: LPASS qdsp6ss register
> + - description: LPASS top-cc register
> + - description: LPASS cc register
> +
> + reg-names:
> + items:
> + - const: qdsp6ss
> + - const: top_cc
> + - const: cc
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - '#clock-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,gcc-sc7280.h>
> + #include <dt-bindings/clock/qcom,lpass-sc7280.h>
> + clock-controller@3000000 {
> + compatible = "qcom,sc7280-lpasscc";
> + reg = <0x03000000 0x40>, <0x03c04000 0x4>, <0x03389000 0x24>;
> + reg-names = "qdsp6ss", "top_cc", "cc";
> + clocks = <&gcc GCC_CFG_NOC_LPASS_CLK>;
> + clock-names = "iface";
> + #clock-cells = <1>;
> + };
> +...
> diff --git a/include/dt-bindings/clock/qcom,lpass-sc7280.h b/include/dt-bindings/clock/qcom,lpass-sc7280.h
> new file mode 100644
> index 0000000..a259463
> --- /dev/null
> +++ b/include/dt-bindings/clock/qcom,lpass-sc7280.h
> @@ -0,0 +1,16 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
Dual license.
> +/*
> + * Copyright (c) 2021, The Linux Foundation. All rights reserved.
> + */
> +
> +#ifndef _DT_BINDINGS_CLK_QCOM_LPASS_SC7280_H
> +#define _DT_BINDINGS_CLK_QCOM_LPASS_SC7280_H
> +
> +#define LPASS_Q6SS_AHBM_CLK 0
> +#define LPASS_Q6SS_AHBS_CLK 1
> +#define LPASS_TOP_CC_LPI_Q6_AXIM_HS_CLK 2
> +#define LPASS_QDSP6SS_XO_CLK 3
> +#define LPASS_QDSP6SS_SLEEP_CLK 4
> +#define LPASS_QDSP6SS_CORE_CLK 5
> +
> +#endif
> --
> Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
> of the Code Aurora Forum, hosted by the Linux Foundation.
>
>
next prev parent reply other threads:[~2021-09-01 1:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 10:36 [PATCH v1 1/2] dt-bindings: clock: Add YAML schemas for LPASS clocks on SC7280 Taniya Das
2021-08-31 10:36 ` [PATCH v1 2/2] clk: qcom: Add lpass clock controller driver for SC7280 Taniya Das
2021-09-01 5:38 ` Stephen Boyd
2021-10-06 1:39 ` Taniya Das
2021-09-01 1:45 ` Rob Herring [this message]
2021-10-06 1:39 ` [PATCH v1 1/2] dt-bindings: clock: Add YAML schemas for LPASS clocks on SC7280 Taniya Das
-- strict thread matches above, loose matches on Subject: below --
2021-04-09 11:54 Taniya Das
2021-04-12 17:03 ` Rob Herring
2021-07-22 22:35 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YS7bJ7bu6Ud2f+vB@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rnayak@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).