* [PATCH -next] pinctrl: aspeed: Make aspeed_pinmux_ips static
@ 2019-07-11 14:24 YueHaibing
2019-07-12 0:56 ` Andrew Jeffery
2019-07-29 21:36 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2019-07-11 14:24 UTC (permalink / raw)
To: andrew, linus.walleij, joel, linux-aspeed, openbmc
Cc: linux-kernel, linux-gpio, linux-arm-kernel, YueHaibing
Fix sparse warning:
drivers/pinctrl/aspeed/pinmux-aspeed.c:8:12: warning:
symbol 'aspeed_pinmux_ips' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/pinctrl/aspeed/pinmux-aspeed.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/aspeed/pinmux-aspeed.c b/drivers/pinctrl/aspeed/pinmux-aspeed.c
index 5b0fe17..839c01b 100644
--- a/drivers/pinctrl/aspeed/pinmux-aspeed.c
+++ b/drivers/pinctrl/aspeed/pinmux-aspeed.c
@@ -5,7 +5,7 @@
#include "pinmux-aspeed.h"
-const char *const aspeed_pinmux_ips[] = {
+static const char *const aspeed_pinmux_ips[] = {
[ASPEED_IP_SCU] = "SCU",
[ASPEED_IP_GFX] = "GFX",
[ASPEED_IP_LPC] = "LPC",
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] pinctrl: aspeed: Make aspeed_pinmux_ips static
2019-07-11 14:24 [PATCH -next] pinctrl: aspeed: Make aspeed_pinmux_ips static YueHaibing
@ 2019-07-12 0:56 ` Andrew Jeffery
2019-07-29 21:36 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Jeffery @ 2019-07-12 0:56 UTC (permalink / raw)
To: YueHaibing, Linus Walleij, Joel Stanley, linux-aspeed, openbmc
Cc: linux-kernel, linux-gpio, linux-arm-kernel
On Thu, 11 Jul 2019, at 23:55, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/pinctrl/aspeed/pinmux-aspeed.c:8:12: warning:
> symbol 'aspeed_pinmux_ips' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
> ---
> drivers/pinctrl/aspeed/pinmux-aspeed.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/aspeed/pinmux-aspeed.c
> b/drivers/pinctrl/aspeed/pinmux-aspeed.c
> index 5b0fe17..839c01b 100644
> --- a/drivers/pinctrl/aspeed/pinmux-aspeed.c
> +++ b/drivers/pinctrl/aspeed/pinmux-aspeed.c
> @@ -5,7 +5,7 @@
>
> #include "pinmux-aspeed.h"
>
> -const char *const aspeed_pinmux_ips[] = {
> +static const char *const aspeed_pinmux_ips[] = {
> [ASPEED_IP_SCU] = "SCU",
> [ASPEED_IP_GFX] = "GFX",
> [ASPEED_IP_LPC] = "LPC",
> --
> 2.7.4
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] pinctrl: aspeed: Make aspeed_pinmux_ips static
2019-07-11 14:24 [PATCH -next] pinctrl: aspeed: Make aspeed_pinmux_ips static YueHaibing
2019-07-12 0:56 ` Andrew Jeffery
@ 2019-07-29 21:36 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2019-07-29 21:36 UTC (permalink / raw)
To: YueHaibing
Cc: Andrew Jeffery, Joel Stanley, linux-aspeed, OpenBMC Maillist,
linux-kernel, open list:GPIO SUBSYSTEM, Linux ARM
On Thu, Jul 11, 2019 at 4:25 PM YueHaibing <yuehaibing@huawei.com> wrote:
> Fix sparse warning:
>
> drivers/pinctrl/aspeed/pinmux-aspeed.c:8:12: warning:
> symbol 'aspeed_pinmux_ips' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Patch applied with Andrew's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-29 21:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-11 14:24 [PATCH -next] pinctrl: aspeed: Make aspeed_pinmux_ips static YueHaibing
2019-07-12 0:56 ` Andrew Jeffery
2019-07-29 21:36 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).