* [PATCH] staging: unisys: visorbus: constify channel_attr_grp and dev_attr_grp
@ 2017-06-23 7:36 Arvind Yadav
2017-06-27 17:02 ` Kershner, David A
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-06-23 7:36 UTC (permalink / raw)
To: david.kershner, gregkh, bryan.thompson, sameer.wadgaonkar, jon.frisch
Cc: sparmaintainer, devel, linux-kernel
File size before:
text data bss dec hex filename
6712 960 521 8193 2001 drivers/staging/unisys/visorbus/visorbus_main.o
File size After adding 'const':
text data bss dec hex filename
6840 832 521 8193 2001 drivers/staging/unisys/visorbus/visorbus_main.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
index a692561..26f9885 100644
--- a/drivers/staging/unisys/visorbus/visorbus_main.c
+++ b/drivers/staging/unisys/visorbus/visorbus_main.c
@@ -249,7 +249,7 @@ static ssize_t typename_show(struct device *dev, struct device_attribute *attr,
NULL
};
-static struct attribute_group channel_attr_grp = {
+static const struct attribute_group channel_attr_grp = {
.name = "channel",
.attrs = channel_attrs,
};
@@ -340,7 +340,7 @@ static ssize_t channel_id_show(struct device *dev,
NULL
};
-static struct attribute_group dev_attr_grp = {
+static const struct attribute_group dev_attr_grp = {
.attrs = dev_attrs,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] staging: unisys: visorbus: constify channel_attr_grp and dev_attr_grp
2017-06-23 7:36 [PATCH] staging: unisys: visorbus: constify channel_attr_grp and dev_attr_grp Arvind Yadav
@ 2017-06-27 17:02 ` Kershner, David A
0 siblings, 0 replies; 2+ messages in thread
From: Kershner, David A @ 2017-06-27 17:02 UTC (permalink / raw)
To: Arvind Yadav, gregkh, Thompson, Bryan E.,
Wadgaonkar, Sameer Laxmikant, jon.frisch
Cc: *S-Par-Maintainer, devel, linux-kernel
> -----Original Message-----
> From: Arvind Yadav [mailto:arvind.yadav.cs@gmail.com]
> Sent: Friday, June 23, 2017 3:37 AM
> To: Kershner, David A <David.Kershner@unisys.com>;
> gregkh@linuxfoundation.org; Thompson, Bryan E.
> <bryan.thompson@unisys.com>; Wadgaonkar, Sameer Laxmikant
> <Sameer.Wadgaonkar@unisys.com>; jon.frisch@unisys.com
> Cc: *S-Par-Maintainer <SParMaintainer@unisys.com>;
> devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] staging: unisys: visorbus: constify channel_attr_grp and
> dev_attr_grp
>
> File size before:
> text data bss dec hex filename
> 6712 960 521 8193 2001
> drivers/staging/unisys/visorbus/visorbus_main.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 6840 832 521 8193 2001
> drivers/staging/unisys/visorbus/visorbus_main.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: David Kershner <david.kershner@unisys.com>
> ---
> drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
> b/drivers/staging/unisys/visorbus/visorbus_main.c
> index a692561..26f9885 100644
> --- a/drivers/staging/unisys/visorbus/visorbus_main.c
> +++ b/drivers/staging/unisys/visorbus/visorbus_main.c
> @@ -249,7 +249,7 @@ static ssize_t typename_show(struct device *dev,
> struct device_attribute *attr,
> NULL
> };
>
> -static struct attribute_group channel_attr_grp = {
> +static const struct attribute_group channel_attr_grp = {
> .name = "channel",
> .attrs = channel_attrs,
> };
> @@ -340,7 +340,7 @@ static ssize_t channel_id_show(struct device *dev,
> NULL
> };
>
> -static struct attribute_group dev_attr_grp = {
> +static const struct attribute_group dev_attr_grp = {
> .attrs = dev_attrs,
> };
>
> --
> 1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-27 17:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-23 7:36 [PATCH] staging: unisys: visorbus: constify channel_attr_grp and dev_attr_grp Arvind Yadav
2017-06-27 17:02 ` Kershner, David A
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).