* [PATCH 1/9] mfd: tps65217: Remove redundant i2c_device_id
2017-06-04 9:18 [PATCH 0/9] mfd: Remove redundant i2c_device_id Keerthy
@ 2017-06-04 9:18 ` Keerthy
2017-06-04 9:18 ` [PATCH 2/9] mfd: tps65218: " Keerthy
` (8 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: Keerthy @ 2017-06-04 9:18 UTC (permalink / raw)
To: tony, milo.kim, lee.jones; +Cc: j-keerthy, linux-omap, linux-kernel
With the introduction of probe_new function the i2c_device_id
is no longer needed. Hence the remove the same and use probe_new
instead of probe.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
Boot tested on am335x-bone and checked for regulator registrations.
drivers/mfd/tps65217.c | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c
index f769c7d..c2e8385 100644
--- a/drivers/mfd/tps65217.c
+++ b/drivers/mfd/tps65217.c
@@ -316,12 +316,11 @@ static bool tps65217_volatile_reg(struct device *dev, unsigned int reg)
};
MODULE_DEVICE_TABLE(of, tps65217_of_match);
-static int tps65217_probe(struct i2c_client *client,
- const struct i2c_device_id *ids)
+static int tps65217_probe(struct i2c_client *client)
{
struct tps65217 *tps;
unsigned int version;
- unsigned long chip_id = ids->driver_data;
+ unsigned long chip_id = 0;
const struct of_device_id *match;
bool status_off = false;
int ret;
@@ -418,19 +417,12 @@ static int tps65217_remove(struct i2c_client *client)
return 0;
}
-static const struct i2c_device_id tps65217_id_table[] = {
- {"tps65217", TPS65217},
- { /* sentinel */ }
-};
-MODULE_DEVICE_TABLE(i2c, tps65217_id_table);
-
static struct i2c_driver tps65217_driver = {
.driver = {
.name = "tps65217",
.of_match_table = tps65217_of_match,
},
- .id_table = tps65217_id_table,
- .probe = tps65217_probe,
+ .probe_new = tps65217_probe,
.remove = tps65217_remove,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 2/9] mfd: tps65218: Remove redundant i2c_device_id
2017-06-04 9:18 [PATCH 0/9] mfd: Remove redundant i2c_device_id Keerthy
2017-06-04 9:18 ` [PATCH 1/9] mfd: tps65217: " Keerthy
@ 2017-06-04 9:18 ` Keerthy
2017-06-04 9:18 ` [PATCH 3/9] mfd: palmas: " Keerthy
` (7 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: Keerthy @ 2017-06-04 9:18 UTC (permalink / raw)
To: tony, milo.kim, lee.jones; +Cc: j-keerthy, linux-omap, linux-kernel
With the introduction of probe_new function the i2c_device_id
is no longer needed. Hence the remove the same and use probe_new
instead of probe.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
Boot tested on am347x-gp-evm and checked for regulator registrations.
drivers/mfd/tps65218.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/mfd/tps65218.c b/drivers/mfd/tps65218.c
index 13834a0..53df80b 100644
--- a/drivers/mfd/tps65218.c
+++ b/drivers/mfd/tps65218.c
@@ -211,8 +211,7 @@ int tps65218_clear_bits(struct tps65218 *tps, unsigned int reg,
};
MODULE_DEVICE_TABLE(of, of_tps65218_match_table);
-static int tps65218_probe(struct i2c_client *client,
- const struct i2c_device_id *ids)
+static int tps65218_probe(struct i2c_client *client)
{
struct tps65218 *tps;
const struct of_device_id *match;
@@ -281,20 +280,22 @@ static int tps65218_remove(struct i2c_client *client)
return 0;
}
+#if 0
static const struct i2c_device_id tps65218_id_table[] = {
{ "tps65218", TPS65218 },
{ },
};
MODULE_DEVICE_TABLE(i2c, tps65218_id_table);
+#endif
static struct i2c_driver tps65218_driver = {
.driver = {
.name = "tps65218",
.of_match_table = of_tps65218_match_table,
},
- .probe = tps65218_probe,
+ .probe_new = tps65218_probe,
.remove = tps65218_remove,
- .id_table = tps65218_id_table,
+ //.id_table = tps65218_id_table,
};
module_i2c_driver(tps65218_driver);
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 3/9] mfd: palmas: Remove redundant i2c_device_id
2017-06-04 9:18 [PATCH 0/9] mfd: Remove redundant i2c_device_id Keerthy
2017-06-04 9:18 ` [PATCH 1/9] mfd: tps65217: " Keerthy
2017-06-04 9:18 ` [PATCH 2/9] mfd: tps65218: " Keerthy
@ 2017-06-04 9:18 ` Keerthy
2017-06-04 9:18 ` [PATCH 4/9] mfd: lp873x: " Keerthy
` (6 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: Keerthy @ 2017-06-04 9:18 UTC (permalink / raw)
To: tony, milo.kim, lee.jones; +Cc: j-keerthy, linux-omap, linux-kernel
With the introduction of probe_new function the i2c_device_id
is no longer needed. Hence the remove the same and use probe_new
instead of probe.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
Boot tested on dra7-evm and dra72-evm and checked for regulator registrations.
drivers/mfd/palmas.c | 15 ++-------------
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
index 9103aff..db9e53c 100644
--- a/drivers/mfd/palmas.c
+++ b/drivers/mfd/palmas.c
@@ -499,8 +499,7 @@ struct palmas_driver_data {
};
MODULE_DEVICE_TABLE(of, of_palmas_match_tbl);
-static int palmas_i2c_probe(struct i2c_client *i2c,
- const struct i2c_device_id *id)
+static int palmas_i2c_probe(struct i2c_client *i2c)
{
struct palmas *palmas;
struct palmas_platform_data *pdata;
@@ -717,23 +716,13 @@ static int palmas_i2c_remove(struct i2c_client *i2c)
return 0;
}
-static const struct i2c_device_id palmas_i2c_id[] = {
- { "palmas", },
- { "twl6035", },
- { "twl6037", },
- { "tps65913", },
- { /* end */ }
-};
-MODULE_DEVICE_TABLE(i2c, palmas_i2c_id);
-
static struct i2c_driver palmas_i2c_driver = {
.driver = {
.name = "palmas",
.of_match_table = of_palmas_match_tbl,
},
- .probe = palmas_i2c_probe,
+ .probe_new = palmas_i2c_probe,
.remove = palmas_i2c_remove,
- .id_table = palmas_i2c_id,
};
static int __init palmas_i2c_init(void)
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 4/9] mfd: lp873x: Remove redundant i2c_device_id
2017-06-04 9:18 [PATCH 0/9] mfd: Remove redundant i2c_device_id Keerthy
` (2 preceding siblings ...)
2017-06-04 9:18 ` [PATCH 3/9] mfd: palmas: " Keerthy
@ 2017-06-04 9:18 ` Keerthy
2017-06-04 9:18 ` [PATCH 5/9] mfd: lp8788: " Keerthy
` (5 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: Keerthy @ 2017-06-04 9:18 UTC (permalink / raw)
To: tony, milo.kim, lee.jones; +Cc: j-keerthy, linux-omap, linux-kernel
With the introduction of probe_new function the i2c_device_id
is no longer needed. Hence the remove the same and use probe_new
instead of probe.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
Boot tested on dra71-evm and checked for regulator registrations.
drivers/mfd/lp873x.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/mfd/lp873x.c b/drivers/mfd/lp873x.c
index 873c608..47be6b8 100644
--- a/drivers/mfd/lp873x.c
+++ b/drivers/mfd/lp873x.c
@@ -32,8 +32,7 @@
{ .name = "lp873x-gpio", },
};
-static int lp873x_probe(struct i2c_client *client,
- const struct i2c_device_id *ids)
+static int lp873x_probe(struct i2c_client *client)
{
struct lp873x *lp873;
int ret;
@@ -76,19 +75,12 @@ static int lp873x_probe(struct i2c_client *client,
};
MODULE_DEVICE_TABLE(of, of_lp873x_match_table);
-static const struct i2c_device_id lp873x_id_table[] = {
- { "lp873x", 0 },
- { },
-};
-MODULE_DEVICE_TABLE(i2c, lp873x_id_table);
-
static struct i2c_driver lp873x_driver = {
.driver = {
.name = "lp873x",
.of_match_table = of_lp873x_match_table,
},
- .probe = lp873x_probe,
- .id_table = lp873x_id_table,
+ .probe_new = lp873x_probe,
};
module_i2c_driver(lp873x_driver);
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 5/9] mfd: lp8788: Remove redundant i2c_device_id
2017-06-04 9:18 [PATCH 0/9] mfd: Remove redundant i2c_device_id Keerthy
` (3 preceding siblings ...)
2017-06-04 9:18 ` [PATCH 4/9] mfd: lp873x: " Keerthy
@ 2017-06-04 9:18 ` Keerthy
2017-06-04 9:18 ` [PATCH 6/9] mfd: lp3943: " Keerthy
` (4 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: Keerthy @ 2017-06-04 9:18 UTC (permalink / raw)
To: tony, milo.kim, lee.jones; +Cc: j-keerthy, linux-omap, linux-kernel
With the introduction of probe_new function the i2c_device_id
is no longer needed. Hence the remove the same and use probe_new
instead of probe.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
Compile tested.
drivers/mfd/lp8788.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/mfd/lp8788.c b/drivers/mfd/lp8788.c
index acf6165..a46139d 100644
--- a/drivers/mfd/lp8788.c
+++ b/drivers/mfd/lp8788.c
@@ -170,7 +170,7 @@ static int lp8788_platform_init(struct lp8788 *lp)
.max_register = MAX_LP8788_REGISTERS,
};
-static int lp8788_probe(struct i2c_client *cl, const struct i2c_device_id *id)
+static int lp8788_probe(struct i2c_client *cl)
{
struct lp8788 *lp;
struct lp8788_platform_data *pdata = dev_get_platdata(&cl->dev);
@@ -212,19 +212,12 @@ static int lp8788_remove(struct i2c_client *cl)
return 0;
}
-static const struct i2c_device_id lp8788_ids[] = {
- {"lp8788", 0},
- { }
-};
-MODULE_DEVICE_TABLE(i2c, lp8788_ids);
-
static struct i2c_driver lp8788_driver = {
.driver = {
.name = "lp8788",
},
- .probe = lp8788_probe,
+ .probe_new = lp8788_probe,
.remove = lp8788_remove,
- .id_table = lp8788_ids,
};
static int __init lp8788_init(void)
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 6/9] mfd: lp3943: Remove redundant i2c_device_id
2017-06-04 9:18 [PATCH 0/9] mfd: Remove redundant i2c_device_id Keerthy
` (4 preceding siblings ...)
2017-06-04 9:18 ` [PATCH 5/9] mfd: lp8788: " Keerthy
@ 2017-06-04 9:18 ` Keerthy
2017-06-04 9:18 ` [PATCH 7/9] mfd: tps65086: " Keerthy
` (3 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: Keerthy @ 2017-06-04 9:18 UTC (permalink / raw)
To: tony, milo.kim, lee.jones; +Cc: j-keerthy, linux-omap, linux-kernel
With the introduction of probe_new function the i2c_device_id
is no longer needed. Hence the remove the same and use probe_new
instead of probe.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
Compile tested.
drivers/mfd/lp3943.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/mfd/lp3943.c b/drivers/mfd/lp3943.c
index 65a2a8f1..84ec685 100644
--- a/drivers/mfd/lp3943.c
+++ b/drivers/mfd/lp3943.c
@@ -105,7 +105,7 @@ int lp3943_update_bits(struct lp3943 *lp3943, u8 reg, u8 mask, u8 data)
.max_register = LP3943_MAX_REGISTERS,
};
-static int lp3943_probe(struct i2c_client *cl, const struct i2c_device_id *id)
+static int lp3943_probe(struct i2c_client *cl)
{
struct lp3943 *lp3943;
struct device *dev = &cl->dev;
@@ -128,12 +128,6 @@ static int lp3943_probe(struct i2c_client *cl, const struct i2c_device_id *id)
NULL, 0, NULL);
}
-static const struct i2c_device_id lp3943_ids[] = {
- { "lp3943", 0 },
- { }
-};
-MODULE_DEVICE_TABLE(i2c, lp3943_ids);
-
#ifdef CONFIG_OF
static const struct of_device_id lp3943_of_match[] = {
{ .compatible = "ti,lp3943", },
@@ -143,12 +137,11 @@ static int lp3943_probe(struct i2c_client *cl, const struct i2c_device_id *id)
#endif
static struct i2c_driver lp3943_driver = {
- .probe = lp3943_probe,
+ .probe_new = lp3943_probe,
.driver = {
.name = "lp3943",
.of_match_table = of_match_ptr(lp3943_of_match),
},
- .id_table = lp3943_ids,
};
module_i2c_driver(lp3943_driver);
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 7/9] mfd: tps65086: Remove redundant i2c_device_id
2017-06-04 9:18 [PATCH 0/9] mfd: Remove redundant i2c_device_id Keerthy
` (5 preceding siblings ...)
2017-06-04 9:18 ` [PATCH 6/9] mfd: lp3943: " Keerthy
@ 2017-06-04 9:18 ` Keerthy
2017-06-04 9:18 ` [PATCH 8/9] mfd: tps65090: " Keerthy
` (2 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: Keerthy @ 2017-06-04 9:18 UTC (permalink / raw)
To: tony, milo.kim, lee.jones; +Cc: j-keerthy, linux-omap, linux-kernel
With the introduction of probe_new function the i2c_device_id
is no longer needed. Hence the remove the same and use probe_new
instead of probe.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
Compile tested.
drivers/mfd/tps65086.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/mfd/tps65086.c b/drivers/mfd/tps65086.c
index 43119a6..975ac4a 100644
--- a/drivers/mfd/tps65086.c
+++ b/drivers/mfd/tps65086.c
@@ -68,8 +68,7 @@
};
MODULE_DEVICE_TABLE(of, tps65086_of_match_table);
-static int tps65086_probe(struct i2c_client *client,
- const struct i2c_device_id *ids)
+static int tps65086_probe(struct i2c_client *client)
{
struct tps65086 *tps;
unsigned int version;
@@ -127,20 +126,13 @@ static int tps65086_remove(struct i2c_client *client)
return 0;
}
-static const struct i2c_device_id tps65086_id_table[] = {
- { "tps65086", 0 },
- { /* sentinel */ }
-};
-MODULE_DEVICE_TABLE(i2c, tps65086_id_table);
-
static struct i2c_driver tps65086_driver = {
.driver = {
.name = "tps65086",
.of_match_table = tps65086_of_match_table,
},
- .probe = tps65086_probe,
+ .probe_new = tps65086_probe,
.remove = tps65086_remove,
- .id_table = tps65086_id_table,
};
module_i2c_driver(tps65086_driver);
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 8/9] mfd: tps65090: Remove redundant i2c_device_id
2017-06-04 9:18 [PATCH 0/9] mfd: Remove redundant i2c_device_id Keerthy
` (6 preceding siblings ...)
2017-06-04 9:18 ` [PATCH 7/9] mfd: tps65086: " Keerthy
@ 2017-06-04 9:18 ` Keerthy
2017-06-04 9:18 ` [PATCH 9/9] mfd: tps6586x: " Keerthy
2017-06-05 10:37 ` [PATCH 0/9] mfd: " Lee Jones
9 siblings, 0 replies; 17+ messages in thread
From: Keerthy @ 2017-06-04 9:18 UTC (permalink / raw)
To: tony, milo.kim, lee.jones; +Cc: j-keerthy, linux-omap, linux-kernel
With the introduction of probe_new function the i2c_device_id
is no longer needed. Hence the remove the same and use probe_new
instead of probe.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
Compile tested.
drivers/mfd/tps65090.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/mfd/tps65090.c b/drivers/mfd/tps65090.c
index d7ec318..200a9c8 100644
--- a/drivers/mfd/tps65090.c
+++ b/drivers/mfd/tps65090.c
@@ -174,8 +174,7 @@ static bool is_volatile_reg(struct device *dev, unsigned int reg)
MODULE_DEVICE_TABLE(of, tps65090_of_match);
#endif
-static int tps65090_i2c_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int tps65090_i2c_probe(struct i2c_client *client)
{
struct tps65090_platform_data *pdata = dev_get_platdata(&client->dev);
int irq_base = 0;
@@ -249,20 +248,13 @@ static int tps65090_i2c_remove(struct i2c_client *client)
return 0;
}
-static const struct i2c_device_id tps65090_id_table[] = {
- { "tps65090", 0 },
- { },
-};
-MODULE_DEVICE_TABLE(i2c, tps65090_id_table);
-
static struct i2c_driver tps65090_driver = {
.driver = {
.name = "tps65090",
.of_match_table = of_match_ptr(tps65090_of_match),
},
- .probe = tps65090_i2c_probe,
+ .probe_new = tps65090_i2c_probe,
.remove = tps65090_i2c_remove,
- .id_table = tps65090_id_table,
};
static int __init tps65090_init(void)
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 9/9] mfd: tps6586x: Remove redundant i2c_device_id
2017-06-04 9:18 [PATCH 0/9] mfd: Remove redundant i2c_device_id Keerthy
` (7 preceding siblings ...)
2017-06-04 9:18 ` [PATCH 8/9] mfd: tps65090: " Keerthy
@ 2017-06-04 9:18 ` Keerthy
2017-06-05 10:37 ` [PATCH 0/9] mfd: " Lee Jones
9 siblings, 0 replies; 17+ messages in thread
From: Keerthy @ 2017-06-04 9:18 UTC (permalink / raw)
To: tony, milo.kim, lee.jones; +Cc: j-keerthy, linux-omap, linux-kernel
With the introduction of probe_new function the i2c_device_id
is no longer needed. Hence the remove the same and use probe_new
instead of probe.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
Compile tested.
drivers/mfd/tps6586x.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c
index 5628a6b..5572cf6 100644
--- a/drivers/mfd/tps6586x.c
+++ b/drivers/mfd/tps6586x.c
@@ -503,8 +503,7 @@ static void tps6586x_print_version(struct i2c_client *client, int version)
dev_info(&client->dev, "Found %s, VERSIONCRC is %02x\n", name, version);
}
-static int tps6586x_i2c_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int tps6586x_i2c_probe(struct i2c_client *client)
{
struct tps6586x_platform_data *pdata = dev_get_platdata(&client->dev);
struct tps6586x *tps6586x;
@@ -594,20 +593,13 @@ static int tps6586x_i2c_remove(struct i2c_client *client)
return 0;
}
-static const struct i2c_device_id tps6586x_id_table[] = {
- { "tps6586x", 0 },
- { },
-};
-MODULE_DEVICE_TABLE(i2c, tps6586x_id_table);
-
static struct i2c_driver tps6586x_driver = {
.driver = {
.name = "tps6586x",
.of_match_table = of_match_ptr(tps6586x_of_match),
},
- .probe = tps6586x_i2c_probe,
+ .probe_new = tps6586x_i2c_probe,
.remove = tps6586x_i2c_remove,
- .id_table = tps6586x_id_table,
};
static int __init tps6586x_init(void)
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 0/9] mfd: Remove redundant i2c_device_id
2017-06-04 9:18 [PATCH 0/9] mfd: Remove redundant i2c_device_id Keerthy
` (8 preceding siblings ...)
2017-06-04 9:18 ` [PATCH 9/9] mfd: tps6586x: " Keerthy
@ 2017-06-05 10:37 ` Lee Jones
2017-06-05 14:37 ` Keerthy
9 siblings, 1 reply; 17+ messages in thread
From: Lee Jones @ 2017-06-05 10:37 UTC (permalink / raw)
To: Keerthy; +Cc: tony, milo.kim, linux-omap, linux-kernel
On Sun, 04 Jun 2017, Keerthy wrote:
> With the introduction of probe_new function the i2c_device_id
> is no longer needed. Hence the remove the same and use probe_new
> instead of probe.
>
> Keerthy (9):
> mfd: tps65217: Remove redundant i2c_device_id
> mfd: tps65218: Remove redundant i2c_device_id
> mfd: palmas: Remove redundant i2c_device_id
> mfd: lp873x: Remove redundant i2c_device_id
> mfd: lp8788: Remove redundant i2c_device_id
> mfd: lp3943: Remove redundant i2c_device_id
> mfd: tps65086: Remove redundant i2c_device_id
> mfd: tps65090: Remove redundant i2c_device_id
> mfd: tps6586x: Remove redundant i2c_device_id
>
> drivers/mfd/lp3943.c | 11 ++---------
> drivers/mfd/lp873x.c | 12 ++----------
> drivers/mfd/lp8788.c | 11 ++---------
> drivers/mfd/palmas.c | 15 ++-------------
> drivers/mfd/tps65086.c | 12 ++----------
> drivers/mfd/tps65090.c | 12 ++----------
> drivers/mfd/tps65217.c | 14 +++-----------
> drivers/mfd/tps65218.c | 9 +++++----
> drivers/mfd/tps6586x.c | 12 ++----------
Are all of these drivers DT only?
> 9 files changed, 22 insertions(+), 86 deletions(-)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 0/9] mfd: Remove redundant i2c_device_id
2017-06-05 10:37 ` [PATCH 0/9] mfd: " Lee Jones
@ 2017-06-05 14:37 ` Keerthy
2017-06-06 7:17 ` Lee Jones
0 siblings, 1 reply; 17+ messages in thread
From: Keerthy @ 2017-06-05 14:37 UTC (permalink / raw)
To: Lee Jones; +Cc: tony, milo.kim, linux-omap, linux-kernel
On Monday 05 June 2017 04:07 PM, Lee Jones wrote:
> On Sun, 04 Jun 2017, Keerthy wrote:
>
>> With the introduction of probe_new function the i2c_device_id
>> is no longer needed. Hence the remove the same and use probe_new
>> instead of probe.
>>
>> Keerthy (9):
>> mfd: tps65217: Remove redundant i2c_device_id
>> mfd: tps65218: Remove redundant i2c_device_id
>> mfd: palmas: Remove redundant i2c_device_id
>> mfd: lp873x: Remove redundant i2c_device_id
>> mfd: lp8788: Remove redundant i2c_device_id
>> mfd: lp3943: Remove redundant i2c_device_id
>> mfd: tps65086: Remove redundant i2c_device_id
>> mfd: tps65090: Remove redundant i2c_device_id
>> mfd: tps6586x: Remove redundant i2c_device_id
>>
>> drivers/mfd/lp3943.c | 11 ++---------
>> drivers/mfd/lp873x.c | 12 ++----------
>> drivers/mfd/lp8788.c | 11 ++---------
>> drivers/mfd/palmas.c | 15 ++-------------
>> drivers/mfd/tps65086.c | 12 ++----------
>> drivers/mfd/tps65090.c | 12 ++----------
>> drivers/mfd/tps65217.c | 14 +++-----------
>> drivers/mfd/tps65218.c | 9 +++++----
>> drivers/mfd/tps6586x.c | 12 ++----------
>
> Are all of these drivers DT only?
At least i did not find any platform code calling on to these drivers.
No dependency on OF as such. Hence sent these 9.
>
>> 9 files changed, 22 insertions(+), 86 deletions(-)
>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 0/9] mfd: Remove redundant i2c_device_id
2017-06-05 14:37 ` Keerthy
@ 2017-06-06 7:17 ` Lee Jones
2017-06-06 7:30 ` Keerthy
0 siblings, 1 reply; 17+ messages in thread
From: Lee Jones @ 2017-06-06 7:17 UTC (permalink / raw)
To: Keerthy; +Cc: tony, milo.kim, linux-omap, linux-kernel
On Mon, 05 Jun 2017, Keerthy wrote:
>
>
> On Monday 05 June 2017 04:07 PM, Lee Jones wrote:
> > On Sun, 04 Jun 2017, Keerthy wrote:
> >
> >> With the introduction of probe_new function the i2c_device_id
> >> is no longer needed. Hence the remove the same and use probe_new
> >> instead of probe.
> >>
> >> Keerthy (9):
> >> mfd: tps65217: Remove redundant i2c_device_id
> >> mfd: tps65218: Remove redundant i2c_device_id
> >> mfd: palmas: Remove redundant i2c_device_id
> >> mfd: lp873x: Remove redundant i2c_device_id
> >> mfd: lp8788: Remove redundant i2c_device_id
> >> mfd: lp3943: Remove redundant i2c_device_id
> >> mfd: tps65086: Remove redundant i2c_device_id
> >> mfd: tps65090: Remove redundant i2c_device_id
> >> mfd: tps6586x: Remove redundant i2c_device_id
> >>
> >> drivers/mfd/lp3943.c | 11 ++---------
> >> drivers/mfd/lp873x.c | 12 ++----------
> >> drivers/mfd/lp8788.c | 11 ++---------
> >> drivers/mfd/palmas.c | 15 ++-------------
> >> drivers/mfd/tps65086.c | 12 ++----------
> >> drivers/mfd/tps65090.c | 12 ++----------
> >> drivers/mfd/tps65217.c | 14 +++-----------
> >> drivers/mfd/tps65218.c | 9 +++++----
> >> drivers/mfd/tps6586x.c | 12 ++----------
> >
> > Are all of these drivers DT only?
>
> At least i did not find any platform code calling on to these drivers.
> No dependency on OF as such. Hence sent these 9.
I can't accept these changes on any drivers which does not depend on
OF as a hard requirement.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 0/9] mfd: Remove redundant i2c_device_id
2017-06-06 7:17 ` Lee Jones
@ 2017-06-06 7:30 ` Keerthy
2017-06-06 7:48 ` Keerthy
0 siblings, 1 reply; 17+ messages in thread
From: Keerthy @ 2017-06-06 7:30 UTC (permalink / raw)
To: Lee Jones; +Cc: tony, milo.kim, linux-omap, linux-kernel
On Tuesday 06 June 2017 12:47 PM, Lee Jones wrote:
> On Mon, 05 Jun 2017, Keerthy wrote:
>
>>
>>
>> On Monday 05 June 2017 04:07 PM, Lee Jones wrote:
>>> On Sun, 04 Jun 2017, Keerthy wrote:
>>>
>>>> With the introduction of probe_new function the i2c_device_id
>>>> is no longer needed. Hence the remove the same and use probe_new
>>>> instead of probe.
>>>>
>>>> Keerthy (9):
>>>> mfd: tps65217: Remove redundant i2c_device_id
>>>> mfd: tps65218: Remove redundant i2c_device_id
>>>> mfd: palmas: Remove redundant i2c_device_id
>>>> mfd: lp873x: Remove redundant i2c_device_id
>>>> mfd: lp8788: Remove redundant i2c_device_id
>>>> mfd: lp3943: Remove redundant i2c_device_id
>>>> mfd: tps65086: Remove redundant i2c_device_id
>>>> mfd: tps65090: Remove redundant i2c_device_id
>>>> mfd: tps6586x: Remove redundant i2c_device_id
>>>>
>>>> drivers/mfd/lp3943.c | 11 ++---------
>>>> drivers/mfd/lp873x.c | 12 ++----------
>>>> drivers/mfd/lp8788.c | 11 ++---------
>>>> drivers/mfd/palmas.c | 15 ++-------------
>>>> drivers/mfd/tps65086.c | 12 ++----------
>>>> drivers/mfd/tps65090.c | 12 ++----------
>>>> drivers/mfd/tps65217.c | 14 +++-----------
>>>> drivers/mfd/tps65218.c | 9 +++++----
>>>> drivers/mfd/tps6586x.c | 12 ++----------
>>>
>>> Are all of these drivers DT only?
>>
>> At least i did not find any platform code calling on to these drivers.
>> No dependency on OF as such. Hence sent these 9.
>
> I can't accept these changes on any drivers which does not depend on
> OF as a hard requirement.
Okay. So that is a per-requisite. At least palmas, tps65218, lp873x,
tps65217 imho can have the OF dependency. I will post patches for that
and then will resurrect this series.
Thanks for your feedback.
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 0/9] mfd: Remove redundant i2c_device_id
2017-06-06 7:30 ` Keerthy
@ 2017-06-06 7:48 ` Keerthy
2017-06-06 10:44 ` Tony Lindgren
0 siblings, 1 reply; 17+ messages in thread
From: Keerthy @ 2017-06-06 7:48 UTC (permalink / raw)
To: Lee Jones, tony; +Cc: milo.kim, linux-omap, linux-kernel
On Tuesday 06 June 2017 01:00 PM, Keerthy wrote:
>
>
> On Tuesday 06 June 2017 12:47 PM, Lee Jones wrote:
>> On Mon, 05 Jun 2017, Keerthy wrote:
>>
>>>
>>>
>>> On Monday 05 June 2017 04:07 PM, Lee Jones wrote:
>>>> On Sun, 04 Jun 2017, Keerthy wrote:
>>>>
>>>>> With the introduction of probe_new function the i2c_device_id
>>>>> is no longer needed. Hence the remove the same and use probe_new
>>>>> instead of probe.
>>>>>
>>>>> Keerthy (9):
>>>>> mfd: tps65217: Remove redundant i2c_device_id
>>>>> mfd: tps65218: Remove redundant i2c_device_id
>>>>> mfd: palmas: Remove redundant i2c_device_id
>>>>> mfd: lp873x: Remove redundant i2c_device_id
>>>>> mfd: lp8788: Remove redundant i2c_device_id
>>>>> mfd: lp3943: Remove redundant i2c_device_id
>>>>> mfd: tps65086: Remove redundant i2c_device_id
>>>>> mfd: tps65090: Remove redundant i2c_device_id
>>>>> mfd: tps6586x: Remove redundant i2c_device_id
>>>>>
>>>>> drivers/mfd/lp3943.c | 11 ++---------
>>>>> drivers/mfd/lp873x.c | 12 ++----------
>>>>> drivers/mfd/lp8788.c | 11 ++---------
>>>>> drivers/mfd/palmas.c | 15 ++-------------
>>>>> drivers/mfd/tps65086.c | 12 ++----------
>>>>> drivers/mfd/tps65090.c | 12 ++----------
>>>>> drivers/mfd/tps65217.c | 14 +++-----------
>>>>> drivers/mfd/tps65218.c | 9 +++++----
>>>>> drivers/mfd/tps6586x.c | 12 ++----------
>>>>
>>>> Are all of these drivers DT only?
>>>
>>> At least i did not find any platform code calling on to these drivers.
>>> No dependency on OF as such. Hence sent these 9.
>>
>> I can't accept these changes on any drivers which does not depend on
>> OF as a hard requirement.
>
> Okay. So that is a per-requisite. At least palmas, tps65218, lp873x,
> tps65217 imho can have the OF dependency. I will post patches for that
> and then will resurrect this series.
>
> Thanks for your feedback.
Tony,
I do not see any platform specific code for tps65218, tps65217 and
palmas. I believe they are all completely Device Tree based. Can i make
them depend on OF? It helps me clear up some unused data from their mfd
drivers.
Regards,
Keerthy
>
>
>>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 0/9] mfd: Remove redundant i2c_device_id
2017-06-06 7:48 ` Keerthy
@ 2017-06-06 10:44 ` Tony Lindgren
2017-06-06 11:01 ` Keerthy
0 siblings, 1 reply; 17+ messages in thread
From: Tony Lindgren @ 2017-06-06 10:44 UTC (permalink / raw)
To: Keerthy; +Cc: Lee Jones, milo.kim, linux-omap, linux-kernel
* Keerthy <j-keerthy@ti.com> [170606 00:52]:
> On Tuesday 06 June 2017 01:00 PM, Keerthy wrote:
> > On Tuesday 06 June 2017 12:47 PM, Lee Jones wrote:
> >>>> Are all of these drivers DT only?
> >>>
> >>> At least i did not find any platform code calling on to these drivers.
> >>> No dependency on OF as such. Hence sent these 9.
> >>
> >> I can't accept these changes on any drivers which does not depend on
> >> OF as a hard requirement.
> >
> > Okay. So that is a per-requisite. At least palmas, tps65218, lp873x,
> > tps65217 imho can have the OF dependency. I will post patches for that
> > and then will resurrect this series.
> >
> > Thanks for your feedback.
>
> Tony,
>
> I do not see any platform specific code for tps65218, tps65217 and
> palmas. I believe they are all completely Device Tree based. Can i make
> them depend on OF? It helps me clear up some unused data from their mfd
> drivers.
Yes all of arch/arm/mach-omap2 is device tree only nowadays.
There may be other SoCs or architectures using these too,
but grepping for platform_data should reveal that.
Regards,
Tony
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 0/9] mfd: Remove redundant i2c_device_id
2017-06-06 10:44 ` Tony Lindgren
@ 2017-06-06 11:01 ` Keerthy
0 siblings, 0 replies; 17+ messages in thread
From: Keerthy @ 2017-06-06 11:01 UTC (permalink / raw)
To: Tony Lindgren; +Cc: Lee Jones, milo.kim, linux-omap, linux-kernel
On Tuesday 06 June 2017 04:14 PM, Tony Lindgren wrote:
> * Keerthy <j-keerthy@ti.com> [170606 00:52]:
>> On Tuesday 06 June 2017 01:00 PM, Keerthy wrote:
>>> On Tuesday 06 June 2017 12:47 PM, Lee Jones wrote:
>>>>>> Are all of these drivers DT only?
>>>>>
>>>>> At least i did not find any platform code calling on to these drivers.
>>>>> No dependency on OF as such. Hence sent these 9.
>>>>
>>>> I can't accept these changes on any drivers which does not depend on
>>>> OF as a hard requirement.
>>>
>>> Okay. So that is a per-requisite. At least palmas, tps65218, lp873x,
>>> tps65217 imho can have the OF dependency. I will post patches for that
>>> and then will resurrect this series.
>>>
>>> Thanks for your feedback.
>>
>> Tony,
>>
>> I do not see any platform specific code for tps65218, tps65217 and
>> palmas. I believe they are all completely Device Tree based. Can i make
>> them depend on OF? It helps me clear up some unused data from their mfd
>> drivers.
>
> Yes all of arch/arm/mach-omap2 is device tree only nowadays.
> There may be other SoCs or architectures using these too,
> but grepping for platform_data should reveal that.
Yes Tony. I did that for all the above mentioned devices. I did not find
any references apart from device tree folder under arch/ folder.
Apart from device tree folder and drivers/ folder i do not see any
instances of palmas, tps65218, tps65917, lp873x.
Shall i go ahead and introduce dependency on OF?
>
> Regards,
>
> Tony
>
^ permalink raw reply [flat|nested] 17+ messages in thread